Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp439479pxb; Thu, 31 Mar 2022 08:48:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLha8P69gtiChe2i2Z/JTxedUj3YFFz7wfwuF92aKqDwxS8Dqmzd5C9hTe0S7uz/oHcjoB X-Received: by 2002:a05:6402:2342:b0:419:e86:c7d5 with SMTP id r2-20020a056402234200b004190e86c7d5mr17057231eda.92.1648741717680; Thu, 31 Mar 2022 08:48:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648741717; cv=none; d=google.com; s=arc-20160816; b=A/S7jeYq8hJlRm41jOqHAX4gAa7g9oIgSvfdGj26urj9wcJrqSrDNfbQ701Re9FlcP wmex1ib++a2a/FNPsariU9PyCHexi1ZaOMQYOcF6K34Ehkwepj6m2ZdLDkklu7zk9DcQ 1aJZnM5SXCMwk+sBqIEzMYBlX4YRHVf12p8rFKnEiBsjtFn0DH73ecueBiYQSF3aTO2y nybE9IxgPg5zxsoAS4psgVnLDIHheYEiPymS3iMaGvV8kqHnNjEseCwZgnFHRdxEZedp x5vjF30nxVTP/CksP7euxL89/ZJwMEp887mrrnwVIYGqa+O2RgJS45HQh15WgSgwyNjQ u/Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EbiS3HLq0XERaIyi0NA53wEY0wvULMbcn6VOie73CMA=; b=VXMRrNmA7PfrT7oMGYC/r7F2kKe5+iWhdfVwJHvQbOHe3vn+YRNmzPCzjXWNhsHZUD MIWRjAupsD06F01P+b6139EsLxv+72SWv7bzs90ywzBGCRXEQdkNlODFL3zZqLen6w67 kxQXpkYDQJzTq4SOqDlcB9cfTB1LcwzOEOOlsR+FbMZ82UlDPphjovx38n5TeM30/2+h RffxF1t0F0dOzoI9ipI5hyb9teaDgvVztOaDGnSYDIIFPN/s3lWSP2YpQJ558U9zdV9m VQUe9AlkSEG+3NFIuGyqKibvejpyv60tDYsdUDzCssE9li1qV5p+upbDai5fqH1KoMCe +bqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MdS05gEM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a50e005000000b00418fe90d5e1si24726310edl.431.2022.03.31.08.48.11; Thu, 31 Mar 2022 08:48:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MdS05gEM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236896AbiCaNhB (ORCPT + 99 others); Thu, 31 Mar 2022 09:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234284AbiCaNhA (ORCPT ); Thu, 31 Mar 2022 09:37:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DCE7103D8F; Thu, 31 Mar 2022 06:35:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9DBFE61926; Thu, 31 Mar 2022 13:35:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 155CCC340EE; Thu, 31 Mar 2022 13:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648733712; bh=aCkusMvkesrwDSvmS3BLFtnpnJ8E1fFKa/EVcuQFOM0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MdS05gEM0paDn3pjZwCJ9JM09dRKYhqJNi3J03JKqZP8No1NEfXyZZPNAaF89660e NT76ADpnFMGIp+y8MimStntvwxZPM10eFEnLKgnll9dlAAfJu48ChBw81aamd+/Hmx QTvd0a8gqDMpdsjExwJZVL4YwWgStgCgK4K2b6Ik= Date: Thu, 31 Mar 2022 15:35:05 +0200 From: Greg Kroah-Hartman To: Miguel Ojeda Cc: Miguel Ojeda , Linus Torvalds , rust-for-linux , linux-kernel , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Matthew Bakhtiari Subject: Re: [PATCH v5 06/20] rust: add `alloc` crate Message-ID: References: <20220317181032.15436-1-ojeda@kernel.org> <20220317181032.15436-7-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2022 at 03:19:51PM +0200, Miguel Ojeda wrote: > Hi Greg, > > On Thu, Mar 31, 2022 at 2:42 PM Greg Kroah-Hartman > wrote: > > > > This is a huge patch. Why not break it into 2, one that adds what is > > upstream, and then the second adds the "stuff on top" that you need for > > the kernel. Otherwise it's hard to know what is, and is not, upstream > > for us to be able to review from a kernel point of view. > > That is a good idea, will do. > > There are some files from upstream that we do not need, so they are > already deleted here (e.g. collections), thus what I will do is send > the first patch without those already and then another patch with the > modifications/additions we did. If you prefer to see the deleted files > in an intermediate step, I can also do that. Nah, I don't care about deleted files :) thanks, greg k-h