Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp449758pxb; Thu, 31 Mar 2022 09:02:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyU7+SyVT2ox8RYLC22xdFL/6lkbLTPyaxaf9PGQBj3V3ftBQGJh7gel2N2dfHXL9I+7I47 X-Received: by 2002:a05:6a00:179f:b0:4fa:ecc3:a6ea with SMTP id s31-20020a056a00179f00b004faecc3a6eamr6287263pfg.82.1648742554133; Thu, 31 Mar 2022 09:02:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648742554; cv=none; d=google.com; s=arc-20160816; b=Q/n5WT/XHFCExrRkDQ2uEBcdmHLiUFD2AV9GAZNXLIrlQACY5eouPKH3uSLXZfsbMf pf1O1Xb17TtPWLXGPqJp34/b09LY2JfhzHfPCkGnj3jx1zsB/1JVj8rZDIAj5G2cqP6A 03QlHXFshvI4rT+nkWnVbMAN71B4GHlxKgzSkyT7pNFJNfSrmE/Y3LHS0QUv3DET61vG iZUKnwyMjGD7jYEuDP9lM9YPX1STGba+Z5SvecDePSfi77QLjNInX7N+Df7dwQ9T7MRf 8rT/YW4ykYM23QaLbL+KqS41uoeRR93FSXHjcL2YNnnvtBofGAEDP+cfUBEKd2bIDbar eNHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=CPZ4hCXKwIXk7YMGVqp572yiJSSQfJOtLx28fJXPSlo=; b=UqMWY1W2RQTKBjtpQLolHdHjkdYXrI4urO692uhHBeHGXx6nACIGeQFsICtJB8/t5g AtcU8JXH32xX1LHBmDx7S41fEhv6fZ6Vyb+fENT5if6WvSp+QHZ/camEVd0tW0benC3t 2wfRH5zIfPOARgHZwOXdWRY3sW3yKz2D9yz696gaf3PN9o51aJlmpvwHDUA4ucBWy6Ye xlcCU0TDC8kE2NmWmDfXBdZ1JZvXvZHm6BcEenMOPhpCpY4KplJTOF9IZml76PrOkzOZ TwJS0R1swi2bn6TPxmpCbp2frf+q/pFLp6v21+qIvJqRLLZYjjm3jaQfSJVGOKhrZ3dV QqzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t1-20020a170902e84100b00153b2d16512si20006074plg.282.2022.03.31.09.02.17; Thu, 31 Mar 2022 09:02:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbiCaKa6 convert rfc822-to-8bit (ORCPT + 99 others); Thu, 31 Mar 2022 06:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbiCaKa5 (ORCPT ); Thu, 31 Mar 2022 06:30:57 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 93A0CC3D for ; Thu, 31 Mar 2022 03:29:08 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-263-wT2Z8KTZO1SBLQAzOKJ3pQ-1; Thu, 31 Mar 2022 11:29:05 +0100 X-MC-Unique: wT2Z8KTZO1SBLQAzOKJ3pQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 31 Mar 2022 11:29:04 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.033; Thu, 31 Mar 2022 11:29:04 +0100 From: David Laight To: 'Alaa Mohamed' , "outreachy@lists.linux.dev" CC: "gregkh@linuxfoundation.org" , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] staging: gdm724x: Fix Duplication of Side Effects Thread-Topic: [PATCH] staging: gdm724x: Fix Duplication of Side Effects Thread-Index: AQHYROi924sZ22xfrE+zbiso9jQv5KzZSk9w Date: Thu, 31 Mar 2022 10:29:04 +0000 Message-ID: References: <20220331101849.71046-1-eng.alaamohamedsoliman.am@gmail.com> In-Reply-To: <20220331101849.71046-1-eng.alaamohamedsoliman.am@gmail.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alaa Mohamed > Sent: 31 March 2022 11:19 > > Fix Duplication of Side Effects for GDM_TTY_READY(gdm) macro > reported by checkpatch > "CHECK: Macro argument reuse 'gdm' - possible side-effects?" > > Signed-off-by: Alaa Mohamed > --- > drivers/staging/gdm724x/gdm_tty.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c > index 04df6f9f5403..6f0274470e69 100644 > --- a/drivers/staging/gdm724x/gdm_tty.c > +++ b/drivers/staging/gdm724x/gdm_tty.c > @@ -27,7 +27,9 @@ > > #define MUX_TX_MAX_SIZE 2048 > > -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count) > +#define GDM_TTY_READY(_gdm) \ > + ({ typeof(_gdm) (gdm) = (_gdm); \ > + (gdm && gdm->tty_dev && gdm->port.count); }) Did you test this? see https://godbolt.org/z/cazPrrzPv David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)