Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp469559pxb; Thu, 31 Mar 2022 09:25:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEz25woTlp2BhC1rS1osd2ErS2l8hDVURw3FYZQuIuiwCWTnQkJAdiQIXMRVwLHUFvkwFu X-Received: by 2002:a05:6402:221b:b0:418:eb30:47ff with SMTP id cq27-20020a056402221b00b00418eb3047ffmr17741937edb.68.1648743922528; Thu, 31 Mar 2022 09:25:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648743922; cv=none; d=google.com; s=arc-20160816; b=fcAp8AF2QdoN3vcRCPE45kXZV/Jn3xluFgyeugS+XfITl1PgZGl4EbzCA0c7vwjHCz YnBOmMDo3H4Dh2y5cBFHYdWAHrA+xJ2jALjal+s3fq1wQWUOUe4hX4TrWQSvUPJ2oKlJ +z3mPi5CENw4icwj7ibWFZGwPkE9ErqFdPfaXkd3yD0+1ydygtJsJmR+p5N0MqllKiBL xLvAZ4L++hY0GQBulvXZEtMfL23t0Gfy2gQ1rcDpEwYIVs2WIdDho9lXspXQnl46pN41 36Px31p1HHgjo9uejVFkG+RRwerGK3fMmlv0YepVwm6V1K0Dx63rzFGBwJ3HATJWxPD7 YVUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:organization :subject:cc:to:from:dkim-signature; bh=3qad0vu847N501JVj+B9zfqjiTiuw/ACV2x6SxDvb2M=; b=JrPvoKt6O/FCY1AjdZzBGwdizdcI3mvhUpthKCsAMW1F13SE30uOP6EOdMd6dMRBOf SrGWSoTLQt5RvVbX1Qy3HuWsCV3r4ylp8/YsMgz2dMb5v16f2tCKbMdizIsYoU7SMaLv jkXoitz74MKeCRVwveRBGmbb/vcT+O8T1nA7BHjCE1NlJCGGqWPEYvs/+Pfpz6hl4MJU v8Ndh1nIlZj98UisGpviL27cQ5u3j69qlxWnD50Lu0nEpLJ9iy66XN7hHWTw8vyeutgV ES8lmO5C94fmkd8mGIVFEhs2/YqROiHygGS+eu9GOlZboSpmKKTlElhtRgRcBiLyxZaP 8KBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mork.no header.s=b header.b=Z3DvLyPG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mork.no Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020a170906558400b006e055c9c954si3021ejp.552.2022.03.31.09.24.56; Thu, 31 Mar 2022 09:25:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mork.no header.s=b header.b=Z3DvLyPG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mork.no Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236535AbiCaNAj (ORCPT + 99 others); Thu, 31 Mar 2022 09:00:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236517AbiCaNAc (ORCPT ); Thu, 31 Mar 2022 09:00:32 -0400 Received: from louie.mork.no (louie.mork.no [IPv6:2001:41c8:51:8a:feff:ff:fe00:e5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D30A718382A; Thu, 31 Mar 2022 05:58:36 -0700 (PDT) Received: from canardo.dyn.mork.no ([IPv6:2a01:799:c9f:8600:0:0:0:1]) (authenticated bits=0) by louie.mork.no (8.15.2/8.15.2) with ESMTPSA id 22VCwErm206850 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Thu, 31 Mar 2022 13:58:16 +0100 Received: from miraculix.mork.no ([IPv6:2a01:799:c9f:8602:8cd5:a7b0:d07:d516]) (authenticated bits=0) by canardo.dyn.mork.no (8.15.2/8.15.2) with ESMTPSA id 22VCwC1b3975823 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Thu, 31 Mar 2022 14:58:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1648731494; bh=3qad0vu847N501JVj+B9zfqjiTiuw/ACV2x6SxDvb2M=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=Z3DvLyPGhXpJCOh58KXP7rFdbDdw8HiozWFs+fYFn8M1SYJG4TV2gRAl5a4JH3Hvc wNiZBwjXwjqUdnf8vvvB0pLSh8ECgbd0QDLLmJF1xZppE0ovaJ0uvEq+bk/rucMnIF OrkQrrBCVPXZWHdS5pm8OwWCxXFXNNLbasYwjtHs= Received: (nullmailer pid 178357 invoked by uid 1000); Thu, 31 Mar 2022 12:58:12 -0000 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Qing Wang Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: usb: remove duplicate assignment Organization: m References: <1648728494-37344-1-git-send-email-wangqing@vivo.com> Date: Thu, 31 Mar 2022 14:58:12 +0200 In-Reply-To: <1648728494-37344-1-git-send-email-wangqing@vivo.com> (Qing Wang's message of "Thu, 31 Mar 2022 05:08:14 -0700") Message-ID: <87sfqygty3.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.103.5 at canardo X-Virus-Status: Clean X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Qing Wang writes: > netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed, > no need to repeat assignment. Thanks. Acked-by: Bj=C3=B8rn Mork