Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932190AbXB1SRG (ORCPT ); Wed, 28 Feb 2007 13:17:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932194AbXB1SRG (ORCPT ); Wed, 28 Feb 2007 13:17:06 -0500 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:54901 "EHLO netops-testserver-4.corp.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932190AbXB1SRF (ORCPT ); Wed, 28 Feb 2007 13:17:05 -0500 Date: Wed, 28 Feb 2007 10:17:03 -0800 (PST) From: Christoph Lameter To: Andy Whitcroft cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman Subject: Re: [PATCH 2/5] lumpy: isolate_lru_pages wants to specifically take active or inactive pages In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 16 On Tue, 27 Feb 2007, Andy Whitcroft wrote: > The caller of isolate_lru_pages specifically knows whether it wants > to take either inactive or active pages. Currently we take the > state of the LRU page at hand and use that to scan for matching > pages in the order sized block. If that page is transiting we > can scan for the wrong type. The caller knows what they want and > should be telling us. Pass in the required active/inactive state > and match against that. The page cannot be transiting since we hold the lru lock? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/