Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <78917523440153533f0b5aad533a96d0f7c27916.camel@redhat.com>
Subject: Re: [PATCH net] rxrpc: fix some null-ptr-deref bugs in server_key.c
From:   Paolo Abeni <pabeni@redhat.com>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org,
        Xiaolong Huang <butterflyhuangxx@gmail.com>,
        Marc Dionne <marc.dionne@auristor.com>,
        linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Thu, 31 Mar 2022 15:20:24 +0200
In-Reply-To: <3114597.1648729013@warthog.procyon.org.uk>
References: <4de651adc35341c5fa99db54b9295d4845648563.camel@redhat.com>
         <164865013439.2941502.8966285221215590921.stgit@warthog.procyon.org.uk>
         <3114597.1648729013@warthog.procyon.org.uk>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2022-03-31 at 13:16 +0100, David Howells wrote:
> Paolo Abeni <pabeni@redhat.com> wrote:
> 
> > It looks like we can add a couple of fixes tag to help stable teams:
> > 
> > Fixes: d5953f6543b5 ("rxrpc: Allow security classes to give more info on server keys")
> 
> Not this one.  This includes a check for the one op it adds:
> 
> 	+       if (sec && sec->describe_server_key)
> 	+               sec->describe_server_key(key, m);
> 
> 
> > Fixes: 12da59fcab5a ("xrpc: Hand server key parsing off to the security class")
> 
> There's a missing 'r' in "rxrpc:" in the patch subject, but otherwise this one
> looks like the right one.

Thank you for double-checking. No need to repost, I'll add the tag
while applying it.

Cheeers,

Paolo