Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp509536pxb; Thu, 31 Mar 2022 10:19:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOUXs+FA+YfCJvTY/hDAa/zbcAXoZoTGGNiVtAvVoI+ctRpdWxwg+zyWojYOpX7nhXWmYZ X-Received: by 2002:a17:902:f789:b0:156:5f56:ddff with SMTP id q9-20020a170902f78900b001565f56ddffmr1860378pln.116.1648747160731; Thu, 31 Mar 2022 10:19:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648747160; cv=none; d=google.com; s=arc-20160816; b=sGobPP07pDbv1vR+QXnb6Wp7NJJhfOPiqmGAXrPJNKqPt3WEmRm9pbdHL25inN+jtH Kin4bVyb595WMSgZtHtq+514BRFbpkXnXSfB1mdzwBcCRcTWN+QlujrFM24omr+d9LfT etPm9MgepU/OhiB0YDIPpCJfCezwiJggQ+K5lFYPpyvs9vuf3FdKpxg7GGbG8rb5xY6Q JHHpKzOz9X+2tofNptgylM48nSS1o3nr9APdXXxcHKcYXInXqqE2vqTbYCsYLzHuFhmE CPSoIve/zcecho7yc5K4fQe2cqXW0UOEz9ppDjKMtoKuEcU0h6eFVOSfc5UBl8Ry0HU0 VKTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=f5/8+4RwHAMD/KHypXq8zvLNL9+H5+MYFtmie7z/yWo=; b=y/vQdng47kSfaosOxkW8towREJOX8mmK6CC8FBzyKhyeWezcHXf6iIL+9lSGDq30kQ UrFDxPCRGfCTKzB++qwp3GRz7bAtfoVgJU+ooIxrsvBjdI/LhnoRVmzSsfDZEJsuL4yB FTQiWPpdy2mdXPfVlmMu1SCFpDJZ3pHzvHYCCIh/63yzL7SE81D9G/lVfXmy0aBVhAJ8 NosZClrusA2gtb2UTNLM5t2Od0T/I3uDv8xU0IyMPIk+n01Bb6fHTxrdZZi2Z06Sa1zt OfsJ2Mfxdb9QZf98OfbsEvYIAjwqk0LvpQSWz7wlcS5iKyzm8aL0db1xBURCAegDAKp8 Lu6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ML3mFkWU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u2-20020a654c02000000b00381fa9dc403si91289pgq.679.2022.03.31.10.19.05; Thu, 31 Mar 2022 10:19:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ML3mFkWU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235965AbiCaMTB (ORCPT + 99 others); Thu, 31 Mar 2022 08:19:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235973AbiCaMS5 (ORCPT ); Thu, 31 Mar 2022 08:18:57 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2B9AB210446 for ; Thu, 31 Mar 2022 05:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648729029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f5/8+4RwHAMD/KHypXq8zvLNL9+H5+MYFtmie7z/yWo=; b=ML3mFkWUAhVX7l1ezPZEfuT6rJu8u3Is8YlayEeqH2h9VDYG+BRZgKjsM23eKtpqbZH6Bz GF2PQKUGNZ3yRQ/KZ4Wd8Zuyf3peQuQrfjt8YT/QCKvjWyJaoCUxBLaELQuELE9ORrUGcL N75yQSdRUaA7z18QxbNPY2PaHNb5W/c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-290-v7RIh1xtMi-XLByMpu-iUA-1; Thu, 31 Mar 2022 08:17:04 -0400 X-MC-Unique: v7RIh1xtMi-XLByMpu-iUA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D7914801E95; Thu, 31 Mar 2022 12:16:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8AC852026D64; Thu, 31 Mar 2022 12:16:54 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <4de651adc35341c5fa99db54b9295d4845648563.camel@redhat.com> References: <4de651adc35341c5fa99db54b9295d4845648563.camel@redhat.com> <164865013439.2941502.8966285221215590921.stgit@warthog.procyon.org.uk> To: Paolo Abeni Cc: dhowells@redhat.com, netdev@vger.kernel.org, Xiaolong Huang , Marc Dionne , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] rxrpc: fix some null-ptr-deref bugs in server_key.c MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3114596.1648729013.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 31 Mar 2022 13:16:53 +0100 Message-ID: <3114597.1648729013@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo Abeni wrote: > It looks like we can add a couple of fixes tag to help stable teams: > = > Fixes: d5953f6543b5 ("rxrpc: Allow security classes to give more info on= server keys") Not this one. This includes a check for the one op it adds: + if (sec && sec->describe_server_key) + sec->describe_server_key(key, m); > Fixes: 12da59fcab5a ("xrpc: Hand server key parsing off to the security = class") There's a missing 'r' in "rxrpc:" in the patch subject, but otherwise this= one looks like the right one. Thanks, David