Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp517021pxb; Thu, 31 Mar 2022 10:30:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvHxbK4i7ImAGBcwiMcNb7pmLolSQCK4j8d+U/tzfJUZCpWksXipKThoZiB6/uCXsectho X-Received: by 2002:a17:906:4fc4:b0:6da:b4c6:fadb with SMTP id i4-20020a1709064fc400b006dab4c6fadbmr6096840ejw.282.1648747817148; Thu, 31 Mar 2022 10:30:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648747817; cv=none; d=google.com; s=arc-20160816; b=MaZarBqcqiW86mwBxalK78v8tHXRf0nF7H4mYrD0aiFUZF0L90+qUDvkpBS79MQHcb mXZQxZ8heTJ0d9vX+xBuMhetzAAM4upjsDxrIiL27mToyFQUnQDHz9uG4dl8GMh7qEsj K6F0ymN0IB16hV8g8rpT6exBOlMaZSYYD3qNS4NGGL7TVvQbKPTiPy9tAyyiM8YDMcmh dbxgYdFG1bepnuswg5bQHFce6F9Y7FvjJ+H4LpZINt7JXQ//KV6pa5Qc2ie+epGO+a+Q xEcwEkP4b/i4I/dGYF/aq2Ry/zSKnjIko4wx7DGpurAdtFJj2098LFVvIH7vdviCl9sO qq+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Tx0sdfqMI+WAOlkk5kWPZrGK93j5rJC3g56V1X6se5o=; b=RV5M58BLhzmCjRx0gOZHHXeEgoSbrZhGHiArRYrxkT4B1PqnJY0VIB3TlPADGlFxyZ b2eeBw5aVyZ1UKQDqozVe71r8J7fYmGHVDfuxgn6hVvfh6ZEushdTSeYn/A/kX4tIWdL dvwAE93ebLPtA+cfY/T0NDXAYiaA6IsTOvo1jTvMn/Q9o4h2qUdTi4rD2N5MEgbBKh3G asSYeZq62HY6vmB4FivedoSiWt9yCosSvzt6UMMGZP1otUiTeY/lEdXwp6buZgQChG8D h1Vvno67FyBqnfRHthNSmx6Uogz79S5xTYWVc1NxxcI336F3rzbStU+Ow4fRldO2Zl1N +l+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AaQ5coN5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v18-20020a17090606d200b006df76385c8dsi108249ejb.301.2022.03.31.10.29.49; Thu, 31 Mar 2022 10:30:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AaQ5coN5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235204AbiCaLfv (ORCPT + 99 others); Thu, 31 Mar 2022 07:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232097AbiCaLfr (ORCPT ); Thu, 31 Mar 2022 07:35:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1FF9148678 for ; Thu, 31 Mar 2022 04:34:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A1956B81BE2 for ; Thu, 31 Mar 2022 11:33:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D63BFC340EE; Thu, 31 Mar 2022 11:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648726438; bh=cjZmh4LdpDHRvlpgeNidC1QaRwP08X6tDdjVpm3xYGQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AaQ5coN5SmKou+2F7UPD6+lpEu+jU0MMHN4fhg6QITovSIruPU1636r/lMrRPBxMW 7Egpw8lfRyvT+zTl7oKd7XmWYGoUeRTn04xMJQv8fpFRfaq1DVYJfrcdUqymzn1nxg SLwqGj8zsoRTkghVTd1iluyx8ZnM/meuW3BHAlzk= Date: Thu, 31 Mar 2022 13:33:54 +0200 From: Greg KH To: Alaa Mohamed Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gdm724x: Fix Duplication of Side Effects Message-ID: References: <20220331101849.71046-1-eng.alaamohamedsoliman.am@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331101849.71046-1-eng.alaamohamedsoliman.am@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2022 at 12:18:49PM +0200, Alaa Mohamed wrote: > Fix Duplication of Side Effects for GDM_TTY_READY(gdm) macro > reported by checkpatch > "CHECK: Macro argument reuse 'gdm' - possible side-effects?" There are no such side-effects here, sorry. Please always evaluate the code to see what it does, checkpatch sometimes gets it wrong. thanks, greg k-h