Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Mar 2022 18:16:52 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: place constants on the right side of
 tests
Message-ID: <20220331151652.GS3293@kadam>
References: <20220331121550.GA429809@euclid>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220331121550.GA429809@euclid>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NRtRwyToUTu/Nh2pSndtMRpohUGBFGuh1WVa9ChzXuPpY0J53VhOEBwhDG2Z?=
 =?us-ascii?Q?qGcfo64P7/1ghMyvrCG1iMeMS9MIGR3Pzp2MY8i5H9TyJ3sy8VqjvSd4psT7?=
 =?us-ascii?Q?AGjIS82L84DcDbeXvi5/9uoauVaqGG6dUSvFLFnH56gg7EaaV6COeRLfwqBk?=
 =?us-ascii?Q?tC0nTuq8rWQR0LQ1Sp5cB4/vXMIWhkTtuPoAwqVUiO1WzC8fdWTHxazIxC8M?=
 =?us-ascii?Q?buJ6TgFH5Awt+Z+aLndxfSKSRjq6tPlFpVuccpabBKuxq4czHtz0KgVY4zuC?=
 =?us-ascii?Q?A32iSil11U6XyLlWeY+Dj2XYyOJIfAYu0gjp9muEbF0jsAR+TA8lWQLy8Hke?=
 =?us-ascii?Q?xTRx4H4tCLHdlsGzJfOYuBdgcmz4jVpOikYqnjLvXS1gZd+ka6Sj/qcnoIwb?=
 =?us-ascii?Q?6OLO8gFIYXMhOwvHFDUuG2gkar+tw+huTd7uP+WhJ2W7QudYUsSpN10PXGPd?=
 =?us-ascii?Q?cHr2bFTvd00aCT7oBpV0FUmxRv2gxhDnz8GMylNL/jXFAyWFRQPNGCJpEeTa?=
 =?us-ascii?Q?8ysgHjhYBX+wzbBPby8FbdDFMZ9gpbzkI2cverasqw3mQ0cOMaPOZ31wXOND?=
 =?us-ascii?Q?2pM4K+nnBse1eParBtUengFPA3WXUsrlW6kYjtaQ5Lf5FrxSzZsG0ck8w42r?=
 =?us-ascii?Q?Eeym+uo3WRrxxgvlAt7iulrw6EVtrbp4WrCW7epXdF77uoABpdRq7vCpyIgT?=
 =?us-ascii?Q?j6C08x5Avo9kMCyOxut/UZmIaeuqYyfGFqwZdJi5CXYN1aW7PtBcZx/+wrGA?=
 =?us-ascii?Q?HOkw8LJEN/91ZkRO2MINU5MeUYxOG6Yen97/P69YoVNo4vom0vkatcA4W7+q?=
 =?us-ascii?Q?Z+eXYT3oJVI+sGFb9WHpAbq1C5RkxxbgnmkwvddmBCtyRXWo3hzOhQYBkwrG?=
 =?us-ascii?Q?yIq4ahEFeWsA8hkxLP4SIkxyYkJKElmnkHHZdaPhFVsLVM326GRqaSOrOJYO?=
 =?us-ascii?Q?wV/IZgVNzQbl8Jeh3Zwe5kmbzm6VS413fqzGtQiwSaxtYPlXq+RHaDkQ3MhI?=
 =?us-ascii?Q?l8p+Bm9QrMxxLexkVZlQHsthcnfaPleSTc+e8IupobzV3J3cfRM/bsg7kKch?=
 =?us-ascii?Q?xx+9yq4LoxH82cLW2E0N73JXrlxcVpS+MWDnppUQ0Wc09gwSKM2HloJw011E?=
 =?us-ascii?Q?v8l4sXn+1maW7tDu+mlS79zFnv56CageM/O9D76YiJgeC/TiYOyXbCmsfdGO?=
 =?us-ascii?Q?5MZ1fbqSHkmhDftlCogAcDzxSKp4i6qDkauAvcFvqVnzDJsc/8Q/ns4xNjkF?=
 =?us-ascii?Q?HPkPLzeZp2ryskfhbl78ZTybRbmmH2r784GK90JUX96Uru2WJ8VczPP6C4CP?=
 =?us-ascii?Q?vtpilTSxdf6IzKHAJVmN+8te0JkCnk7wGvXfJ32OxbyblnZc/My6KPjRfTS7?=
 =?us-ascii?Q?GRYAHEUg5jGg0CEHmrZ8SPz9RnJOa5NV+Hr7yjYXPQ2ezg7ahGihvGwRcsMH?=
 =?us-ascii?Q?ApI+pKlScjzMjrFqtLTdTslOcGFjqA3AKJm5P3BRmvUOp5/80DYsHr81kNWC?=
 =?us-ascii?Q?sQdtJbeN9UyYoCzO4R8n9mNyqRJnoTloxNGq0udyYdvAHC9Q2N9oojWZIkxU?=
 =?us-ascii?Q?KTpG9bQPIAbag7DkwX8WhIP+qvGlxzQGKKLmUTNaKPuob8uHwGueVZiK4wlU?=
 =?us-ascii?Q?2q9QyWsCl9Cv1tSZUtK878eL+WN8DU21acbsD2T4bEnByqhUHuzdxT0XEjNM?=
 =?us-ascii?Q?C9m/h2z8odm7u0QGyTLA5KJLu1ykMnuZtHH7iJ2lf91YW75c5v896i1sFU05?=
 =?us-ascii?Q?4xlHgSzwbVaWquXBONwissXIM58mvWI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bfbfc4a6-1035-4335-d17a-08da132987c1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 15:17:12.1371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ofj8B9zwTUFrhn62NHXbSwyCkl8mXyak4m2wx8mG36pIjrfwRTVXNdQRjeFQTFyPWcBVqyLyhOSP6lt2EvQwf8/qNB4sH7VB5nQ+MampAhE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5067
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-03-31_05:2022-03-30,2022-03-31 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=774
 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203310085
X-Proofpoint-ORIG-GUID: iPjdI24OUIIwPzN0Zx-h43iA5NU96zWB
X-Proofpoint-GUID: iPjdI24OUIIwPzN0Zx-h43iA5NU96zWB
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 31, 2022 at 08:15:50AM -0400, Sevinj Aghayeva wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> WARNING: Comparisons should place the constant on the right side of the test
> 
> Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>

Hi Greg,

Don't apply this one.  There is a later version that does more cleanup.

regards,
dan carpenter