Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbXB1Sna (ORCPT ); Wed, 28 Feb 2007 13:43:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932255AbXB1Sna (ORCPT ); Wed, 28 Feb 2007 13:43:30 -0500 Received: from madara.hpl.hp.com ([192.6.19.124]:63109 "EHLO madara.hpl.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932227AbXB1Sn3 (ORCPT ); Wed, 28 Feb 2007 13:43:29 -0500 Date: Wed, 28 Feb 2007 10:43:14 -0800 To: Greg KH Cc: "David S. Miller" , Linux kernel mailing list , netdev@vger.kernel.org Subject: Re: [PATCH 2.6.20] kobject net ifindex + rename Message-ID: <20070228184314.GC6134@bougret.hpl.hp.com> Reply-To: jt@hpl.hp.com References: <20070228012741.GA3988@bougret.hpl.hp.com> <20070228153617.GA5670@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070228153617.GA5670@suse.de> Organisation: HP Labs Palo Alto Address: HP Labs, 1U-17, 1501 Page Mill road, Palo Alto, CA 94304, USA. E-mail: jt@hpl.hp.com User-Agent: Mutt/1.5.9i From: Jean Tourrilhes X-HPL-MailScanner: Found to be clean X-HPL-MailScanner-From: jt@hpl.hp.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 34 On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote: > On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote: > > diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c > > --- linux/drivers/base/class.j1.c 2007-02-26 18:38:10.000000000 -0800 > > +++ linux/drivers/base/class.c 2007-02-27 15:52:37.000000000 -0800 > > @@ -841,6 +841,8 @@ int class_device_rename(struct class_dev > > This function is not in the 2.6.21-rc2 kernel, so you might want to > rework this patch a bit :) It was a trial balloon to gather feedback. I will do. > Also, it's userspace that causes the rename to happen, so it knows it > did it, why should the kernel have to emit a message to tell userspace > again what just happened? Username is not one big program, but a collection of program, and one program does not know what another program do. In particular, udev does not know when people are using iproute2 to rename interface and loose its marbles. We don't really want to ban iproute2 or udev ;-) > thanks, > > greg k-h Have fun... Jean - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/