Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e93a7d66-7e43-d2c7-ad85-fb24d50effc5@arm.com>
Date:   Thu, 31 Mar 2022 16:37:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] arch/arm64: Fix topology initialization for core
 scheduling
Content-Language: en-US
To:     Phil Auld <pauld@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        linux-arm-kernel@lists.infradead.org
References: <20220330155611.30216-1-pauld@redhat.com>
 <66f29bee-e26c-b40e-c3af-79d5297565d8@arm.com>
 <20220331132103.GB17613@pauld.bos.csb>
From:   Dietmar Eggemann <dietmar.eggemann@arm.com>
In-Reply-To: <20220331132103.GB17613@pauld.bos.csb>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 31/03/2022 15:21, Phil Auld wrote:
> On Thu, Mar 31, 2022 at 11:04:31AM +0200 Dietmar Eggemann wrote:
>> On 30/03/2022 17:56, Phil Auld wrote:

[...]

>> Ah, the reason is that smt_mask is not correctly setup, so we bail on
>> `cpumask_weight(smt_mask) == 1` for !leaders in:
>>
>> notify_cpu_starting()
>>   cpuhp_invoke_callback_range()
>>     sched_cpu_starting()
>>       sched_core_cpu_starting()
>>
>> which leads to rq->core not being correctly set for !leader-rq's.
>>
> 
> Exactly, sorry I was not clearer.  smt_mask must be setup correctly 
> by the time sched_core_cpu_starting() is called. (Maybe I should crib
> some of the above lines into the commit message?)

Yeah, maybe, it wouldn't hurt I guess. IMHO mentioning stress-ng's prctl
needs PR_SCHED_CORE support could also be handy since today's stress-ng
packages don't seem to have this yet.