Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932255AbXB1SpL (ORCPT ); Wed, 28 Feb 2007 13:45:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932264AbXB1SpL (ORCPT ); Wed, 28 Feb 2007 13:45:11 -0500 Received: from smtp.osdl.org ([65.172.181.24]:38758 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932255AbXB1SpJ (ORCPT ); Wed, 28 Feb 2007 13:45:09 -0500 Date: Wed, 28 Feb 2007 10:42:49 -0800 (PST) From: Linus Torvalds To: Davide Libenzi cc: Ingo Molnar , Ulrich Drepper , Linux Kernel Mailing List , Arjan van de Ven , Christoph Hellwig , Andrew Morton , Alan Cox , Zach Brown , Evgeniy Polyakov , "David S. Miller" , Suparna Bhattacharya , Jens Axboe , Thomas Gleixner Subject: Re: [patch 00/13] Syslets, "Threadlets", generic AIO support, v3 In-Reply-To: Message-ID: References: <20070221211355.GA7302@elte.hu> <20070221233111.GB5895@elte.hu> <45DCD9E5.2010106@redhat.com> <20070222074044.GA4158@elte.hu> <20070228094522.GA17716@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1090 Lines: 31 On Wed, 28 Feb 2007, Davide Libenzi wrote: > > Here we very much agree. The way I'd like it: > > struct async_syscall { > unsigned long nr_sysc; > unsigned long params[8]; > long result; > }; No, the "result" needs to go somewhere else. The caller may be totally uninterested in keeping the system call number or parameters around until the operation completes, but if you put them in the same structure with the result, you obviously cannot sanely get rid of them. I also don't much like read-write interfaces (which the above would be: the kernel would read most of the structure, and then write one member of the structure). It's entirely possible, for example, that the operation we submit is some legacy "aio_read()", which has soem other structure layout than the new one (but one field will be the result code). Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/