Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Mar 2022 09:31:01 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Shlomo Pongratz <shlomopongratz@gmail.com>
Cc:     linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        andrew.maier@eideticom.com, logang@deltatee.com,
        bhelgaas@google.com, jgg@nvidia.com,
        Shlomo Pongratz <shlomop@pliops.com>
Subject: Re: [PATCH V5 1/1] Intel Sky Lake-E host root ports check.
Message-ID: <20220331143101.GA4846@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220331073539.14499-2-shlomop@pliops.com>
Precedence: bulk

On Thu, Mar 31, 2022 at 10:35:39AM +0300, Shlomo Pongratz wrote:
> In commit 7b94b53db34f ("PCI/P2PDMA: Add Intel Sky Lake-E Root Ports B, C, D to
> the whitelist")
> Andrew Maier added the Sky Lake-E additional devices
> 2031, 2032 and 2033 root ports to the already existing 2030 device.
> 
> The Intel devices 2030, 2031, 2032 and 2033 which are root ports A, B, C and D,
> respectively and if all exist they will occupy slots 0 till 3 in that order.

Please make this a sentence.

> The original code handled only the case where the devices in the whitelist are
> host bridges and assumed that they will be found on slot 0.
> 
> This assumption doesn't hold for root ports so an explicit test was added to
> cover this case.

Please update the subject line to match the style of previous ones.

Please wrap the commit log to fit in 80 columns (including the 4
spaces added by "git log") like previous commits.

Please figure out whether you want "Sky Lake-E" or "SkyLake-E" and use
it consistently in commit log and code comments.  It seems to be
"Skylake" on intel.com, so I suggest using that.

Please use imperative mood, e.g., instead of "an explicit test was
added ...," write "add a test to cover this case."  Do the same in
code comments.

Bjorn