Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932256AbXB1Suc (ORCPT ); Wed, 28 Feb 2007 13:50:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932275AbXB1Suc (ORCPT ); Wed, 28 Feb 2007 13:50:32 -0500 Received: from x35.xmailserver.org ([64.71.152.41]:4806 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932256AbXB1Sub (ORCPT ); Wed, 28 Feb 2007 13:50:31 -0500 X-AuthUser: davidel@xmailserver.org Date: Wed, 28 Feb 2007 10:50:28 -0800 (PST) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Linus Torvalds cc: Ingo Molnar , Ulrich Drepper , Linux Kernel Mailing List , Arjan van de Ven , Christoph Hellwig , Andrew Morton , Alan Cox , Zach Brown , Evgeniy Polyakov , "David S. Miller" , Suparna Bhattacharya , Jens Axboe , Thomas Gleixner Subject: Re: [patch 00/13] Syslets, "Threadlets", generic AIO support, v3 In-Reply-To: Message-ID: References: <20070221211355.GA7302@elte.hu> <20070221233111.GB5895@elte.hu> <45DCD9E5.2010106@redhat.com> <20070222074044.GA4158@elte.hu> <20070228094522.GA17716@elte.hu> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 46 On Wed, 28 Feb 2007, Linus Torvalds wrote: > On Wed, 28 Feb 2007, Davide Libenzi wrote: > > > > Here we very much agree. The way I'd like it: > > > > struct async_syscall { > > unsigned long nr_sysc; > > unsigned long params[8]; > > long result; > > }; > > No, the "result" needs to go somewhere else. The caller may be totally > uninterested in keeping the system call number or parameters around until > the operation completes, but if you put them in the same structure with > the result, you obviously cannot sanely get rid of them. > > I also don't much like read-write interfaces (which the above would be: > the kernel would read most of the structure, and then write one member of > the structure). > > It's entirely possible, for example, that the operation we submit is some > legacy "aio_read()", which has soem other structure layout than the new > one (but one field will be the result code). Ok, makes sense. Something like this then? struct async_syscall { unsigned long nr_sysc; unsigned long params[8]; long *result; }; And what would async_wait() return bak? Pointers to "struct async_syscall" or pointers to "result"? - Davide - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/