Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <51522714-1194-57cf-b5c2-af497671fa09@kernel.dk>
Date:   Thu, 31 Mar 2022 06:06:52 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] block: use dedicated list iterator variable
Content-Language: en-US
To:     Jakob Koschel <jakobkoschel@gmail.com>
Cc:     linux-block <linux-block@vger.kernel.org>,
        linux-kernel@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
References: <20220331091218.641532-1-jakobkoschel@gmail.com>
 <a7b2fe8d-9967-2046-67a5-62d10e95a861@kernel.dk>
 <E262CAA9-1B49-4035-9181-28C6FFDBE21F@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <E262CAA9-1B49-4035-9181-28C6FFDBE21F@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/31/22 6:00 AM, Jakob Koschel wrote:
> 
> 
>> On 31. Mar 2022, at 13:59, Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 3/31/22 3:12 AM, Jakob Koschel wrote:
>>> To move the list iterator variable into the list_for_each_entry_*()
>>> macro in the future it should be avoided to use the list iterator
>>> variable after the loop body.
>>>
>>> To *never* use the list iterator variable after the loop it was
>>> concluded to use a separate iterator variable instead of a
>>> found boolean [1].
>>
>> Not a huge fan of doing a helper for this single use, but I guess it
>> does make the main function easier to code. So I guess that's fine. But
>> can you move the call down where the result is checked?
>>
>> qe = blk_lookup_qe_pair(head, q);
>> if (!qe)
>> 	return;
>>
>> I prefer no distance between call and check, makes it easier to read. I
>> can make the edit locally and note it in the commit message so you don't
>> have to re-send it. Let me know, or just resend a v3.
> 
> I'm fine with you doing the change locally, thanks!

OK, I did that, it's in. Thanks!

-- 
Jens Axboe