Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH v2] block: use dedicated list iterator variable
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <a7b2fe8d-9967-2046-67a5-62d10e95a861@kernel.dk>
Date:   Thu, 31 Mar 2022 14:00:39 +0200
Cc:     linux-block <linux-block@vger.kernel.org>,
        linux-kernel@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Transfer-Encoding: 7bit
Message-Id: <E262CAA9-1B49-4035-9181-28C6FFDBE21F@gmail.com>
References: <20220331091218.641532-1-jakobkoschel@gmail.com>
 <a7b2fe8d-9967-2046-67a5-62d10e95a861@kernel.dk>
To:     Jens Axboe <axboe@kernel.dk>
Precedence: bulk


> On 31. Mar 2022, at 13:59, Jens Axboe <axboe@kernel.dk> wrote:
> 
> On 3/31/22 3:12 AM, Jakob Koschel wrote:
>> To move the list iterator variable into the list_for_each_entry_*()
>> macro in the future it should be avoided to use the list iterator
>> variable after the loop body.
>> 
>> To *never* use the list iterator variable after the loop it was
>> concluded to use a separate iterator variable instead of a
>> found boolean [1].
> 
> Not a huge fan of doing a helper for this single use, but I guess it
> does make the main function easier to code. So I guess that's fine. But
> can you move the call down where the result is checked?
> 
> qe = blk_lookup_qe_pair(head, q);
> if (!qe)
> 	return;
> 
> I prefer no distance between call and check, makes it easier to read. I
> can make the edit locally and note it in the commit message so you don't
> have to re-send it. Let me know, or just resend a v3.

I'm fine with you doing the change locally, thanks!

> 
> -- 
> Jens Axboe
> 

	Jakob