Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c2e7840-23c2-a0ff-abd8-ab216ad3480a@amd.com>
Date:   Thu, 31 Mar 2022 15:03:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 2/4] crypto: ccp: Export PSP security bits to userspace
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        John Allen <john.allen@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>
Cc:     open list <linux-kernel@vger.kernel.org>,
        "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER" 
        <linux-crypto@vger.kernel.org>,
        Kerneis Gabriel <Gabriel.Kerneis@ssi.gouv.fr>,
        Richard Hughes <hughsient@gmail.com>
References: <20220329164117.1449-1-mario.limonciello@amd.com>
 <20220329164117.1449-3-mario.limonciello@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20220329164117.1449-3-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1JKMEhWcWE4TENCMEl4OTBoV1hqOVhPMTNxVTN4aVhjcjQ2T2ozQjNoNnhD?=
 =?utf-8?B?bldwQmhLbmhmaDRlS2xwT1VIa1B5WHlKY2VWYUs1bVBDNDc1ckt1VHBrQ2FB?=
 =?utf-8?B?cjg4S2ZUMFUvOFpwV0Npa3MxQVcvRjdrcWliVzhGclRxUkoxaWJpNDljNVBB?=
 =?utf-8?B?RXdhVGUzOTl6b0lZc2wxNTlVd1FIOTIyRU4wT1VKQzVXMXJxWTBmVlRUU0hK?=
 =?utf-8?B?RFBSWDBBMUJWUHo2Q1Nyd1JFdFJGRUtGMnVvaWRBTXVLNUVOT0taZ0QrWG5E?=
 =?utf-8?B?ak5LU2JSOUgrZFFBSFlEUDB3Z284L1NocFViZWhhRW5qQnpsRmQ0Q2d6TjBy?=
 =?utf-8?B?M1pvTm44NVFTTUJWNnBHcTdRa20ra2hTMjZRQ3l0VU5iRWJyUi9yb2ZrK1ZG?=
 =?utf-8?B?SFlzbVYvMVQ3VWsvYlNna0U2M0xoMTB0QWRlSEVnS2pGR2NLc2hqTWd6N1lF?=
 =?utf-8?B?YXhPQjBHRjYzMjZLMjJOMldSU3ZhNjduRDVCUHFjeDV3ZjlSYjNPZ1dhY2dj?=
 =?utf-8?B?ejBjazdVWHVqNWYvOWJsWVRsNWI3M3JLaEkyQllhWkRZNFI4R0M4czlVdDNL?=
 =?utf-8?B?Q05xb1NrZm81NWxraVlhNGNUOXFVTVMvL0FZQTRsVEZPL3orWFZ1aXNzWlIx?=
 =?utf-8?B?c1R5c0t1Y1MwdHl6dHhxcVVCdjRybjB0TEQyYTNRamVDRTVJZUNBbzJLdS90?=
 =?utf-8?B?cS9KU2todGNoa3lwdVVBNzFOb1NMZWs4K0ZEKzA3bXNYaFN2TGdzWVZuUk5z?=
 =?utf-8?B?ZVhya25mWVFOY2g1cDZJbXZmZVpkaG9zaEdxQW4zVDhwL2psdld3aWpaQ1A2?=
 =?utf-8?B?Y2N3S1pVS2lXSTBqWVZWajdoOW5PM3RyRHRqQTd6K0RVbStiK0tMYTNRYjRy?=
 =?utf-8?B?QjgvYjh2NzNhb3RqWExqaEZpeFBTQzE3OUJKZVBQRzhNeVg0Sis3dmRYdHJZ?=
 =?utf-8?B?dGtiZ0VFaWZDcGdIZjZpdWNWN1ZudWZvZXgvNzFYUUJ3SmNOdng2MVArelFH?=
 =?utf-8?B?T1JCTWxrdkl3QmM2WnZHYTE4V0hXMkx4RnFpbktkMTRZUkhQOWh3S1ZYcGNF?=
 =?utf-8?B?Nm00Ynd5OEZCR28rOXdmZjBjZ0pIcTh1bzVNVGdnWlJ5UWZYbmZQS1NzNXNZ?=
 =?utf-8?B?N3QyUE1qT3NUYmFjeEZaWmFEbHpLTkpJQkRQQWJSTSs0bG1hZWJzaTMzWm8y?=
 =?utf-8?B?dnA3TkhZaEhtaERKN1l5ekFvdTFDdkFSUTZzaENOUVlORGJJSFBKZTFGdGFG?=
 =?utf-8?B?SzgyYzN0Q0NSMVlXNCtzSXZLUXpjaHhhRjMxLzM2bzA4Z2RIZ24wd3loeXFX?=
 =?utf-8?B?dmdsczl0SDFKR2R5bGc4OVh2UVNjMXBMNEdzNHkrWmxnSUsxUUpLVEZScVhz?=
 =?utf-8?B?cE9qZ0ZsYVljOTl4MWI0elh4OUNRTXRIQnI3eklmeHBsM28yclhJTkhnMkUz?=
 =?utf-8?B?a2VFcGpQUEJhMm95djJaMFFVdHUvdXE1bW9zbmFTb3pqVUd4UVRFSStaVjIx?=
 =?utf-8?B?S2U4VTdRejBVblA2RnkrcE9wMEtxcEo0MUtQTjErTTVJYkpSby91VlEwR3F5?=
 =?utf-8?B?dGRJVnZzM1YrVTVNVTVoOWZ3aTNmSkRGaGdzMnhpcjhML3lRQzZRZE45TVg5?=
 =?utf-8?B?aHZaUkpvTGFJTDhWcmJCcFlEZGdOaU0xbmIrNERTWHJQUEpjQVRnc3ROOGxP?=
 =?utf-8?B?S1BMb2VZY2pEUHhqSTJ6eGVxZ0Q5S0hBVEw3d25XWGJ6eUZwRGQ3b1lGVmo5?=
 =?utf-8?B?QytnTnVCNnRKVnpWTEFMRjZESDcvd0diVzZYSW04a3VTQlJydVVpdW5QbmNm?=
 =?utf-8?B?dWRCdVFPVS9CSkMwZGxBTktRZHhDTmFSYm1EZDVjandaaGhBOUFuUWZFaWE5?=
 =?utf-8?B?MEZFSjJvNS9PTGV6cWZ0cXc3YWVtT2Y5NjBIQVMvNFpnQXI5Rm95KzJuOVho?=
 =?utf-8?B?alltU04xUEdYcElRazVUeHpYVnZ4NkdFUXNwclBLSlEzZUFEK2ppSnBhRk41?=
 =?utf-8?B?bHRhK1Vrand5VUtCYXNnL1ZJMUs2U0Jlcy92bmpFeUtBZG5Qd25TQ2xkV1VV?=
 =?utf-8?B?MU1Sa0YwS0tRRm9zQ2x3a2NEdGZidUxmd2tWQmNJWmNRT2hRaE1GMC8ya3JY?=
 =?utf-8?B?Q1JBWkV0UzdJRjFNcEZLVVJHaWtGdWVVOWdTdDFxSWh5dGd6Q1l0VDJKZFJJ?=
 =?utf-8?B?NmxuWm1VVWFNdC95dkxYR1BCN0JIUno1dWxHTjFLMTFhQTN4UmszUndEZW9r?=
 =?utf-8?B?Q2hrRkx2MmpDS0ZOQkhEaVdiaEMyMDhDeTdoUnA1WGROdU0xcnhReEhNNzFo?=
 =?utf-8?B?SnNOKzA0RVdQOW1pZFNjQVV0ZFFyZitHR1Bod2gxSTQrNklQTFAyZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9faa891-3de6-466b-ead1-08da13518b48
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 20:03:37.7530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qJOfYiYBxNRCBlqtA4a5x84NTd2ASnGaTTTDVl7lhkfez3tc4ets+IU0buRhN2Lx75ER+F2D5dBLVY+zhrDsIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4633
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/29/22 11:41, Mario Limonciello wrote:
> The PSP sets several pre-defined bits in the capabilities
> register to indicate that security attributes of the platform.
> 
> Export these attributes into userspace for administrators to
> confirm platform is properly locked down.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   Documentation/ABI/testing/sysfs-driver-ccp | 87 ++++++++++++++++++++++
>   drivers/crypto/ccp/psp-dev.h               | 17 +++++
>   drivers/crypto/ccp/sp-pci.c                | 62 +++++++++++++++
>   3 files changed, 166 insertions(+)
>   create mode 100644 Documentation/ABI/testing/sysfs-driver-ccp
>