Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1028024pxb; Fri, 1 Apr 2022 02:35:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9GW/H/zbP7CwbcwsaH+S/BORBAV2J926v5sE+BirJ4Nn3F1Gct/PY1BpuUw2SRb2VwsYe X-Received: by 2002:a05:6402:3591:b0:419:26ea:1e22 with SMTP id y17-20020a056402359100b0041926ea1e22mr20342951edc.27.1648805752041; Fri, 01 Apr 2022 02:35:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648805752; cv=none; d=google.com; s=arc-20160816; b=DIDKgLniwgxNIslBj2Lxzr7hDkY7qJhn4ghiu3FRJhSIqN3W1ul6u0g2Z1+zJD80ZV urfTFBmU3SAxdprzUWBasNEgUOuyID63oUJYvf7/yJrYUumY9JwIuEZWX5JLQ6qkrY9U BL4qq4uaUG4p7ua5OAmjwdjAZ15uz110EstdnLYZtkr1EV2scoNHHrzIQvRlCZ1cpvTI U8pIG2crnE6E1YMIOtQRujlHfJKYYb/erxmdTLKC54fiHjxIHQEYIKgkqdjsPBa8JUBa D1+Kw9ECJOqqDV2KXWFFjUpMkHtxqaR27pHhIGJYtHtOBt+/N6hRpDQ5PKNMxj2UBNC6 oIdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/BG4PjpjkTfl+w+qa5DSqpEkBlgcagV0srBSYh6bu2Y=; b=YfX9btkP3bLhL5nryWHzuOlG92I4XxARZ/2O/8a3/f61wT2dRLMpi5YfKty7Wsn6HE e4iw5wCzdDf/4DguqJspREUxWvX8TjN0u9UTewqyVhkj4GWwdUC1UzefkMt18bOgPx94 L4RDo30oZFK1SQj36MVlkpJY/uwoUdW4xWXxf0Vlj2g14LeNasUvn5Zx+ZDmW5GsPOQJ rwiULP8xsKJA/bOo1TnlItWuwhWgaxMbe+WMBdkAS2VmP2l+jLpMcEEqexj4vxnzwaQi HKi9/61fP4Ap46NaEzuEnlwAxvzddqm5TvEWUL2/mC/ZJCqsyhyCtiYw4RhIu9WzK7fL W05w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=YJk+lJV8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o12-20020a170906774c00b006df76385da3si1245210ejn.579.2022.04.01.02.35.26; Fri, 01 Apr 2022 02:35:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=YJk+lJV8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244108AbiDACev (ORCPT + 99 others); Thu, 31 Mar 2022 22:34:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240300AbiDACeu (ORCPT ); Thu, 31 Mar 2022 22:34:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63371255AB3 for ; Thu, 31 Mar 2022 19:33:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 23382B82206 for ; Fri, 1 Apr 2022 02:33:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4E2EC340ED; Fri, 1 Apr 2022 02:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1648780378; bh=n0qM4nf5Ta5C6oUtQqbjtn+9oGwp1yQktL1/ylHeBYY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YJk+lJV8JQGFKgNBkVIy4o07iMRsdKIy9ttLfY+D6ICy/YEw48tMZ7C7Z0pQV/C/0 8nqNRv+nbehyb7BwUK2QGdvMBJyOESDwL53sOQcu9U53TMd5rwiuRq8x/foOHH4DTB Q852v2UhQHMlUfeGBunJmzRccXQMm6EWEBefi6ls= Date: Thu, 31 Mar 2022 19:32:57 -0700 From: Andrew Morton To: Rolf Eike Beer Cc: Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: mm: use mmap_assert_write_locked() instead of open coding it Message-Id: <20220331193257.c6e52c65346cbc21ba5a7bf5@linux-foundation.org> In-Reply-To: <10178697.CBVEcFiDRS@mobilepool36.emlix.com> References: <5827758.TJ1SttVevJ@mobilepool36.emlix.com> <10178697.CBVEcFiDRS@mobilepool36.emlix.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Mar 2022 08:45:37 +0200 Rolf Eike Beer wrote: > You are right, it was in tools/include/linux/kernel.h and I didn't spot the > prefix. Andrew, maybe you could just delete the sentence when you add the > Reviewed-by? Did that. I used simply "In case the lock is actually not held at this point."