From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: Problem with freezable workqueues
Date: Wed, 28 Feb 2007 20:43:23 +0100
User-Agent: KMail/1.9.5
Cc: vatsa@in.ibm.com, Pavel Machek <pavel@ucw.cz>,
       Gautham R Shenoy <ego@in.ibm.com>,
       Johannes Berg <johannes@sipsolutions.net>,
       LKML <linux-kernel@vger.kernel.org>
References: <200702272251.28844.rjw@sisk.pl> <200702282017.39752.rjw@sisk.pl> <20070228193234.GA86@tv-sign.ru>
In-Reply-To: <20070228193234.GA86@tv-sign.ru>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200702282043.24779.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1092
Lines: 29

On Wednesday, 28 February 2007 20:32, Oleg Nesterov wrote:
> On 02/28, Rafael J. Wysocki wrote:
> >
> > > --- workqueue.c.org	2007-02-28 18:32:48.000000000 +0530
> > > +++ workqueue.c	2007-02-28 18:44:23.000000000 +0530
> > > @@ -718,6 +718,8 @@ static void cleanup_workqueue_thread(str
> > >  		insert_wq_barrier(cwq, &barr, 1);
> > >  		cwq->should_stop = 1;
> > >  		alive = 1;
> > > +		if (frozen(cwq->thread))
> > > +			thaw(cwq->thread);
> > >  	}
> > >  	spin_unlock_irq(&cwq->lock);
> >
> > Unfortunately, the above code is mm-only.  Is the analogous fix for 2.6.21-rc2
> > viable?
> 
> I am sorry, I lost track of this problem. As for 2.6.21, create_freezeable_workqueue
> doesn't work and conflict with suspend. Why can't we remove it from XFS as you
> suggested before?

Yes, we can (preparing a patch).  I was just curious. :-)

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/