Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     josef@toxicpanda.com, Zhang Wensheng <zhangwensheng5@huawei.com>
Cc:     linux-block@vger.kernel.org, nbd@other.debian.org,
        linux-kernel@vger.kernel.org, yukuai3@huawei.com
In-Reply-To: <20220310093224.4002895-1-zhangwensheng5@huawei.com>
References: <20220310093224.4002895-1-zhangwensheng5@huawei.com>
Subject: Re: [PATCH -next] nbd: fix possible overflow on 'first_minor' in nbd_dev_add()
Message-Id: <164873704446.46490.778795283218997371.b4-ty@kernel.dk>
Date:   Thu, 31 Mar 2022 08:30:44 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 10 Mar 2022 17:32:24 +0800, Zhang Wensheng wrote:
> When 'index' is a big numbers, it may become negative which forced
> to 'int'. then 'index << part_shift' might overflow to a positive
> value that is not greater than '0xfffff', then sysfs might complains
> about duplicate creation. Because of this, move the 'index' judgment
> to the front will fix it and be better.
> 
> 
> [...]

Applied, thanks!

[1/1] nbd: fix possible overflow on 'first_minor' in nbd_dev_add()
      commit: 6d35d04a9e18990040e87d2bbf72689252669d54

Best regards,
-- 
Jens Axboe