Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d1586b34-1ed3-99fe-ce03-90aa54e88eae@amd.com>
Date:   Thu, 31 Mar 2022 15:10:29 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 3/4] crypto: ccp: Allow PSP driver to load without
 SEV/TEE support
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        John Allen <john.allen@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>
Cc:     open list <linux-kernel@vger.kernel.org>,
        "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER" 
        <linux-crypto@vger.kernel.org>,
        Kerneis Gabriel <Gabriel.Kerneis@ssi.gouv.fr>,
        Richard Hughes <hughsient@gmail.com>
References: <20220329164117.1449-1-mario.limonciello@amd.com>
 <20220329164117.1449-4-mario.limonciello@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20220329164117.1449-4-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0NGWEVkemxjTHpYaHRKVjBKak9oMS9lblVINE1hT1MyTGpqY1ZSMlc0S2hS?=
 =?utf-8?B?U1lBK1JvTVo3UzZtNGN3ak1XamZ0QXZ0Smp2TmlyM3IxV05GUkc1NEsvNmlU?=
 =?utf-8?B?VDF0c2lXYTFPZTJNRjlSOURMVWVLQWxRbUF3TjhJQTlCMGRJbHhvTk5oT0Za?=
 =?utf-8?B?dW16dE95WFdnUjc5OE9iT3NhK3FSalY3WXR6OXNmTk1yblFtakR0cnNUQ3BL?=
 =?utf-8?B?SzdrVTFMK2liQlJ1SCtkb3FrVHFWMGpBWW5uSFpTRG9CNDdiMmtUREdMQWw5?=
 =?utf-8?B?SDRCN2xSTGdyR0RzY3FqaVBmT1FMcnZmSWlIcnFFQ1JFbW9jdVIrK2VoRklY?=
 =?utf-8?B?OFF5MVM0SEZ6dW5ZREVTa1AxZU8rRjJoRTBUMERZMlJpUHhuVzd5blRXTUth?=
 =?utf-8?B?a0RuVTFiY2lqWUt4Mks5RVNocjF0Qk1YWk5UbDdka0FyTW1Ba2dMQXozT1Bn?=
 =?utf-8?B?MENJZ2kwRzltMGw0NFh1c1RGQWZ0azZmR3UrWllqNk0zVGZ6RWlMelcxUUlo?=
 =?utf-8?B?QUNFZFpGc1dQdE5aTkx4SXlicFZlQlUyL0pvKzJ3elNEU3AvYXNwV2RyL1VN?=
 =?utf-8?B?NmJTaXE2L0JtMllRYzVVaFJvZHBuSkVqQVY1N1kya1JZSlpQNmM2OVNyQXBx?=
 =?utf-8?B?WGNpdFpCU2prT1RmeU1rZjY0TFdoaVpkSHczMEhvQm1INW5tRk5Ld1Jwd052?=
 =?utf-8?B?ZU9mekVSSnBLZm1JZ1BOTXVyYXY3OVNLb05jMVVNc3dzM1pVd3ZQOGFVNlIz?=
 =?utf-8?B?YUNBTkdzSTdnRHBRTmVlZUtDMWtuZ2htTGtKY0Nkd2tHMVdSVWxWWGRSUzdN?=
 =?utf-8?B?ZFphSmJpN1hIcUEwVjJoWmdPQzVObU1HOWpoRTNpN3NSanNRRWlzYXJIVVB2?=
 =?utf-8?B?VEUzNExBNDBoVi9tcnl6SXRQeXpKZDNCTkFxbUUyajJ3RWE4TzAwZEdjSW5o?=
 =?utf-8?B?LzRYdjY2ZUxoLy9YNUhPMVEzMWpjVzlMVlYzVjRCQmNZeHF4dlZVWm5kN0Z0?=
 =?utf-8?B?dksyNllIQzRGd3N3ZGE3a05mMHdDQ29HZGxDeXUvSXJLU2JpL1Bud2pCSnh3?=
 =?utf-8?B?bnBlU2JKamdiWUk4RVdPNit3UWkvdkJrVVhNQTR3eDBzR3BXVHJNVEM4Uk9P?=
 =?utf-8?B?d21BSTZFT2M5YU5rdWpyZVZ0UFBLbXNYQjc4U1VzenpEam1RN1k1QUR2NEZu?=
 =?utf-8?B?MmdXNGlXeUpCRXBvVElQNmoyT0U3WkZ0MWZyUkhtbGszeHAyR1pDa3FWWDZ2?=
 =?utf-8?B?V0dldVI5RUdnUkVHVDUvbVVvTEtKbDFKaG9zRUoxUjF1c2FPcWhHQkdLZVBY?=
 =?utf-8?B?QWlGZmdTVUl3Q0ZaY2ZjV1ZtdWUyYWRHVGN2NDJTOXRkRVhxK1pkcVhLNHZW?=
 =?utf-8?B?akVVZzBIQzhSNitUZVc0ZURxYTVSOFVqSTBDQlBlbUhRYnZERkhPYnh1VnQx?=
 =?utf-8?B?WWlNRDF1am5YbmVnREF4bC9MeEVBRmcyQmpMRVdmZDVrQmQ0VTVFL3ZpY1RL?=
 =?utf-8?B?N1NXZys0Mnl0UlVOcmZnWGNGQlRnUmdsdW9GOTlPc0N3cTlHcEdiQld1UXUz?=
 =?utf-8?B?TkI4VElTamg2RDRkS2FIT1F1Vmo3dUdXWHBoRkFQRFFpTEFQVnBiWWp6QXdU?=
 =?utf-8?B?TTFkNGJwKzNyek5pWVlXcmZ2bDBDckpGUUVaTVpSeXQ5MnRhbXRqeU1YdEVP?=
 =?utf-8?B?VitTWnJuOEZtUzd0dWx3Z3lhSDIrMzMvVE9OTXpmTlZNM1RZNGpKN0tjWGM5?=
 =?utf-8?B?RlNPaEhTdXRhRE44ZkdVSHRBRU5CT0RZMUZSNXlOQmIxL21makZoTjZxSEZC?=
 =?utf-8?B?UEs0RW9VQ3pWYjhvYkRKY1RDa1VhRjh6VEZWeE41YklhdzBvZGs4TlBYbDgv?=
 =?utf-8?B?dW0reWkwcC9oRkp6RTJMcTYvekZIaVpBZ2NLVVNic3pZSFNmb1NVTUU5dTdk?=
 =?utf-8?B?Q0l0dEoycVlwU3BoaFcwdkoxZFRJa0hSWVNtbmJGWnppdFNzNFhhQmpDTHkz?=
 =?utf-8?B?ZFJrS2lCcVM4RjY1bU5kem83VWNUTENhejhUaEJiajhwM0x4SnRiZ3RDbitV?=
 =?utf-8?B?NlFad3BTNFFJbWo2eTNUcTNCWGZIRW5uUWlmcW52NTA4eUtjUnpaUXZPOEVr?=
 =?utf-8?B?VDZ2NytGQWhHV3B1OXpaMC9rUkpRWkVuNGJiZkRmdVRnNm1KbW5HUUU2cnMy?=
 =?utf-8?B?eFVaRUtzSUJxTWliV1pFY0hVaTFQREJjZ2JDR1RUdUpyakIrWXB0ZFBFN1Jr?=
 =?utf-8?B?S0JORVZsaTdBK2FUdDRZeEgxWFQ4V2NZUFF2YStwR3R2Z2thNDVSQlNMTS9H?=
 =?utf-8?B?dGljN2lyaitiamN3VzRvaWduRmFMNERudTJaNllzN0hNRzVIK0FRdz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bbc08775-8888-4146-64e3-08da13528271
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 20:10:32.5561
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kiNIgTrElJjyKML48dPZI9Tl6uT6anzSJZ6dOmzAWg6zdNMGy93fMLpMDOo3soMMon5PWtiSdPge30MJ6ibCXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3792
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/29/22 11:41, Mario Limonciello wrote:
> Previously the PSP probe routine would fail if both SEV and TEE were
> missing.  This is possibly the case for some client parts.
> 
> As capabilities can now be accessed from userspace, it may still be
> useful to have the PSP driver finish loading so that those capabilities
> can be read.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v1->v2:
>   * Whitespace fixes
> ---
>   drivers/crypto/ccp/psp-dev.c | 2 +-
>   drivers/crypto/ccp/sp-dev.c  | 6 ++++++
>   2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
> index 8cd404121cd5..3f47b2d81e3c 100644
> --- a/drivers/crypto/ccp/psp-dev.c
> +++ b/drivers/crypto/ccp/psp-dev.c
> @@ -158,7 +158,7 @@ int psp_dev_init(struct sp_device *sp)
>   
>   	ret = psp_check_support(psp);
>   	if (ret)
> -		goto e_disable;
> +		return 0;
>   
>   	/* Disable and clear interrupts until ready */
>   	iowrite32(0, psp->io_regs + psp->vdata->inten_reg);
> diff --git a/drivers/crypto/ccp/sp-dev.c b/drivers/crypto/ccp/sp-dev.c
> index 7eb3e4668286..3486ab2a8982 100644
> --- a/drivers/crypto/ccp/sp-dev.c
> +++ b/drivers/crypto/ccp/sp-dev.c
> @@ -132,6 +132,9 @@ int sp_request_psp_irq(struct sp_device *sp, irq_handler_t handler,
>   
>   void sp_free_ccp_irq(struct sp_device *sp, void *data)
>   {
> +	if (!sp->irq_registered)
> +		return;
> +

I just noticed that irq_registered is only set when a single interrupt 
ends up being used. When both the CCP and PSP get their own interrupts 
(the common case), this will result in free_irq() not being called.

So this needs to be fixed. I would think just allowing the IRQs to be 
requested and freed whenever the driver is loaded (regardless of whether 
they would be used) might be the best way forward.

Thanks,
Tom

>   	if ((sp->psp_irq == sp->ccp_irq) && sp->dev_vdata->psp_vdata) {
>   		/* Using common routine to manage all interrupts */
>   		if (!sp->psp_irq_handler) {
> @@ -151,6 +154,9 @@ void sp_free_ccp_irq(struct sp_device *sp, void *data)
>   
>   void sp_free_psp_irq(struct sp_device *sp, void *data)
>   {
> +	if (!sp->irq_registered)
> +		return;
> +
>   	if ((sp->psp_irq == sp->ccp_irq) && sp->dev_vdata->ccp_vdata) {
>   		/* Using common routine to manage all interrupts */
>   		if (!sp->ccp_irq_handler) {