Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f38e4782-1959-d1f3-e8d7-f60e199514e3@amd.com>
Date:   Thu, 31 Mar 2022 10:44:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/1] drm/amdkfd: Create file descriptor after client is
 added to smi_clients list
Content-Language: en-US
To:     Lee Jones <lee.jones@linaro.org>
Cc:     linux-kernel@vger.kernel.org,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org
References: <20220331122117.1538913-1-lee.jones@linaro.org>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20220331122117.1538913-1-lee.jones@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUsrU0w0QzlNMnpSdDF5NC9WTWZMaUJhVzBvUDFWbjQ4QXJxbHNVTlBUZ1p5?=
 =?utf-8?B?cVo5NWV5RHNVR3JLVFN6c2NiTHZCUnlsb1hCNVVmUlRVMGFhL3BQYmljS0xR?=
 =?utf-8?B?VHJ3WkhOdGhYbFNkbjR4YUltR2tBdFlZbWVhY2lweFdMVEJvWllOWUx2RnY4?=
 =?utf-8?B?c3VieUM2ZWRvOE5JZ1NGZFhvUTIzMjhLVm1Ld0xuTTIzQmwwTmFROW1VcEJO?=
 =?utf-8?B?VE9sUEM2UUtzNitScVJhNmh1eU9ieGI4eTJqbE1ha1pqNnJydy8wOTQvMi9k?=
 =?utf-8?B?dTRBc01FMi9kb2FGakd3eGw4YlFzb3cyNTFPajkyNG1ENHhLSzdObHN1U3d0?=
 =?utf-8?B?OHd1RURDcU1BTnpweGpHNmpHWEFBOStIQ3lPZkxqVGljNlB4SkF5U0NKYmJQ?=
 =?utf-8?B?Y3F2UEVrcVZPeFVLTE5NdS9rcTVLQzBhSnFWVlE3QkFwWDFKdTYybStVeEhx?=
 =?utf-8?B?NVE3aDE4Qmk0KzFtQUV3a0JzYjV5OTVsZ0xjdkNna2RiUDMzU1lDanpWYTZG?=
 =?utf-8?B?RzBXVzNIMFVsZ00zdStnak1idjBzTEg2T2FpNHlVRWxPZzcwSmJoQ1V6amdo?=
 =?utf-8?B?TmJYcDFsZkN0L1Zab2dvTjRhWmozU0ZybktqaDVKTlc3QWVkMXRvZVNqY0N2?=
 =?utf-8?B?QWlSRXdWSTBQSk9IWXgzTXphNFU3cExZSG1YcmtvdzNuQUtpaktlYitQdjhP?=
 =?utf-8?B?dEU3OHJHeEEwTVo4RC8zQSs2ZzlaaEhxNldENTEwVWdXZ29KVTdHLzk4NzRu?=
 =?utf-8?B?SlhQVHV1SGJlUHJTaFlBbnVHb1MrbUZRenRibGxRV1dNblJ1WEt2SmZHWkZ1?=
 =?utf-8?B?REYveDN0NGRCQjl5M2hzL1BMYW41NDJGVjVpOU52UUZkZ05KbHA5bE9GUE44?=
 =?utf-8?B?djBvWGpWNHBDUHdQQ3hCOThQdFBMeVlJR0wxTGdlcm1kem9ueGFZWElmUE85?=
 =?utf-8?B?ekR6dFFZTUJ3Qy85VnZKRTZPOS9BQjM3Qld2OVJIb0RnK3hJa2hNcGtqVVhQ?=
 =?utf-8?B?Wit3VVB1TFRLYm9qakVGWnhSclBoUHI2YmhpcnpTNTJXZVlZeThmUmlPanZU?=
 =?utf-8?B?T1ByOEI1SW5kODJBNldEN1pXdU4vbVFyR1NHaktZeU1CbWFBSGFrREo3U1BW?=
 =?utf-8?B?OTNwemJVZ2NwakxsQVgrVXB3WXdlU0g3ZEgrZml6aVpVQXFnU0YzQjlVamM3?=
 =?utf-8?B?WFlqYlJjNWRwYkNlZmhxSE9sSTF2aW9aaUZ3eUlTODUvR1Y2OXd6MnJTWEI3?=
 =?utf-8?B?OVpkSHl5aEowMjZTb1VtNmM3TUdZNnp4R3BYVkpTUWlUZGxDUk5NY2x4OXNS?=
 =?utf-8?B?a0pCVGM0T0h6M1lObmQ5b0VHRE04YVE4Vm5iS3RuajA2dG5RL3hmenVzWUZZ?=
 =?utf-8?B?ZFBBTWJMY1FQdVplc2UwcFRQajBoRnI4dVdMQVZ0RmxySkZqL1kwMU1Ed2hj?=
 =?utf-8?B?LzdaUWVzbmFoSlRZRXZ1bXU5cGVNbFNWSW1Jd2RPb2thbzNzbmU3Y3NGeGlx?=
 =?utf-8?B?OFlUaVgvK1RwVmRCR1g4WHBnUXdyZkhiaU55LzU2eThpVCtCZnBrcTVhR2dF?=
 =?utf-8?B?Z3ZSeUNYKyt6Yy9zTWtiZkNudjlaSmRRYVAxSmN0VlVZM3RGeXIzNGpBZ21m?=
 =?utf-8?B?b1BYVVFOdkxjdjkrME9qR0E3N2J1OHpKZnpnL2ltcHFjbllrUlY0NUg5ODJa?=
 =?utf-8?B?aGNPNEQ4TFBiRU9aeTVISGR3bk1DSURHelVIeE1yNGtvNWcyR3dFTzNIaFpN?=
 =?utf-8?B?YVdXbmd5bTdzYkV6SENXVXFMN0M1QmZGSlg4eVVCWXNhQUVLSTlSZG1YRjNU?=
 =?utf-8?B?ZUhjOE5XeEcxSTROTVQwWjMxYjJOWXNWVXA4K29VMnFwK25qdzVSdW5Mdmd4?=
 =?utf-8?B?a2N2VHNLQlFISVlyT3NBY2ZqbXA2dmZqNFhMQWRWc0xwZmdXMGhGc1pnaTdM?=
 =?utf-8?B?eWUveU9nNmVXb01HN25FRWNBRFc4MnVZQVo5WWZQZVkreGVOanUyc3ByU21C?=
 =?utf-8?B?OTEvRG5tVHlQWk5CQjJVdGo4Y1lrcnkrZGJaVlVoU0NwZWhnd3h2cmVFSzFs?=
 =?utf-8?B?VmJmUGpnMVBMZHhzRFdRWUVqOUpMajQ2UWg3VUFOUlpMQXFkbzJ5emFqTnEz?=
 =?utf-8?B?MFlGUFN6Q2NHRlBYZmtnQXhiN0crdWdHVXJKMDV0SldCM1dFTlJmUEorOVdH?=
 =?utf-8?B?aHYwQnNUWVdHU3VndnVXMVI1dDRNcThYS0JJV2dNa0hVRkJEUDgyWW1weWRu?=
 =?utf-8?B?bkg4MnhhZEZHTEMreHhnQVFibE5IaXN1c1BGWkIvL2N3UG1wMVViWVEybEE0?=
 =?utf-8?B?OEpIMmw3emdXNnRYZzBleTJ2UGFKNkZ2TVlraXVCMlJUcGo4Skdvdz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef748709-d63b-4fb1-8e97-08da1324fdc5
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 14:44:42.4616
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RpAn1LZ6k2jZHZVa4hnBppJDNPjZs/qqnQel3tIrZybUkZiI7UGAUDy3ZGa8O7YkK2hKmt56W42FzuSeskCFqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4881
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 2022-03-31 um 08:21 schrieb Lee Jones:
> This ensures userspace cannot prematurely clean-up the client before
> it is fully initialised which has been proven to cause issues in the
> past.
>
> Cc: Felix Kuehling <Felix.Kuehling@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>

I will apply to patch to amd-staging-drm-next.

> ---
>
> CAVEAT: This patch is completely untested
>          I can't seem to find a configuration strategy to compile test this
>          allyesconfig and allmodconfig do not appear sufficient

That's very strange. It should get compiled if CONFIG_HSA_AMD is 
enabled. I will at least compile-test it before I submit.

Regards,
   Felix


>
> v2: Also remove Client from RCU list in error path
>
>   drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 24 +++++++++++++--------
>   1 file changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> index e4beebb1c80a2..f2e1d506ba211 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> @@ -247,15 +247,6 @@ int kfd_smi_event_open(struct kfd_dev *dev, uint32_t *fd)
>   		return ret;
>   	}
>   
> -	ret = anon_inode_getfd(kfd_smi_name, &kfd_smi_ev_fops, (void *)client,
> -			       O_RDWR);
> -	if (ret < 0) {
> -		kfifo_free(&client->fifo);
> -		kfree(client);
> -		return ret;
> -	}
> -	*fd = ret;
> -
>   	init_waitqueue_head(&client->wait_queue);
>   	spin_lock_init(&client->lock);
>   	client->events = 0;
> @@ -265,5 +256,20 @@ int kfd_smi_event_open(struct kfd_dev *dev, uint32_t *fd)
>   	list_add_rcu(&client->list, &dev->smi_clients);
>   	spin_unlock(&dev->smi_lock);
>   
> +	ret = anon_inode_getfd(kfd_smi_name, &kfd_smi_ev_fops, (void *)client,
> +			       O_RDWR);
> +	if (ret < 0) {
> +		spin_lock(&dev->smi_lock);
> +		list_del_rcu(&client->list);
> +		spin_unlock(&dev->smi_lock);
> +
> +		synchronize_rcu();
> +
> +		kfifo_free(&client->fifo);
> +		kfree(client);
> +		return ret;
> +	}
> +	*fd = ret;
> +
>   	return 0;
>   }