Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c5a918fd-5700-267d-3159-6a034cce0a73@huawei.com>
Date:   Thu, 31 Mar 2022 18:15:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] ARM: module: Add all unwind tables when load module
Content-Language: en-US
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
CC:     <alexander.sverdlin@nokia.com>, <ardb@kernel.org>,
        <linus.walleij@linaro.org>, <nico@fluxnic.net>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20220325011252.55844-1-chenzhongjin@huawei.com>
 <YkVQXPYkae41B7Z2@shell.armlinux.org.uk>
From:   Chen Zhongjin <chenzhongjin@huawei.com>
In-Reply-To: <YkVQXPYkae41B7Z2@shell.armlinux.org.uk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Russell,

Thanks for comment! I've pushed v2 patch with your advises.

>>   
>> -	memset(maps, 0, sizeof(maps));
>> +	INIT_LIST_HEAD(&table_list->mod_list);
>> +	mod->arch.init_table = NULL;
>>   
>>   	for (s = sechdrs; s < sechdrs_end; s++) {
>> -		const char *secname = secstrs + s->sh_name;
>> +		const unsigned int sectype = s->sh_type;
> Please loose this local variable.

Also I moved "txtname" inside func params.

+		const char *txtname = strcmp(".ARM.exidx", secname) == 0 ?
+				".text" : secname + strlen(".ARM.exidx");
+		const Elf_Shdr *txt_sec = find_mod_section(hdr, sechdrs, txtname);

 >>>

+		const Elf_Shdr *txt_sec = find_mod_section(hdr, sechdrs,
+				strcmp(".ARM.exidx", secname) ?
+				secname + strlen(".ARM.exidx") : ".text");