Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sandipan Patra <spatra@nvidia.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Thierry Reding <treding@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "digetx@gmail.com" <digetx@gmail.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
        Bibek Basu <bbasu@nvidia.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] soc/tegra: pmc: update Tegra234 reset sources
Thread-Topic: [PATCH] soc/tegra: pmc: update Tegra234 reset sources
Thread-Index: AQHYRACcWXPz7MPbsUCQESpH3BXaoazXpZKAgAMzNDA=
Date:   Fri, 1 Apr 2022 10:12:09 +0000
Message-ID: <DM5PR12MB16288BDAC52414AA65CC647FADE09@DM5PR12MB1628.namprd12.prod.outlook.com>
References: <20220330063635.1689-1-spatra@nvidia.com>
 <YkQf13VH7RzrEcG/@smile.fi.intel.com>
In-Reply-To: <YkQf13VH7RzrEcG/@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R7UyUdqS+4GemEh84u0Tta6nhyRzVVb+qrbHxlZdtkSW1ts4aiUO5Q/g1W9g?=
 =?us-ascii?Q?9Tnkr/LSCSvZ7mpiSgQh1abAez/hoQzfeNdsy6uQi4eHsWrXsdzUkO4epINg?=
 =?us-ascii?Q?AwP34y1hkDoUYZxQI5/8C5F9HVQMZKDGzpFgpBKfhGoIOwJeSJWGI4XQJR58?=
 =?us-ascii?Q?ZAlxsr8VS7pZSpS2/l4Pp5Wvb3lOvjyqNDXhGaz34dVUtx2M/1/z2RKxem6r?=
 =?us-ascii?Q?QdvO8/mgEDmM7/Ynz0ogooaKxILmOFbBDug/2SH9nYK7M5184goOgxAPo+79?=
 =?us-ascii?Q?RxjEt7dMjfwGUIiGKhwZ+mBFHTR/cOm2NyXPv2B4cYX5Wl+4+1PghHZxBuVF?=
 =?us-ascii?Q?OnlVxTE6WMBgydw+dsmMknjN2W+wbAXA1mSAdTaiGBnS06CsTElEhETddxrb?=
 =?us-ascii?Q?toeyFScfq9MyHEQ5UfBNKAI6zvcjiFhoSQ38IhV/5kg2xt6sitV/ICi/u2jT?=
 =?us-ascii?Q?kNF7tJW/lIbqthzyLgiZNqaCmfpwjI3JIWqLQODzB98WmUidQLUi3XnTeig9?=
 =?us-ascii?Q?+R35P6+I1ywznXHQJJYnzxRjXoYnVlUaZs8gyO7bFL0XqQRBnMcJWmFS5N1u?=
 =?us-ascii?Q?Ne+RgXNytH1rkpsf73J3FQjozpgpqzBT+5e8uILyfiHzXLPiSXom2+cJJM46?=
 =?us-ascii?Q?g812GQSKc/moeZOg0yU33dwvcvGBOZxapke9v8NAxa8MK87jreq0HoxcELEq?=
 =?us-ascii?Q?1RZ+eaQDmi9feeDJqnLnOTkQ44YEQPBJYh/vRe9XZBsb6DLeyh8laqYHXkND?=
 =?us-ascii?Q?SoLooH0xZoKob27luCRHodvdGSAW0ufWO+qcjnXjh5l6yA2oyXrgE92oiV7s?=
 =?us-ascii?Q?BnfSCr5rVBQDELtvR2VdlwqFrqFld/O62YEyguMpGSDwL+PTo0b4gVy1BFUy?=
 =?us-ascii?Q?mGcomusy7TK0rQ1SfnIRjT/MVoUuWguGTCeJpCOdnKUAwLj1vGfbdcyQ7BEn?=
 =?us-ascii?Q?dK7iMnmQuQG6Zv3blZSmEEfZw/HHi6rv+Gy+J3sNHphT91bu6qZNe9R8dLUb?=
 =?us-ascii?Q?1aJd05M3wfzDyH/O32KQdlUm/2ZbhqbzOUvlbeV9ORhDhurpEjNvjJ+lykAD?=
 =?us-ascii?Q?a0E/Rwo288jSSdoAX6ie4kxaGDw5ZKeff48akgkKoQuS91qStNxQ6+9Gujn5?=
 =?us-ascii?Q?EmwhjfhpS32MGC5OiCk0qgv8ng4iA0D/grMDgjQpsJsKC6lA9o3r/wudwzzo?=
 =?us-ascii?Q?M77nV/ggZ7izwKEHtSqjR4yMhacxNBZk7v8dWYPlUiggwmJHZ6S+XKd55uVK?=
 =?us-ascii?Q?aN0y3/w/LwppB9W/8OUcZvCd/aYHIgmQDOeA6IjJEAfcw/PmB+mVhTrwM2jh?=
 =?us-ascii?Q?th2C96eAJXo6RRuGMxwDUwZqO1CFmERSYOXMZ7br474ebdie31CLQqJn3U9t?=
 =?us-ascii?Q?PmB8YPaUCjGpc91iCLdG8fcffc8FpUWPcCfFeHt+Vty/Kfjioa0+v6MHTmmw?=
 =?us-ascii?Q?U7/ajslrHoWIXFDjORJNxOM8LF3UdtN1CcttKtEe37yTUVrxLBFs9ex70tSM?=
 =?us-ascii?Q?t/p9fTEW9yx7oAMJQNdUIVnpdyz5hgrxV9Drtc/CwfIFAuJmQd0dcZm4DWHp?=
 =?us-ascii?Q?WuMYPS10pZqKYJjRtzXSO70p1VRyFRjkem1jHQJbC1OhCcCG9kLVA6RlnQMf?=
 =?us-ascii?Q?ipY5uGdw5nBdsCJGH4q3lMW7NujgGoEvq/xqLaZeK6uttwbpe/Dti1eCtroM?=
 =?us-ascii?Q?N39j3BzlX9BXp4kAFMDZVsiQvykg1IUgf4NWgcYjyWrKCUB5?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1628.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e686f6c-5923-467c-dfa9-08da13c8150a
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 10:12:09.2361
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uZIzCHGoJly4pjV/UnrGpmqlSjzJyMbPxyy176vp3K8oAuVpYyCZDfsPPFMhSYoK2fzBUg7tK/ng5/yoOENaeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2501
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Andy for reviewing the patch.


> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Wednesday, March 30, 2022 2:46 PM
> To: Sandipan Patra <spatra@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>; Jonathan Hunter
> <jonathanh@nvidia.com>; digetx@gmail.com; ulf.hansson@linaro.org;
> cai.huoqing@linux.dev; Bibek Basu <bbasu@nvidia.com>; linux-
> tegra@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] soc/tegra: pmc: update Tegra234 reset sources
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> On Wed, Mar 30, 2022 at 12:06:35PM +0530, Sandipan Patra wrote:
> > Reset_sources list is updated to add all reset sources and removing
> > ones that do not actually exist.
>=20
> ...
>=20
> > +     "SYS_RESET_N",  /*0*/
>=20
> Missed spaces in the comment here and everywhere else.
ACK
>=20
> Not sure about indices. If it's going to be a part of the hardware
> programming interface it may make sense to use hexadecimal rather than
> decimal.
Agree. That's a better suggestion for readability too, I will modify it to =
have hexadecimal in next patch.


Thanks & Regards,
Sandipan
>=20
> --
> With Best Regards,
> Andy Shevchenko
>=20