Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Mar 2022 18:51:30 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Kai Huang <kai.huang@intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jim Mattson <jmattson@google.com>, erdemaktas@google.com,
        Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
Subject: Re: [RFC PATCH v5 032/104] KVM: x86/mmu: introduce config for
 PRIVATE KVM MMU
Message-ID: <20220401015130.GE2084469@ls.amr.corp.intel.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <770235e7fed04229b81c334e2477374374cea901.1646422845.git.isaku.yamahata@intel.com>
 <55fa888b31bae80bf72cbdbdf6f27401ea4ccc5c.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <55fa888b31bae80bf72cbdbdf6f27401ea4ccc5c.camel@intel.com>
Precedence: bulk

On Fri, Apr 01, 2022 at 12:23:28AM +1300,
Kai Huang <kai.huang@intel.com> wrote:

> On Fri, 2022-03-04 at 11:48 -0800, isaku.yamahata@intel.com wrote:
> > From: Isaku Yamahata <isaku.yamahata@intel.com>
> > 
> > To Keep the case of non TDX intact, introduce a new config option for
> > private KVM MMU support.  At the moment, this is synonym for
> > CONFIG_INTEL_TDX_HOST && CONFIG_KVM_INTEL.  The new flag make it clear
> > that the config is only for x86 KVM MMU.
> > 
> > Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> > ---
> >  arch/x86/kvm/Kconfig | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > index 2b1548da00eb..2db590845927 100644
> > --- a/arch/x86/kvm/Kconfig
> > +++ b/arch/x86/kvm/Kconfig
> > @@ -136,4 +136,8 @@ config KVM_MMU_AUDIT
> >  config KVM_EXTERNAL_WRITE_TRACKING
> >  	bool
> >  
> > +config KVM_MMU_PRIVATE
> > +	def_bool y
> > +	depends on INTEL_TDX_HOST && KVM_INTEL
> > +
> >  endif # VIRTUALIZATION
> 
> I am really not sure why need this.  Roughly looking at MMU related patches this
> new config option is hardly used.  You have many code changes related to
> handling private/shared but they are not under this config option.

I don't want to use CONFIG_INTEL_TDX_HOST in KVM MMU code.  I think the change
to KVM MMU should be a sort of independent from TDX.  But it seems failed based
on your feedback.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>