Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <35ceefc3-3f8c-f3aa-e468-1f21161f920b@vivo.com>
Date:   Fri, 1 Apr 2022 10:04:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] rtla/osnoise: fix NULL but dereferenced coccicheck errors
Content-Language: en-US
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     kael_w@qq.com, Steven Rostedt <rostedt@goodmis.org>,
        linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220322113253.57390-1-wanjiabing@vivo.com>
 <2afd6cba-1a01-0c32-eae8-c4f9f7e76732@kernel.org>
From:   Jiabing Wan <wanjiabing@vivo.com>
Organization: vivo
In-Reply-To: <2afd6cba-1a01-0c32-eae8-c4f9f7e76732@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2lNUkd1aEQycG5RRGpMTnRxbURLWWthdFBKSGtTV0lHNnF2c3BadUJYVEpY?=
 =?utf-8?B?L2lLN3c5ZlRFYlRPUTg0QmFaU0FFRmpFRVlRclBUaEd0WlB6QUZKSmJBRVR0?=
 =?utf-8?B?dHdmdElJdk1oaHc3M3ZJdnlEaE04UTNuek9oNHl3STJhdFBMei9LVXJrQ1hx?=
 =?utf-8?B?K2NJSlBFcjJUdVJJZHhnLzZyQ2xDWEg3cjdDMlZGQ3V6NjhKUFBRWXo5SzhL?=
 =?utf-8?B?cW81bVAvcjh5UEFsR2xFVXRFNkZ6dFB1S0ZyYzdraXpRdXk5TStsTStCbnNS?=
 =?utf-8?B?TzNCQ01nOWtDbDk4VnlpWVhwVXkrTUtZWWJnN0FFZ2ExOERMZStNQTROb3NH?=
 =?utf-8?B?TWk4UGIyYVhoN0kwZmliWERRTFFPbGNpMmIwMFBzWUZaa3pjWEYyd2Y1YlMv?=
 =?utf-8?B?WmlYT0RtYnd6cUVXK0FBV0hkUklwckdDS2pIbmZtbU5tbkdqRnk0c3BKNXFm?=
 =?utf-8?B?RzcvV3hJdFVBdStiTUZrZzl4UzRhZ1VJVzAzQ2ZmRGhFT2wrWjR3U1FRMk5D?=
 =?utf-8?B?Vks3YTk5OHVGeUE0VnJRTVB6OGhWL2VkR29HV0ZEUlZTZGlFMGNxRzA5TGlF?=
 =?utf-8?B?Q3U1MFdvTWd1RHU1Vm82bzhBZVlPTUJaU3krK0YxaWs5YVRMSy83dXF3MDNO?=
 =?utf-8?B?WWdSTHpNTjNBMjcwVVJPc2RXdm0vS28zQ0diSkR1NlQyNEgzRDJDOTQ4YzJu?=
 =?utf-8?B?blMrT3libGVUTUc3RmptbUgxWXFXKzB1YUl5K1pXM0Y5Wk55WHBPVGFhZEw1?=
 =?utf-8?B?VXBoS1JjN3MyQUtRNmtsY1F2bklIMGdUVEt1dVBtc0puRXd5Yjk0RmF4SUVr?=
 =?utf-8?B?ZFlkZXp2cU1SNXRwM1hwNW4xVzZjNUJZckNnSjI5SitxOHRWcFR2ejJwTS81?=
 =?utf-8?B?VjBJaXZtY0VxVTlDTEhYVDlsejVuWWprc1dPWHZMRFVTSlp6NklweE12ZzMr?=
 =?utf-8?B?cmUwUG1lT0k4c1JSTXBMaHpVMUdTTHhmeWsvM2dyWDBBcmxpSUtBWTY0VjJG?=
 =?utf-8?B?WGVJMy9EbGFObFFBM0svdzRGMm92Tk11ektSVExSTTZ5SVZMa1VSMmJiTkNv?=
 =?utf-8?B?QWdaWWdmY2NBejBQYjhoYnl2eVFWZUp6NFptRk55M2pTN0NlSDBOVWJZZU8w?=
 =?utf-8?B?OENkbXNzcm1jMkZSZkx4YVY4ZFNDMlptZ1hnTUtLVzFZVEw4VGdLWmIxRkhp?=
 =?utf-8?B?WGZmZzFYQkxPZjN3akVoRklSWlE3aHlPaVR5RWk4bDF1OFR4OW9SYmhRckJy?=
 =?utf-8?B?aUYxaWplc3o2WWxkekhtK2daUTB5QTA3Um1ad1N3ME5ObzZKbFR1SWxCSnZX?=
 =?utf-8?B?TU9zK1NSalhzelZEMEU3bnQweXppQkFoS2htVlp3R2t4VHZ0WVA3UHU0K1JR?=
 =?utf-8?B?WFVaUXM2WGZGWHhQbnVZcElDL2hNOXlsek84ekFSdXVxR1V1b0MrbUJGUXhJ?=
 =?utf-8?B?NUtrNjJUSVRGQVJYN3RZaXFNRkl1STFCV1d0YXJudFdnMnA3L1V5VWJjcXdW?=
 =?utf-8?B?bWNjZUtGU25JcEFrMWFmTXNsR0FHOUQwUytqQUQvUmhjMVRQU0hDMklFeldv?=
 =?utf-8?B?Sk9QbzNnMnJUSW9QR1FWMnJSaHg0TEpjZEdtT0FZSXY3WVZHT1VpZi9NQ1lF?=
 =?utf-8?B?S1pxY0YwL2JSRTViSVFtQiszQU1nUk1iMWRodk4yWTlsNURoQmxCY1hQcGJR?=
 =?utf-8?B?TWllRkRnWHE5MUkvTUlWTVJad0JnVCs4THoxaElJMWYxSExKSkNjMFlSSWQy?=
 =?utf-8?B?L3ltOFpNSHBVZU8rQnNqWmZWV2NaWWJGY0hPZDFOWWxzV2Vrcy8yaGNBSjEz?=
 =?utf-8?B?VGpCWStIVklBLzdZTWQydk5nMHlOeWlNOUp0Q0pHbm04aWpRVFBGWEl0aFNI?=
 =?utf-8?B?eThhbmN6OTBhQ1NFOEFWMnhPZ2t4QUx5MWNlY3dkaSs5dUxOOEVlN3U5dVlM?=
 =?utf-8?B?VjV2ejR2dGZKd042YUdEY2UyM3haTDF0UzVzMVNlTkFZTTkvUGRWRU4rcFZI?=
 =?utf-8?B?aW55aDhJaTYzMlZlNmtzQUR3VmM0SW9tQ0llWWJRZmlvdHozR3B3YTFlMmNS?=
 =?utf-8?B?U3hqM252ajhTdnRUY2tyV2RuOG9LZFZFeXlaY1EzYzFiOWhjU1p2anFVQUpK?=
 =?utf-8?B?bDh3TWtwaHRuU3VyYW8yVk0zRnRMVFhPWHRpWlpnWW10RGdVRFZuWkR5bks5?=
 =?utf-8?B?N1ozSmlVaGQzVlBaMm51SGhxTUdLRkhwTFRsVE96eUh0UzR2T2xPbC8wMG12?=
 =?utf-8?B?Mm50ZzJwVUF3QTVXUko3RXZYYXYwMUNtc2g2S1dYcDQ1dGY4bDFLRllaamlT?=
 =?utf-8?B?VXZ3bk1hVlU5R2FaUU1KdUJlRStqMUtJV0pINWs3YjVyaFNNdmJRZz09?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d15f7a67-5fc4-47af-4aa7-08da1383ee66
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 02:04:19.0171
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ezpCEYflBcJkacABOiTqbJj7xo6c2EoaooXF0sr/jw4Asi01PbnQC+hyjsgWPNb/QoSwWDZFhH1KlhYOZPC9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB3889
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Daniel,

On 2022/3/31 20:25, Daniel Bristot de Oliveira wrote:
> Hi Wan
>
> On 3/22/22 12:32, Wan Jiabing wrote:
>> Fix the following coccicheck errors:
>> ./tools/tracing/rtla/src/osnoise_hist.c:870:31-36: ERROR: record is NULL but dereferenced.
>> ./tools/tracing/rtla/src/osnoise_top.c:650:31-36: ERROR: record is NULL but dereferenced.
>>
>> "record" is NULL before calling osnoise_init_trace_tool.
>> Add a tag "out_free" to avoid dereferring a NULL pointer.
> Yes, I see the problem.
>
> Please, change the Subject to something with better information about the
> problem, instead of the way you fund it.
OK, I'll fix it.

>> Fixes: 51d64c3a1819 ("rtla: Add -e/--event support")
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>>   tools/tracing/rtla/src/osnoise_hist.c | 5 +++--
>>   tools/tracing/rtla/src/osnoise_top.c  | 9 +++++----
>>   2 files changed, 8 insertions(+), 6 deletions(-)
> Please, also add the version of coccicheck you are using, because it seems that
> there is a problem with it. There is a similar problem with timerlat, added by
> the same patch, but it seems that coccicheck did not find it.
>
> Would you mind to check coccicheck, and also add the fix for timerlat?

Yes,  I used null/deref_null.cocci to report these warnings. But there 
were no warnings in
timerlat. So I check the null/deref_null.cocci and modify some rules.

Using modified null/deref_null.cocci, there are warnings as follow:

tools/tracing/rtla/src/timerlat_hist.c:905:31-36: ERROR: record is NULL 
but dereferenced.
tools/tracing/rtla/src/osnoise_top.c:650:31-36: ERROR: record is NULL 
but dereferenced.
tools/tracing/rtla/src/osnoise_hist.c:870:31-36: ERROR: record is NULL 
but dereferenced.
tools/tracing/rtla/src/timerlat_top.c:700:31-36: ERROR: record is NULL 
but dereferenced.

I'll resend the patch and fix them all.

Thanks,
Wan Jiabing
> Thanks.
> -- Daniel
>