Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Mar 2022 13:40:12 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     'Alaa Mohamed' <eng.alaamohamedsoliman.am@gmail.com>,
        "outreachy@lists.linux.dev" <outreachy@lists.linux.dev>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: gdm724x: Fix Duplication of Side Effects
Message-ID: <20220331104012.GM3293@kadam>
References: <20220331101849.71046-1-eng.alaamohamedsoliman.am@gmail.com>
 <ebbc4a14c30f492f8553e6ef572bbcbe@AcuMS.aculab.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ebbc4a14c30f492f8553e6ef572bbcbe@AcuMS.aculab.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FZxdK7BtJL6ix3nvROCQ3bCdBbvO8n5LGqE/d5ICk9M52tlmndDyE8NGlXPF?=
 =?us-ascii?Q?XZO3sK1bHDu920pfX8GppvJUh3xwY8nUjCBybL6DVBWfYqtbwhoIkP99SWH7?=
 =?us-ascii?Q?xKVot7Eh9Yz+CzKoWHmXnPjIroOHH6Nmocg+oAOiXMJ/g26NUnDqQUOAE8vn?=
 =?us-ascii?Q?KOq3GnzCeILfc3Ns5wxEdzNJnuH3V2TTJFH+K9BjAIJgvDg5Lh+DW10gI8zo?=
 =?us-ascii?Q?NtNneuh6/F1uloJSC86q6nvvlbpD76EHbTrioiHt4KRc6VCzP3nfbV1BF9hP?=
 =?us-ascii?Q?W5PZ/wTf1y/YXLXY0v0pruaPkATl5kvAhzonNdjuKbSQ89eqERMUY2+8rVEJ?=
 =?us-ascii?Q?3JZKbu1MD0T16E3pUh0ZHVhEufR1Nd5jOBh+bHM/o83xvVHQ95ZQWzIKfOc7?=
 =?us-ascii?Q?yGH4ac3//LAlMgmXsjbU5q502q+YQ86kqXAGDJwdfpiLRwxFjdJhfgv7fZyQ?=
 =?us-ascii?Q?pQvtLhJ+6p3rmtLAYqR4B/DS+U2+qibrcMPt2BDU6w1C0GtOjT45sJPPzioA?=
 =?us-ascii?Q?+XsuHccfvphPWAhq073GJEn5GSkTiHXBntVPXhbblJIHq9xxUpZfodEc57Yj?=
 =?us-ascii?Q?fM+27ngTgVlc+WeaoC+wJgLkc/DVgzHfMBFvWlu/X8mygsMRJKT8frtDTG9Z?=
 =?us-ascii?Q?r1KnEfHj9J0e1M3E2d4GHR4uJ7/RAAkZVbaPX2sDztVbDiGogtD3XpCUFVtu?=
 =?us-ascii?Q?jCnK7Ke7ANCk2B3iXsPdEwWjPgBIfq/HrNo9/E0v75JWa67r49mCQI9LduGW?=
 =?us-ascii?Q?y2Y/Q+QGvZ05WYEn9u1GfJ1k4LytZhd2ctWICIk5VL41yFNE8HTuuHS4i0CI?=
 =?us-ascii?Q?4rl1iAQDTN5Cosj0sucAta9ywDG9De16FkcWqbZPL2Zk9PwGOHKN2qQLHHcB?=
 =?us-ascii?Q?aGyPQPJwxfbY0K6bxdcNZfzqP9YrMvwpIStMSraubM1wHkcBSuzUT1v6CH2e?=
 =?us-ascii?Q?m47WHBwlsgpRqJC8OHz4qZ1guejKOYx0Is9/+CtDadwpF+GiALBFDnpbqKok?=
 =?us-ascii?Q?MRWo7YHFuezaq2RFnKpkz/sMA4MAsaD4HDrgK78q3X9JduLSiJYEVpYG3n97?=
 =?us-ascii?Q?RW7WrQJYCMce7OhHe0Oolzi1meYQTTkUPODEWQOilCaB07d7+c7Cpm8eXUEq?=
 =?us-ascii?Q?euOfmQzN+zQT7KMOpKLoq1pOqyl2if731+0JbQiZawQ3u54FOR4j8Y8nZorV?=
 =?us-ascii?Q?+WpJi/s5ZM9D4U1vjXr1j6Owb6VujHFUJqyFhWImYXbOPh3hYkLiB21M2uDn?=
 =?us-ascii?Q?OFyT0CxZDm25LZEUtPK4v3rgtr87MT2EOSiB4zsRbgLZkJVeH/4G6V9neOj+?=
 =?us-ascii?Q?QVXxRr+FNzpy9jSeRSzrRBjP26CH17/5H19mG15yXWkoPq9HIxgapEblnvuD?=
 =?us-ascii?Q?7PpturPe2nuFCt6IF8x7RPKxJu3etlwPfIX3QavzvuL/P0U2ghAWwgsyYhdH?=
 =?us-ascii?Q?qqSqZZYY7qRY5gdjxSCU95RVeZEluN2PtXlQ7JVTpiUj0lazISdq9xCzFCDP?=
 =?us-ascii?Q?ZEwr+X5Qpfam0uMtWk8nYjlS/g8lT5SONAqEKCc83kMOex88b8EEvbsZkXbF?=
 =?us-ascii?Q?qkZNf7gs5K98r1kNO1MynOxeqKUUkvUX+5ckOvUyKFoQwpHNHY+F2AGmgIXR?=
 =?us-ascii?Q?2CTHldPeBNpDCaDUkFBYNer8bNQUA1sSM9nkx4IBDsuR0PpBI34gZR5Sl2/e?=
 =?us-ascii?Q?1Nhyx3G0rms+hwbMwbDDzwJzJ/G4yUBXdCE+nmUv+T/z48iuv7P2dOgPIqh+?=
 =?us-ascii?Q?lMZH31pIscp0Cj7yfhwhRGyKxG+MXHs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b0bc071-eac4-4353-6b27-08da1302e134
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 10:40:32.0829
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HAMuDSnAsVqu51ze9Obzjq8PGkqUd6Vf1MxL276NPj1QJ+TTWCBj1wzeZ/6xMCGFwz3IR+NP3THRSx6XP+hkyAOqBYS9tOheegzpdFYhxj4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5042
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-03-31_03:2022-03-30,2022-03-31 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203310058
X-Proofpoint-ORIG-GUID: G8AXzcOZekZlHTJvks1SBSG1z7tuaeRe
X-Proofpoint-GUID: G8AXzcOZekZlHTJvks1SBSG1z7tuaeRe
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 31, 2022 at 10:29:04AM +0000, David Laight wrote:
> From: Alaa Mohamed
> > Sent: 31 March 2022 11:19
> > 
> > Fix Duplication of Side Effects for GDM_TTY_READY(gdm) macro
> > reported by checkpatch
> > "CHECK: Macro argument reuse 'gdm' - possible side-effects?"
> > 
> > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> > ---
> >  drivers/staging/gdm724x/gdm_tty.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > index 04df6f9f5403..6f0274470e69 100644
> > --- a/drivers/staging/gdm724x/gdm_tty.c
> > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > @@ -27,7 +27,9 @@
> > 
> >  #define MUX_TX_MAX_SIZE 2048
> > 
> > -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
> > +#define GDM_TTY_READY(_gdm) \
> > +	({ typeof(_gdm) (gdm) = (_gdm); \
> > +	(gdm && gdm->tty_dev && gdm->port.count); })
> 
> Did you test this?
> 
> see https://godbolt.org/z/cazPrrzPv
> 

I don't understand the link.  The patch should work as far as I can see.

regards,
dan carpenter