Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH] staging: android: ashmem: remove usage of list iterator
 after the loop body
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <YkaP6UWmSZjxO/oA@kroah.com>
Date:   Fri, 1 Apr 2022 08:50:10 +0200
Cc:     =?utf-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <brauner@kernel.org>,
        Hridya Valsaraju <hridya@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-staging@lists.linux.dev, Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7BBD57E4-287B-461B-BC5C-D2FF35865D39@gmail.com>
References: <20220331213934.866804-1-jakobkoschel@gmail.com>
 <YkaP6UWmSZjxO/oA@kroah.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Precedence: bulk


> On 1. Apr 2022, at 07:38, Greg Kroah-Hartman =
<gregkh@linuxfoundation.org> wrote:
>=20
> On Thu, Mar 31, 2022 at 11:39:34PM +0200, Jakob Koschel wrote:
>> In preparation to limit the scope of a list iterator to the list
>> traversal loop, use a dedicated pointer to point to the found element
>> [1].
>>=20
>> Before, the code implicitly used the head when no element was found
>> when using &pos->list. Since the new variable is only set if an
>> element was found, the head needs to be used explicitly if the
>> variable is NULL.
>>=20
>> Link: =
https://lore.kernel.org/all/CAHk-=3DwgRr_D8CB-D9Kg-c=3DEHreAsk5SqXPwr9Y7k9=
sA6cWXJ6w@mail.gmail.com/ [1]
>> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
>> ---
>> drivers/staging/android/ashmem.c | 21 ++++++++++++---------
>> 1 file changed, 12 insertions(+), 9 deletions(-)
>=20
> What tree did you make this against? This file is no longer in Linus's
> tree.

Looks like the driver was removed just a few hours after I rebased.
Feel free to just ignore this patch.

>=20
> thanks,
>=20
> greg k-h

Thanks,
Jakob