Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1226312pxb; Fri, 1 Apr 2022 07:54:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGhGZV7mb8cqqgPF5kbCQel3zD7KQ2gkNtupmjqdQg7cmYa1qAmnvRS5dTZoN4FKWpafXu X-Received: by 2002:a17:906:7f02:b0:6cf:86d8:c31c with SMTP id d2-20020a1709067f0200b006cf86d8c31cmr178389ejr.518.1648824862011; Fri, 01 Apr 2022 07:54:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648824862; cv=none; d=google.com; s=arc-20160816; b=P8zHqSg26kShJXjZVNP2RshsXW8HsX+kP4w+5GKOfVVwW3jKlZTAacrR4F0Fv9sxTr fmyFrTDSGooKSKLmSLSzBYAIeIky3OajrXGYJ+TjmS7fgTnmZzUKhoks1DrM+O3WSsvk taZUqcGgQV9J9jk8wuzjMS9q1S/mfRsTztRS1L05oTTBFONi8KzSyxZ7k/a6w350w0Am sRU00DjbBfbFw7kHacylQEGjeiOmLPBa2G8Eo01vldMZQpz96lw9Cja1K4Ay3BC287B3 +zAPj5eYCT56HubJCq8J++kvVF9NeNsEJfX+Z8dfCb5bOb7cjoZOzxtpOXCPIenvBnLc b3Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=OHNuC9urNtUcXoN6+tNQMQPQMvHYHPkXX56YBWbIz50=; b=bFwcUHwJqtOtHzlMDrYAF9K+LktaRsEy2+JNlbXKq/0Bn2zaL9l23GCxHhjFspW6mK cd5K+Xj10bSAYetLNgZ5p4QafAPmXjqnAfIo/MzYDAhh5Y/px34SeXX/DmR2ozpIglbq BE/T7BFFVZiQJYoHP3WB0xLx3BG4LxyYz7hXltJNywm53oDoccoTZzLYK8Ie3rn3ftNJ BZBXhNm2w0N+ALmATYFtin5JVaVdfrosCH0y48M/BA3SMLG/HPOxpWGmC2EAUZgNlQr/ rtXCOuX7s/v8leFZ4sO2MY/ZXQZQrpykfsfdKdc3oQZ71vNoHEXxoIXCeVh1g2EAWfBQ ExXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dc13-20020a170906c7cd00b006df76385c50si1706872ejb.240.2022.04.01.07.53.55; Fri, 01 Apr 2022 07:54:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343628AbiDAHFh (ORCPT + 99 others); Fri, 1 Apr 2022 03:05:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236804AbiDAHFc (ORCPT ); Fri, 1 Apr 2022 03:05:32 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9362AF; Fri, 1 Apr 2022 00:03:41 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KV9yW2txtzBrvc; Fri, 1 Apr 2022 14:59:31 +0800 (CST) Received: from kwepemm600015.china.huawei.com (7.193.23.52) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 1 Apr 2022 15:03:36 +0800 Received: from [10.174.176.52] (10.174.176.52) by kwepemm600015.china.huawei.com (7.193.23.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 1 Apr 2022 15:03:35 +0800 Message-ID: <3381d7df-7254-e0ba-648c-6e763bda2ea4@huawei.com> Date: Fri, 1 Apr 2022 15:03:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH -next,v2 0/3] nfs: handle writeback errors correctly To: , , CC: , , , , References: <20220401034409.256770-1-chenxiaosong2@huawei.com> From: "chenxiaosong (A)" In-Reply-To: <20220401034409.256770-1-chenxiaosong2@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.52] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600015.china.huawei.com (7.193.23.52) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/4/1 11:44, ChenXiaoSong 写道: > v1: > cover letter: (nfs: check writeback errors correctly) > > v2: > - return more nuanced writeback errors in nfs_file_write(). > - return writeback error in close()->flush() without consumed it. > - fix: nfs_file_write() will always call nfs_wb_all() even if there is no > new writeback error. > > > ChenXiaoSong (3): > NFS: return more nuanced writeback errors in nfs_file_write() > NFS: nfs{,4}_file_flush() return correct writeback errors > Revert "nfs: nfs_file_write() should check for writeback errors" > > fs/nfs/file.c | 23 ++++++++++------------- > fs/nfs/nfs4file.c | 8 ++++---- > fs/nfs/write.c | 5 +---- > 3 files changed, 15 insertions(+), 21 deletions(-) > It is not a good idea to modify error sequence mechanism, as the `lib/errseq.c` described: 22 * Note that there is a risk of collisions if new errors are being recorded 23 * frequently, since we have so few bits to use as a counter. 24 * 25 * To mitigate this, one bit is used as a flag to tell whether the value has 26 * been sampled since a new value was recorded. That allows us to avoid bumping 27 * the counter if no one has sampled it since the last time an error was 28 * recorded. So, if we want to report nuanced writeback error, it is better to detect wb error from filemap_check_errors(), and then return -(file->f_mapping->wb_err & MAX_ERRNO) to userspace without consume it. nfs_mapping_set_error mapping_set_error __filemap_set_wb_err // record error sequence errseq_set set_bit(..., &mapping->flags) // record address_space flag // it is not used to be reported, just used to detect error = filemap_check_errors // -ENOSPC or -EIO test_and_clear_bit(..., &mapping->flags) // error bit cleared // now we try to return nuanced writeback error if (error) return filemap_check_wb_err(file->f_mapping, 0); return -(file->f_mapping->wb_err & MAX_ERRNO)