Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     sparmaintainer@unisys.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: unisys: Remove "struct dentry *eth_debugfs_dir"
Date:   Thu, 31 Mar 2022 18:58:58 +0200
Message-ID: <5558288.DvuYhMxLoT@leap>
In-Reply-To: <20220331082202.GZ12805@kadam>
References: <20220331064751.29634-1-fmdefrancesco@gmail.com> <20220331082202.GZ12805@kadam>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On gioved? 31 marzo 2022 10:22:02 CEST Dan Carpenter wrote:
> On Thu, Mar 31, 2022 at 08:47:51AM +0200, Fabio M. De Francesco wrote:
> > There is no need for "struct dentry *eth_debugfs_dir" which is used for
> > debug / sysfs directories. Therefore, remove this "struct dentry" and
> > everything related (i.e., creation and removal).
> > 
> > As a side effect of this change, the code has no more need of the
> > "cleanup_register_netdev" label, which can also be removed.
> > 
> > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > 
> > v1 - v2: Add a couple of "Suggested-by" tags which were forgotten. 
> > Thanks to Dan Carpenter and Greg Kroah-Hartman.
> > 
> 
> Thanks!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> regards,
> dan carpenter
> 
I've just noticed that visornic and visorhba do other calls to 
debugfs_create_dir() and debugfs_create_file() functions.

I'm not sure whether or not this driver still needs those other calls.

Do you think that they should be removed as well as it has been done 
in the patch above?

Thanks,

Fabio M. De Francesco