Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202203311842.wFWvHrHn-lkp@intel.com>
In-Reply-To: <202203311842.wFWvHrHn-lkp@intel.com>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Thu, 31 Mar 2022 12:12:42 -0700
Message-ID: <CAJuCfpEObhCKuJeHNqxna1=N1+f738dTDnUjGPFST1PqqAqcVQ@mail.gmail.com>
Subject: Re: [ammarfaizi2-block:google/android/kernel/common/android12-trusty-5.10
 1060/5872] arch/arm64/mm/mmu.c:1499:5: warning: no previous prototype for 'check_range_driver_managed'
To:     kernel test robot <lkp@intel.com>
Cc:     Sudarshan Rajagopalan <sudaraja@codeaurora.org>,
        kbuild-all@lists.01.org,
        "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 31, 2022 at 3:17 AM kernel test robot <lkp@intel.com> wrote:
>
> Hi Sudarshan,
>
> FYI, the error/warning still remains.

The warnings has been fixed in later patch:
https://android-review.googlesource.com/c/kernel/common/+/1668705
android12-trusty-5.10 needs to rebase to the latest android12-5.10 to fix this.

>
> tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-trusty-5.10
> head:   07055bfd3d810d41a38354693dfaa55a6f8c0025
> commit: 1b4aca7d82ae9b40145484fa09ceab38a6a06062 [1060/5872] ANDROID: arm64/mm: implement {populate/depopulate}_range_driver_managed
> config: arm64-buildonly-randconfig-r005-20220331 (https://download.01.org/0day-ci/archive/20220331/202203311842.wFWvHrHn-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/ammarfaizi2/linux-block/commit/1b4aca7d82ae9b40145484fa09ceab38a6a06062
>         git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
>         git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-trusty-5.10
>         git checkout 1b4aca7d82ae9b40145484fa09ceab38a6a06062
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/mm/ drivers/gpu/drm/hisilicon/kirin/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> arch/arm64/mm/mmu.c:1499:5: warning: no previous prototype for 'check_range_driver_managed' [-Wmissing-prototypes]
>     1499 | int check_range_driver_managed(u64 start, u64 size, const char *resource_name)
>          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    In file included from include/linux/printk.h:7,
>                     from include/linux/kernel.h:16,
>                     from arch/arm64/mm/mmu.c:11:
>    arch/arm64/mm/mmu.c: In function 'check_range_driver_managed':
>    include/linux/kern_levels.h:5:25: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Wformat=]
>        5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
>          |                         ^~~~~~
>    include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
>       11 | #define KERN_ERR        KERN_SOH "3"    /* error conditions */
>          |                         ^~~~~~~~
>    include/linux/printk.h:343:16: note: in expansion of macro 'KERN_ERR'
>      343 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>          |                ^~~~~~~~
>    arch/arm64/mm/mmu.c:1509:17: note: in expansion of macro 'pr_err'
>     1509 |                 pr_err("%s: couldn't find memory resource for start 0x%lx\n",
>          |                 ^~~~~~
>
>
> vim +/check_range_driver_managed +1499 arch/arm64/mm/mmu.c
>
>   1498
> > 1499  int check_range_driver_managed(u64 start, u64 size, const char *resource_name)
>   1500  {
>   1501          struct mem_section *ms;
>   1502          unsigned long pfn = __phys_to_pfn(start);
>   1503          unsigned long end_pfn = __phys_to_pfn(start + size);
>   1504          struct resource *res;
>   1505          unsigned long flags;
>   1506
>   1507          res = lookup_resource(&iomem_resource, start);
>   1508          if (!res) {
>   1509                  pr_err("%s: couldn't find memory resource for start 0x%lx\n",
>   1510                             __func__, start);
>   1511                  return -EINVAL;
>   1512          }
>   1513
>   1514          flags = res->flags;
>   1515
>   1516          if (!(flags & IORESOURCE_SYSRAM_DRIVER_MANAGED) ||
>   1517              strstr(resource_name, "System RAM (") != resource_name)
>   1518                  return -EINVAL;
>   1519
>   1520          for (; pfn < end_pfn; pfn += PAGES_PER_SECTION) {
>   1521                  ms = __pfn_to_section(pfn);
>   1522                  if (early_section(ms))
>   1523                          return -EINVAL;
>   1524          }
>   1525
>   1526          return 0;
>   1527  }
>   1528
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp