Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Apr 2022 08:01:34 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        sparmaintainer@unisys.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: unisys: Remove "struct dentry
 *eth_debugfs_dir"
Message-ID: <YkaVPtpgLk7zc1e/@kroah.com>
References: <20220331064751.29634-1-fmdefrancesco@gmail.com>
 <20220331082202.GZ12805@kadam>
 <5558288.DvuYhMxLoT@leap>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5558288.DvuYhMxLoT@leap>
Precedence: bulk

On Thu, Mar 31, 2022 at 06:58:58PM +0200, Fabio M. De Francesco wrote:
> On gioved? 31 marzo 2022 10:22:02 CEST Dan Carpenter wrote:
> > On Thu, Mar 31, 2022 at 08:47:51AM +0200, Fabio M. De Francesco wrote:
> > > There is no need for "struct dentry *eth_debugfs_dir" which is used for
> > > debug / sysfs directories. Therefore, remove this "struct dentry" and
> > > everything related (i.e., creation and removal).
> > > 
> > > As a side effect of this change, the code has no more need of the
> > > "cleanup_register_netdev" label, which can also be removed.
> > > 
> > > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > ---
> > > 
> > > v1 - v2: Add a couple of "Suggested-by" tags which were forgotten. 
> > > Thanks to Dan Carpenter and Greg Kroah-Hartman.
> > > 
> > 
> > Thanks!
> > 
> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > regards,
> > dan carpenter
> > 
> I've just noticed that visornic and visorhba do other calls to 
> debugfs_create_dir() and debugfs_create_file() functions.
> 
> I'm not sure whether or not this driver still needs those other calls.

It looks like those drivers create actual files in debugfs with
information in them, so I would leave them alone.

thanks,

greg k-h