Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c69ee5e5-213f-389c-9d22-69addddf2aca@intel.com>
Date:   Fri, 1 Apr 2022 09:00:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH 1/3] ASoC: Intel: catpt: remove check of list iterator
 against head past the loop body
Content-Language: en-US
To:     Jakob Koschel <jakobkoschel@gmail.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Jie Yang <yang.jie@linux.intel.com>,
        "Mark Brown" <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        "Yang Yingliang" <yangyingliang@huawei.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        "Cristiano Giuffrida" <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>,
        Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
References: <20220331215003.882143-1-jakobkoschel@gmail.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20220331215003.882143-1-jakobkoschel@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU0vdkpEUFY2dTJCcXluOERHUklyYXNjT1NXR3hMYzcvbVBJbmRkMm9scWlH?=
 =?utf-8?B?ODJ1eGRmSVlJdU1oN3d0TEVyeitmMlBOemJWYldwM212UFhOc29HZExLNHQ2?=
 =?utf-8?B?bXJpV1F0bzN5WWJYOFB0N0xWeGw4WlVFUW5CRko3WlcxV0RQb1pDT0tBTnMv?=
 =?utf-8?B?eDNhMklUS0FvWW8rU25keVFvdjlVK1ZFYU91ZnlSYVJxdUFiVEhJVTQ5QW9L?=
 =?utf-8?B?Rmx2dkVpZHZ6bTNlQWpOS0IvQWRETHJvUzNiSFQxQWFEVGNZeXpzcm5YL24z?=
 =?utf-8?B?STJzSXRLQUR4dy83VUp3QndmMS9BbTJuZlpXS0NyVDVHV1huYkZCd25jWG1s?=
 =?utf-8?B?MkhNL1djajkxQktQU1Z2YUhHeWExS3pGNlhPZUtxMVk5Slg4VEZobkUySDR0?=
 =?utf-8?B?dktuYWFLMHFGZ01sMkI4WkVBSzBiTWErVFRhaE5XeDRrdU5sR29RNHR2NGNy?=
 =?utf-8?B?STFrdVVlQUJFZUkvUWV5VGhNNU9tR2xOMzY2OTR1dVkrK28vdm9oUHJXL21N?=
 =?utf-8?B?TWx5SFdwZ0g1Z0tmZHJEdDFZcFVNVVhHS242Z3I5MVZDUXV2bE5UT3c0YTMz?=
 =?utf-8?B?ejVBU1RkV2U0Vzd1TmNtM3ZaSmJRWFZsOGEva1FjclVTK0Y1cnlIRWQ1dEk3?=
 =?utf-8?B?WStDVm5YTEE5d3p4YnA5bUcvSGNrNFAwWEdISjlJTnhKZ1JsVUhZMndWTkZH?=
 =?utf-8?B?MG5seUlyWXlzNFdhTGNkUkR3bUR2SW1TVE83cm5GVTByUjl3TGJvbElhV2dI?=
 =?utf-8?B?VFl0N3k2TGFkU3pYRVB0azNuOERibWZ3R09TTlBzZDVQeU91Uy94YXkza0JV?=
 =?utf-8?B?QzE0eGQzRFJGZ3dranBwa1pZd29SRTlZSHMrVEVWRWlNNXVvZEYwcGdPM2xS?=
 =?utf-8?B?VCtlUnpVZkdWdG4xa0IwZm5FZHdvUkp6SXA4Zm9JRzc1cUUreStLa01STGF2?=
 =?utf-8?B?dlY3TnhhSnVVRHJhTXVYdG1WTmwvMElrQmVFejdua1l3MTBqYW45dy9xakZm?=
 =?utf-8?B?TzJ1NFpsOFVQck9NTGgySE5LTjdOWXVqSTFTdTdTdGZlZytiVzgvU1FKdWRZ?=
 =?utf-8?B?dXNiek96MGFUZE52SjVlMGdRVk9FNW9FVnRWYnlaTWNvSjNXU1B5QzFXWDg4?=
 =?utf-8?B?YzFOMWdDVXhBMEdtRTFTN3ZDQWoyekx1ZjdCTTYzQ1F6R2lzWEE2K1BTeUk5?=
 =?utf-8?B?azBrWjJQNDBFYW5ZSGdIOEdWNzB0UHpHcmlIZjU4VG16cGM2RTF3YmJ0OXMz?=
 =?utf-8?B?am4vWktHS29HQkFZN2Z3S0t0M2F3TzdSdDNwcnhESDNMN2tobStHb1RrWjZt?=
 =?utf-8?B?VGJkNzdVbWZBRitqNUpHUlZnc05DYzA4R1BXejVtVHZjdERoNmU2ZmpBN05R?=
 =?utf-8?B?Vmx6Qlc5L2NlYnJ2bXNhRXpHZldlMUM1RUNUSFducWNZdlpRTHBJSXlUWklH?=
 =?utf-8?B?Q3h1ZWlsS1FQNUlQS1ZUak00OEh3dXVCQlRxTGE3cWQ3V2hXL0g2OFRzVFU0?=
 =?utf-8?B?S3BmZE1aaENwTUpmUlo5L2lCZVJQdnlINTd3aVc1YldNdmNZQTVzUnBjdTdr?=
 =?utf-8?B?L3Jjd0I5bTBhZUM5RHdRYUtiUkduT3hCT0YvUFRnR2szblVEQStLaTVCeDNp?=
 =?utf-8?B?WStuOS92cjA0aElGOWx4SW1MY3J5VDBIdzVGYm1NNzBvdkF5anEyaUFxU1hp?=
 =?utf-8?B?TW55SHk4M3d1alZ1U2l3RkcvdndIdVR4aUs5YnpkL0hla2liK0RTOXAwN2JE?=
 =?utf-8?B?aEhCd1RJWnpXeWFCL3JqWi9lQ2ZVUG1NT1BVNnd5dktvNFIvSFFpZDJ3bmV6?=
 =?utf-8?B?cjAweHNaMldBcjBPNkc5SllqMjJqVTFyOGM3SWJvcTBuOFdVM1RocmhLZ0Yy?=
 =?utf-8?B?WmJkVzFkenBCWVV0c0k2Y3lqTTRPSnlwOU5yQkdVLzdDUzlEVnU5OURSN2Qr?=
 =?utf-8?B?VVN3amFYcy9mWGpFU2VoNlM3eFczWnNLL1dMaUFmMWVyVllGNjZZYVBtUmk4?=
 =?utf-8?B?TDRLK2ZjU2I4ejAvOVhITUdhTmFrazBhY1NLV2hPQm9FbTBBRzdSMnFzRXNR?=
 =?utf-8?B?Z3JpVnJ3R3FxeEtsOUhsbitWSnV0ZXg2b0lwUHp2c21VN0U3K0xVSGdncXpK?=
 =?utf-8?B?dEtRNnF6ck15YjVlYkFndGdERnFWNGVnWWpoQW5VL05FUFVOV0FZbWtMTkpj?=
 =?utf-8?B?OUxyZkpCYzRqeTFlQi9Mdk11bFpab0tqbFRGZUdQMTNXMzJTaW5Sc0tUVE5S?=
 =?utf-8?B?UFJ6MERPRmFNc3ZTRlhVZ3BnTENCallwYVdlanBBNXJmaEJKTjgrc21pNlRO?=
 =?utf-8?B?citGSkV4K205UDZjempNYThsOTd2dnB0aTRRMDZGdzRublE4bWVkZkRSSzJT?=
 =?utf-8?Q?m1+1p3HC42ZCXlCM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ab60889d-99b7-443d-5752-08da13ad4948
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2157.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 07:00:20.8593
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jFZ4Izea/v/b5tNL+ty1y+sYPd3H7uauCejPRgRScjXvxY1atF//sQvUAEpmmIXCdKgz9zCMAKJsZyBAyI13Lucy8wyhvMV/QWRSMJhn54k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3056
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-03-31 11:50 PM, Jakob Koschel wrote:
> When list_for_each_entry() completes the iteration over the whole list
> without breaking the loop, the iterator value will be a bogus pointer
> computed based on the head element.
> 
> While it is safe to use the pointer to determine if it was computed
> based on the head element, either with list_entry_is_head() or
> &pos->member == head, using the iterator variable after the loop should
> be avoided.
> 
> In preparation to limiting the scope of a list iterator to the list
> traversal loop, use a dedicated pointer to point to the found element [1].
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>

Thank you for taking time and updating catpt-driver along the way.

Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>

> ---
>   sound/soc/intel/catpt/pcm.c | 13 ++++++++-----
>   1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/soc/intel/catpt/pcm.c b/sound/soc/intel/catpt/pcm.c
> index a26000cd5ceb..b103b2d4026e 100644
> --- a/sound/soc/intel/catpt/pcm.c
> +++ b/sound/soc/intel/catpt/pcm.c
> @@ -330,7 +330,8 @@ static int catpt_dai_apply_usettings(struct snd_soc_dai *dai,
>   				     struct catpt_stream_runtime *stream)
>   {
>   	struct snd_soc_component *component = dai->component;
> -	struct snd_kcontrol *pos;
> +	struct snd_kcontrol *pos = NULL;
> +	struct snd_kcontrol *iter;
>   	struct catpt_dev *cdev = dev_get_drvdata(dai->dev);
>   	const char *name;
>   	int ret;
> @@ -354,12 +355,14 @@ static int catpt_dai_apply_usettings(struct snd_soc_dai *dai,
>   		return 0;
>   	}
>   
> -	list_for_each_entry(pos, &component->card->snd_card->controls, list) {
> -		if (pos->private_data == component &&
> -		    !strncmp(name, pos->id.name, sizeof(pos->id.name)))
> +	list_for_each_entry(iter, &component->card->snd_card->controls, list) {
> +		if (iter->private_data == component &&
> +		    !strncmp(name, iter->id.name, sizeof(iter->id.name))) {
> +			pos = iter;
>   			break;
> +		}
>   	}
> -	if (list_entry_is_head(pos, &component->card->snd_card->controls, list))
> +	if (!pos)
>   		return -ENOENT;
>   
>   	if (stream->template->type != CATPT_STRM_TYPE_LOOPBACK)
> 
> base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275