Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v1] MIPS: ip22-gio: Add check for the return value of
 kzalloc()
To:     unSimple <unsimple1993@163.com>
CC:     <tsbogend@alpha.franken.de>, <linux-kernel@vger.kernel.org>,
        <linux-mips@vger.kernel.org>, <ralf@linux-mips.org>
References: <1648454654-27200-1-git-send-email-unSimple1993@163.com>
 <6dd8bcf0-20a1-0bab-b48e-ec1bac5c15f0@omp.ru>
 <16aa9238.4bf6.17fd8fe37ad.Coremail.unsimple1993@163.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <4eb43887-44a4-4693-8488-4847d80b6bd8@omp.ru>
Date:   Fri, 1 Apr 2022 12:09:57 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <16aa9238.4bf6.17fd8fe37ad.Coremail.unsimple1993@163.com>
Content-Type: text/plain; charset="UTF-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/30/22 7:03 AM, unSimple wrote:

> OK, here is the new version.

   That won't do, your original patch description should be here.
And it should be a fresh posting with [PATCH v2] in the subject.

> Signed-off-by: QintaoShen <unSimple1993@163.com>
> ---

   You need to describe what changes between v1 and v2 here...

>  arch/mips/sgi-ip22/ip22-gio.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c
> index dfc52f6..f94f58b 100644
> --- a/arch/mips/sgi-ip22/ip22-gio.c
> +++ b/arch/mips/sgi-ip22/ip22-gio.c
> @@ -363,6 +363,10 @@ static void ip22_check_gio(int slotno, unsigned long addr, int irq)
>  printk(KERN_INFO "GIO: slot %d : %s (id %x)\n",
>         slotno, name, id);
>  gio_dev = kzalloc(sizeof *gio_dev, GFP_KERNEL);
> +

   No need for empty line here.

> +if (!gio_dev)
> +return;

   Hm, the tabs were there but they got eaten when I replied.
Your mail seems to be base64-encoded which I don't think is
acceptable for patches -- they should be posted as plain text.

[...]

MBR, Sergey