Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Apr 2022 16:44:23 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Sandipan Patra <spatra@nvidia.com>
Cc:     treding@nvidia.com, jonathanh@nvidia.com, digetx@gmail.com,
        ulf.hansson@linaro.org, cai.huoqing@linux.dev, bbasu@nvidia.com,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources
Message-ID: <YkcBt74odxdoBlQ3@smile.fi.intel.com>
References: <20220401104935.9149-1-spatra@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220401104935.9149-1-spatra@nvidia.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Apr 01, 2022 at 04:19:35PM +0530, Sandipan Patra wrote:
> Reset_sources list is updated to add all reset sources
> and removing ones that do not actually exist.

...

> +	NULL,		/* 0x10 */

I would suggest to add the comments more often, like every 8 entries.

...

> +	"FSI_VMON"	/* 0x25 */

It would be good to have comma here as if this ever getting expanded
the additional churn may be avoided.

>  };

-- 
With Best Regards,
Andy Shevchenko