Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <854c30e3-1dc6-fc8c-caee-d4dfffb79c4b@fb.com>
Date:   Thu, 31 Mar 2022 19:49:09 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] selftests/bpf: Return true/false (not 1/0) from bool
 functions
Content-Language: en-US
To:     Haowen Bai <baihaowen@meizu.com>, Shuah Khan <shuah@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>
Cc:     linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1648779354-14700-1-git-send-email-baihaowen@meizu.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <1648779354-14700-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anNWRUhHTFNIRG00NWpiU2xPYWc3SS81aXU5ODQrL2tYeDd3WWU5N2dyalpv?=
 =?utf-8?B?akJSMTlNM3B3cDExUUkxcE11aXJxWVgyWWVGMW9yWXl2RStxRC9mUVRYUUM2?=
 =?utf-8?B?dXVidU9maS9ZN3JOTXN5ZkhHYWpIOXMvWCs1TzhHUkFNelpQMlhDeG5oaVNB?=
 =?utf-8?B?S1Z1OXdpY2trUVFjeDVITXR3dEcxb1FXbWlPK1FvL3pzZmYxVTBNK0lNM0s0?=
 =?utf-8?B?cUdBZE9wUkE0OHp4U2NZY0ZFNUxlcmRjbWZ3aDZLMXkwZmcrZDdOR1Y4VGY2?=
 =?utf-8?B?cWhMK3A1YWlpQTVLSjVlRkFFYXhNV3FMOTk0RUE2V1dGbk1EY2FGMzE2T3Nz?=
 =?utf-8?B?dTZIcHRNSVpYK3lET0FoNHdpQlovcWhZa2FOMXhoUUVDRjVvbEh5M3dBUXNB?=
 =?utf-8?B?eTUwdllOREIzTFZKUml4UGI0ZlJMdHI1Mm8wYTE4VjNMa1RmcXVOT3Exc2Ra?=
 =?utf-8?B?ZEE5NU50a1U0eFc4YS9ZYVRjSTRkYi9uWDd6V1djZ2pTc1VzRThIMVdvU2Fk?=
 =?utf-8?B?U2FKOHcrSEdqVUpIWmx5b05OMFVrdFhQU2JJSFEwazdwc05rSDZBUzEyRkJi?=
 =?utf-8?B?dDgxY0lsQmg1Q3ZwdXVRSjEzSVp0OTV4Y1J5UkFPQlQzWmlYcjdYTFhYYzZH?=
 =?utf-8?B?c0ZGRzZkZ1dxbFl3a09WdStvWkdCWEFzS3dmWWlQWkd2a2ZyRVZoYSs5Tkl5?=
 =?utf-8?B?ekFXdC9relNMTHVlZkFUdGx6SVBtZks4RFRvRS81aUxGYk5pZDIyV2gyNUhn?=
 =?utf-8?B?Wk9hdTY2ZzRHc0hFOU0rUG01OVlXQmdqWUE3cFgvM2JuWU1YQlNjdHMzdTlB?=
 =?utf-8?B?UndOU0lXdmhaWTlvS0xpWTZET3VaS05wQWoxT00wNU9hVmZPNlBaR2Rjemlk?=
 =?utf-8?B?WndOYmMya2FiM2ZMNWdxSFl3Ny9Ma3gxSzJqbFpOdmtOOHhWUkMreTl1emdJ?=
 =?utf-8?B?ZUF2REtiNzJoQ3plYTBMUER2Ni8zMldhOW9TNmFseHA2U2duRUxIZ2M2bDE3?=
 =?utf-8?B?REdJbm0wQVZzS0x2UjNFS2FUeHFYTHZSWWE4cEpnc2tmdDlhUTNqQ3NsbVhC?=
 =?utf-8?B?bVRZNzVPL3NIUE5sZjlvc1VCSVZGS3J1Q3VaZ3o4dUlUQ3VYQi9wdkNhMEJB?=
 =?utf-8?B?b2RXUUlHRlRxZHJXQ3FoV0FCWGZLYVV0QkQ1S3FpQkRLNzhFRXFVNGtvc29l?=
 =?utf-8?B?Szd3TGpRS2pxazZKYVprOEQwZlM4K0lnMkp2bnNWOFI1MHZZSGxkTjRLQUd4?=
 =?utf-8?B?QnV4blVldmVJeXJlTGc4aEYvdllXdnlqemxSV1BZaUV0N3VQUnBXTmZWVjlL?=
 =?utf-8?B?ZGY3c1FNMHFOa0NaempRYjZrU2xWZHZ6eUVXTGxVb0F5WWY1VzljTXdJUmJI?=
 =?utf-8?B?dFl3dHM3N3pxZEpLRllKQlE4bks5K1pCUDBtb0c0bDQ0NGJRYVUwL2xFTUVF?=
 =?utf-8?B?dWhBQ1pIRUwwZEJXUzBweUlUVnJtNnUwVm43ZEROL1dQY3FWRGNoUnozaFJO?=
 =?utf-8?B?NzN6a2dJSXR4WCtWR2xtQ29PM2pqbENHQzRhYTVmRlAvRE5Oekl5SkZOMnQz?=
 =?utf-8?B?azlnNm8zWVF6YVZ2OVhtTUhPazIvYUFiY2x2SmJ3bjNXeEVQemhDdC9ydkVU?=
 =?utf-8?B?UHRMa1ZHdDRrV0xSVi93N25PVnl3VUN5RlRBRkdiU3IwbE9uQkhJanVDQ1RJ?=
 =?utf-8?B?UytxMmJxWUZUbU85YUZyVGpOZzQ4SWtlL2l3VmwzT2t5U01lVDV6azA4R0FB?=
 =?utf-8?B?TG96b2poazNWOUpyK0VRODJWbndTMkZpQmNvRS8xTjlaUGJ5Y3J5bFV4Mmhv?=
 =?utf-8?B?a1Z3d3A4MmJXQ2xCY0hRUVJQZ1pyYzYrMGJoS3dwSTljdjVTTzl5Z1Uwd0JK?=
 =?utf-8?B?WjBuemlieE1IWTA3aUpiU0pJS0NJbHpWNnJ4dWx1dVhuRmxUcGUyOVpGYTVU?=
 =?utf-8?B?VGZTSU4zUzh4WC9pOTFKenlZK3ZkTm9vK2N5L1Z0Y1ZncUtpWGNudGZiTUJ3?=
 =?utf-8?B?R25tMjRWVlV2RzlJckRiL3JwYStrRG5ITU5IdnA4YTRMdStVdHgyczM1c2ZX?=
 =?utf-8?B?eVRvdjVrUE5YaExoazA4S3NzR0ZWalE3MHdRWjltWHduWnhUdFo1RDZXWUxy?=
 =?utf-8?B?Y3FJYVFkS01RNEIzeTVndWJSWkgrNlp5d2Y3b1FUYzl3STFZTFkrK3k3enVu?=
 =?utf-8?B?UzB1TmhJbng4ckUwRFV6N3NscE9Pckw1KzgrdVFDYkNwQUJjdk43QmFvSnFt?=
 =?utf-8?B?eG11TE9HV1BROEdxVTlVRGg0amJSUXY5enRZRUp4SlVYdTZVTEc1OTJ4YlY3?=
 =?utf-8?B?TEtzWktaMzVpS2drbnNxNVFsMStwQW5FQ3hkZldZaDdCejFzTkRuVTQwSC9j?=
 =?utf-8?Q?UDG/ULarXxmI7k8E=3D?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2db47df-51c7-44b5-1acf-08da138a3568
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 02:49:15.0338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: owYR62Zy/JQ423uyCQ2ClTeMnek05t5C0/GrKmbWgchiz8qmwDUd5K4CRuu+50Al
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2759
X-Proofpoint-ORIG-GUID: YM1bE6Czf169Evg8n4k2u0AbqX8AykfC
X-Proofpoint-GUID: YM1bE6Czf169Evg8n4k2u0AbqX8AykfC
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-03-31_06,2022-03-31_01,2022-02-23_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/31/22 7:15 PM, Haowen Bai wrote:
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> functions.  This fixes the following warnings from coccicheck:
> 
> ./tools/testing/selftests/bpf/progs/test_xdp_noinline.c:567:9-10: WARNING:
> return of 0/1 in function 'get_packet_dst' with return type bool
> ./tools/testing/selftests/bpf/progs/test_l4lb_noinline.c:221:9-10: WARNING:
> return of 0/1 in function 'get_packet_dst' with return type bool
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

Acked-by: Yonghong Song <yhs@fb.com>