Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liu Ying <victor.liu@nxp.com>
To:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Robert Foss <robert.foss@linaro.org>,
        =?UTF-8?q?Guido=20G=C3=BCnther?= <agx@sigxcpu.org>,
        Jagan Teki <jagan@amarulasolutions.com>,
        NXP Linux Team <linux-imx@nxp.com>
Subject: [PATCH] drm/bridge: nwl-dsi: Drop the drm_of_panel_bridge_remove() function call
Date:   Fri,  1 Apr 2022 09:58:28 +0800
Message-Id: <20220401015828.2959505-1-victor.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1BQQkRKejNoWC9jV2lXeUpSTHNxTmsvTzdYbWNmYmE3T0ZjakpCeWl1aTdJ?=
 =?utf-8?B?dEt3MHlmNTFEMHhxdDlXMGVuVDhRUnNOU25Wb2ZiNkF0ZnhZeW5RalFjQlBH?=
 =?utf-8?B?cjkzeFBXVHVYemt4U2c2S1pnQm13S05WMkRGLzRRdEZiMERnckhWdFdHampi?=
 =?utf-8?B?T2orK3NjcnhWOWZpWThGdmdXb0ZxYmxTZDhxRmZPRkZOc0RKcUhLQ3BTeXJ6?=
 =?utf-8?B?Z2JwRUJ1ajJVeUs0Z2NBWWV0Z1VVd0VzVXhCMU93UUZBUlgzV3JZM3N2bGlD?=
 =?utf-8?B?QzVkWnpUK29sb2o3ekdySmpRVzErOWlpeksrWUg0blNqclBjZW43clRRWUxC?=
 =?utf-8?B?UVZTZnRaNWpyVS9QczA1eEd4SjRLU1RxM2xCYndML3RMZTBXcWlsTlNuWVY1?=
 =?utf-8?B?Snd5M2R0YkZFdTNVU0JJdkhDNUdsdTZSazBKdmF2YTBJZ3l4cFU5TVZHalVs?=
 =?utf-8?B?Ym5FYm1mNHZ1SUlLeHhuNkRRU0t1ekR5UDVGRkR1QVdlSERpdHhJUE5Ma0Fy?=
 =?utf-8?B?T3ZxTHdZWEtvc3FqTkRPQVhPNEppMDY5MHRIUUt1Q0V0Qno2WEhsTDNNS1NC?=
 =?utf-8?B?d3c4bW0wcU1hQ2t6cDNsS3ZMbTRVeGhXTi91dDhGVHlDOTV0QmQ1M1dhV0Iw?=
 =?utf-8?B?TnZrSWNXd3poM0hsSFJEcEdsREFaWk9seEhQNkp2ZVAvV0txNC94K2xuL01K?=
 =?utf-8?B?ZldNUmxEUCtrTU42VHRqbzBGODA5akZJUXR2T0FDQ2lqV3JpbmhTMFY3aVI4?=
 =?utf-8?B?ZW9VUTh1VzhEZlN0dzhwbGJHYnJ0VzJIbEM0c05VUzJuRVVmYUR2RFA5SDlU?=
 =?utf-8?B?WVRqTmRsQ2dTNEtIb0FkdFVSL1hscXJyQk5NVUxBQlg4Z0VqczM3bjhIZ0tk?=
 =?utf-8?B?T0tOUFB6eFJPRHVlelh5NHBzVkZUTkVtVDBSYjJxSDdkUVZzc0hLYVR6WVNQ?=
 =?utf-8?B?Y3JrOFRtM2VEUGdLYVUwaHdJNFV1QWhaQlRjekdzV3hDNzliSy9FK0dpbnYv?=
 =?utf-8?B?RnpsV1NNeVJGMVQ1L3JIMjl4Q2pvUzB3TmxHOUxmb01lWTEwOE0ySVBpTG1R?=
 =?utf-8?B?ZUtadmJWWWJnaHliQVRiekcrWk9zazF6cUwrS29zRTZnYUNydUFNUmtqU2Ju?=
 =?utf-8?B?SXF3c051ZmlodGhqa3BvL2NoOSttQU1XZ3E1d0lPV1pWdkxWSzlGZFBMRUc5?=
 =?utf-8?B?SFhmMklsZmh0RFlmd3VBTThQNHFBNS9xL3RFQmRnRkdWU3BkSUJQTVg0T0NV?=
 =?utf-8?B?K2hZUDJndFV6MEIxNndoYllEbkszemdqTUJWUEIwak1JamtSMFNaOHNLYytt?=
 =?utf-8?B?Z3FNbTVvSTg3dEpBa0pyZUYrZHErM2Vza01YdXNYWDVPbEFVYVIvUXh0U2tv?=
 =?utf-8?B?Y3NRcmE1VGMvSTJwdEo2QUxXTGkxRHYwNEhKOVRQUVM1NllCVGIxTVJKQXVM?=
 =?utf-8?B?SjRqR3UzMGVqc0pXUDM4bWs3SHFCeDJyZUhLSmRZT1JXZDVNVUNXc05FQkFV?=
 =?utf-8?B?bVVEL2hDc1Vvb2JVS2JRRlNqbWJQRXRmTUJ0QUhyMjhhR013TUlOOTZDTlZH?=
 =?utf-8?B?S3Q3QmN0VlJYWFFuUit1U1VJd0tYam1YSS9BQjQxVURPZXdVZzJ3UHVIOW9C?=
 =?utf-8?B?Sk5SR3ZUdzYyZTRwT2tMUDV0eDFkcFB1WkJRbE82Y1hkSFppTXRGR1lMYVdS?=
 =?utf-8?B?bTBpcHlGbmI1WGNEaGU3MTVONFdhbWlyUjZBQ1RCaG9CcnNlVzRzUDN3RnBU?=
 =?utf-8?B?ZnU3U3ZqNWdsWmpGemRpU2NGTHo5akxKT1Z5SjBsanJOdnVyM0ZQVEZzZTl0?=
 =?utf-8?B?K2xYOUFUaG5pTHpVcXBhWUg3QkhoTVhKY2IrTnZ2d2dXdnlsaTl4SjgyTmdK?=
 =?utf-8?B?d0xuK0RncW1laXZ0RHEvUTlXSGVNUHo2a3RLTitUa1RHWVc2L0lXTVRLUmlO?=
 =?utf-8?B?NjZSSHN0NWZVYy9pQU5jdDlSOU1Rb3EyWjAySS9QVXdGa2I2cjZFb0NORGd6?=
 =?utf-8?B?cDR3Z1BXYThFRTBGQnBqcjFaL1pST0p2RlYwV0VMY2NRYkJPa3VFNFpHZHQy?=
 =?utf-8?B?QXJDRWd4VlV2VVpDMDV2c25DTWM5eTlDR2xvNlZvZXJmWXk2MDlMZXFJa2lC?=
 =?utf-8?B?MFZKVjlSZmt5VUpIZXhiMU1xMUVhTTF2ZzBFQzVuMzdINDZRSU1rNFJtdTJL?=
 =?utf-8?B?V0hkRm9KODJQUUJkdHhvY2tuOXE2dUU5eFUvWm9hd2ZYbmxBMUxEYnlCaVFV?=
 =?utf-8?B?RWZrRHhHdkJ6S1hjZVh2UjhqMmUrZzZwYlNWRzZpVHlrWkEyMVllMmVSdU9a?=
 =?utf-8?B?b05rdFhzNmxNSFNLYjdmWjRDalFsakZYckE1M3RDRm5kcEd1emVCdz09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b82abea-23af-46bc-4d5a-08da1382e041
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 01:56:45.9148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vk5k27pqoYPMzRYw+RW63tBivGDRbqbKQi+7dr7bOcTdNQ/sRY4p5fXzky+yv5GZGCdPVwaUSV+oRe0PnGgBCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB2979
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since this driver has been changed to use the resource managed
devm_drm_of_get_bridge() to get bridge from ->attach(), it's
unnecessary to call drm_of_panel_bridge_remove() to remove the
bridge from ->detach().  So, let's drop the drm_of_panel_bridge_remove()
function call.  As nwl_dsi_bridge_detach() only calls
drm_of_panel_bridge_remove(), it can also be dropped.

Cc: Robert Foss <robert.foss@linaro.org>
Cc: Guido Günther <agx@sigxcpu.org>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/bridge/nwl-dsi.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index a549da5b3f93..47859d4506b4 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -919,12 +919,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,
 	return drm_bridge_attach(bridge->encoder, panel_bridge, bridge, flags);
 }
 
-static void nwl_dsi_bridge_detach(struct drm_bridge *bridge)
-{	struct nwl_dsi *dsi = bridge_to_dsi(bridge);
-
-	drm_of_panel_bridge_remove(dsi->dev->of_node, 1, 0);
-}
-
 static u32 *nwl_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
 						 struct drm_bridge_state *bridge_state,
 						 struct drm_crtc_state *crtc_state,
@@ -970,7 +964,6 @@ static const struct drm_bridge_funcs nwl_dsi_bridge_funcs = {
 	.mode_set		= nwl_dsi_bridge_mode_set,
 	.mode_valid		= nwl_dsi_bridge_mode_valid,
 	.attach			= nwl_dsi_bridge_attach,
-	.detach			= nwl_dsi_bridge_detach,
 };
 
 static int nwl_dsi_parse_dt(struct nwl_dsi *dsi)
-- 
2.25.1