Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1810290pxb; Sat, 2 Apr 2022 04:32:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJya1xq29H6khpmGc9FiV/fTCXD1bthiUmNOYJsnoo8hK4E+xFFoG24+1QFMU0vMRSGy5mk9 X-Received: by 2002:a50:a41a:0:b0:419:d2b:8391 with SMTP id u26-20020a50a41a000000b004190d2b8391mr25149106edb.390.1648899157060; Sat, 02 Apr 2022 04:32:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1648899157; cv=pass; d=google.com; s=arc-20160816; b=RoMf4HFurmQ2BEFyxDfIlQ6MP9QUDPMTaE8ny9JMppFzT+2p5m5IuwJxQ2oWrADVtR PnxZaRcuu7AswdrLLY8wKnOlXUREDLx1M8iOfXzevF1Gkp74y4TadISValQjAbonYelE drrUaPGHPUg8m0WPC/kVhL7F6UEdaP8YhyLarHDQ3Fd7QINGxWzO4OKJGMUJntssfJB/ 0Kzk2X/WT2BdrXSIhNDSRZb8o+b1WVUn5Zp/nx4Fg2CyXp3+rzTnifQLcHzrHDnxoPXG ezXUUiXjd+TAmjrp/AFpFAnPCyOT1uMGcv5O2MDuXzEQ6Mu+xUsinylFC31x1NNreoDw RSiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=lJ1rRgtFDy1WnNLW2a9FrBZWicHNfdHknBZaI60DBG8=; b=elyiT2rJP/fboa6lYYbqoaq7OB9RXTCvac1L833CDTuvQszh9C1MEsIZn2g+8Nk1n1 bgIdrnGw5q4ayX3jpnh0kcPncAssdfeCv0OMUBODrdpZpwyICWuTulQKA1IzI7dFX/JP NIPYX0ir3hXaMCcg5+E4nwoQo8fYaLAVFaBDfaFxcf0h3CFDRWhpWqfZ81ujCoLP9l1m tIGd7P2ahs5CCFlU2Omaq+8eSqRwKIzIeE9Cva4kHM0SjuLU3IQe2aEeJI1DfeAkw72E Kv9r5rfbaBnSDjAR9jIyRbn9xWx2+5F4C0zJSvjJuovBrn+nKQEnL6WVFmEmQVNHJAQI ExDw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo0.onmicrosoft.com header.s=selector2-vivo0-onmicrosoft-com header.b=oEsJSvfF; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v4-20020a50d844000000b00418c2b5bdd7si3246604edj.185.2022.04.02.04.32.03; Sat, 02 Apr 2022 04:32:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo0.onmicrosoft.com header.s=selector2-vivo0-onmicrosoft-com header.b=oEsJSvfF; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244305AbiDADCB (ORCPT + 99 others); Thu, 31 Mar 2022 23:02:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240392AbiDADB6 (ORCPT ); Thu, 31 Mar 2022 23:01:58 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2112.outbound.protection.outlook.com [40.107.255.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E463716F6D1 for ; Thu, 31 Mar 2022 20:00:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YK/4Kksv0qRUCQXOl9ELgV2H3p4d0bFyh9ZkqrYVeS2TYuPSYxt/n/gX8zNECWu4wudt8ZaX9+0H9yHPqhrYx6WgpgX3HcwN2ZZQiAV6HlfUqm5zgiO/IeU07nGuQGlcwzYfwzDywXzYKtnyGwNf8hhDSJDFoPPozTtAbeNa4tWFECnOoAL+3lUr9jW9kBcHhWfAR49ibLeXaPRQbS7bMWf16QkbuGDuBRzwyTlMW7L/rJGlN4g5SV/fV5Nt1eL7MkNu0WZXEXHcZ/tyrKf4mLmXA5myvtTpQgCEnUtpFyQdTeHiewEyoaypjsT44ChJVQzoXuEl3x3GczFggF1J7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lJ1rRgtFDy1WnNLW2a9FrBZWicHNfdHknBZaI60DBG8=; b=JmOEqcdIs67XkKJjzWUzpcpIqL9Q0GI3/TpSW8s8l/qM2R61h8m+wTONr6llwOX1kej2jo9v+FBMFFy3Lnrd4F/2viC88CmjH7oJzz6o50YROlQe0PZ5fIcnigjj6YQrlMYPc0X+wRu5ud+t+tZcKuthkC6NWajLxZPLgQexPudocpjXVqQt1GiJgzlPQrArzL32207E7LkX4zSZYl+oETxfkqXnRImEoG8hUERxJrSxK3go+efONOZgZer4p/2n0yzHGWAS17HjE9496T4gV/98IEUtzrUDdtEJ3in2nJWYoE0pYuegVCeCLEcAv3Mymz8YmEATOlUwyMdPhw3aCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lJ1rRgtFDy1WnNLW2a9FrBZWicHNfdHknBZaI60DBG8=; b=oEsJSvfFqBz6w/jQimof15n9JZ94HufgHZDHNn1sOzcC5tikPtvAfd7cjLB1j7ypInv4n2KUfa3pOy2YifPfYrDDO8ym3+3KC3JUHUwZK8Blk+K/qCFBuvzrNqykRaeLC0brnZM8lp+XNJ9RKMRq2Z0PkBa27pTlbY2RS+SQ/wE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from HK2PR06MB3492.apcprd06.prod.outlook.com (2603:1096:202:2f::10) by TYZPR06MB3904.apcprd06.prod.outlook.com (2603:1096:400:4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19; Fri, 1 Apr 2022 03:00:05 +0000 Received: from HK2PR06MB3492.apcprd06.prod.outlook.com ([fe80::5aa:dfff:8ca7:ae33]) by HK2PR06MB3492.apcprd06.prod.outlook.com ([fe80::5aa:dfff:8ca7:ae33%6]) with mapi id 15.20.5123.025; Fri, 1 Apr 2022 03:00:05 +0000 From: Guo Zhengkui To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org (open list:RADEON and AMDGPU DRM DRIVERS), dri-devel@lists.freedesktop.org (open list:DRM DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: zhengkui_guo@outlook.com, Guo Zhengkui Subject: [PATCH] drm/radeon: simplify if-if to if-else Date: Fri, 1 Apr 2022 10:59:29 +0800 Message-Id: <20220401025930.16365-1-guozhengkui@vivo.com> X-Mailer: git-send-email 2.20.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TY2PR0101CA0022.apcprd01.prod.exchangelabs.com (2603:1096:404:92::34) To HK2PR06MB3492.apcprd06.prod.outlook.com (2603:1096:202:2f::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c606c30-4812-4b96-1f66-08da138bb8bd X-MS-TrafficTypeDiagnostic: TYZPR06MB3904:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1cRiIqkCrF4HgehTX7eHScOc6fdBX78lmAvw8wvlVrXEQfsbo4pneXMXnSikKpF+Dv3XocNYtqf+7tDrN0ABAtOgzhM6zmxlJiZCZGrTOIQjPyw3XsUmXbYv+9lwMZoYvKMbvJkmE1V4I0Fe1cPhW4l23Iw94TQSB4MlgQ3Jd6sOzti7WmlbraP5dfjvM8W7TaPkd8WY9VpbvfVYR6TYhn/f9OELW0qlvDnEziw+Dwc1qIoRuugminviXgS0TzNTli+2PYbEVUc7LuLD/npWJAwFJWNCQes8gDUdXN/iRTmJX4OY2cotVnxlmB8WTM9Qg4J1beiFu7eCHBRTIX+FTbXGQwOUhhnjYalER7camU6FtTi77d/MOlLnzofcs3pHtzFSK2ysU+kG821ieQ9QIOz5sRjOCe/BFpUMJT/MuJQvtijqS6wf65Q+688pvV/Lf7HQjfqDMDeNsai4914VJu14mt1YPhQcIjcEuHUnEQM2DHb0ygsukzn2WOEuwLS4WOLP2T0Jf5jdrOhgp49y+P4NsfovNgA7M2IseGd9pGdLeSR7gdieiGQrrA4ls+gmNn2zqnnNOWskZVTYj7AyFbaKgVsnFoCb0lJ2TsSOJEg22eUaa9hzqWhjElE9I3a6SIlweGDoRB1B0nKmnh/KYPE2D0YLLkHWeruSx4ixL3b1Qh71G74ISDpXRCvojGL/jHCfc4XfApCWnVijtwjfIQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK2PR06MB3492.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(52116002)(2906002)(86362001)(6486002)(110136005)(36756003)(508600001)(6506007)(83380400001)(66946007)(4744005)(6666004)(5660300002)(6512007)(26005)(186003)(316002)(1076003)(2616005)(38100700002)(38350700002)(107886003)(4326008)(66476007)(8676002)(66556008)(8936002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pRxX2MYb7oZRT0fYfQzfWtwMHDsp+fk2PqyTv/3zzeQxWPwG9qrz8PkqLTZh?= =?us-ascii?Q?v5zKJ/B0/i2+w8E0M2uTnlj+HBJts/SqnUrwqaW2TYZmLaOFEhj0S9T9Q6jK?= =?us-ascii?Q?5s6s3dEnssWLeX2954qDBcEKBBRNWbtIc2QI7nHNfece2Pxf0xU4uh+gdoXE?= =?us-ascii?Q?kGfZu+TZ7b1u6a8cQF0LisSEaSzyHvJ8DSsX74p3miOQxBRn9+9rE5KJDpf6?= =?us-ascii?Q?HQrB2A8fJaqFmtRoBkLd01Uim+oVLWcO4KQeusijazek9Bt4xU/VXlA7uJJa?= =?us-ascii?Q?R6w9CpQHz4zOBU0H2BO33Hymg2vRjQ0XZGR4WX3NVHilZYkWq+e0BqX0H/SL?= =?us-ascii?Q?hULybdp9sbJkbHtYEh8XMA+hJCgfYl1QG4uR5d5/utKTcJYX/lSa0iqdUhBO?= =?us-ascii?Q?V6KXkWEZxFtQeJGT0V9jgp0EsH+Hm3D+7ATjT3qDhaELUh985wge9h0jsiHi?= =?us-ascii?Q?c+57QI0oLWsFy9mgpdg0LFO//gZErVlFslkllDgC4asFNzQXHi2/8Acd/psq?= =?us-ascii?Q?zm9a5e52k4RYFhsppyma7c6uc3pa172iLtdIxB8E8dghcmuPVZDQjpIyiGY5?= =?us-ascii?Q?7e+iskmVoqbFyZp1/WCWMXlevXUm97tM7NCOmrk+C6Y9N9nPelklBGS5f68m?= =?us-ascii?Q?8N8fUGllgaxwXXeRRZGauiSbuiFQls8wD3lLCHx075VslOoHcRQ9QE1wucJx?= =?us-ascii?Q?+nfry3EQmSFww8BYPSLuOqioKd7cuwKPehJw1Ue07pnCHaEpsfqOpKnpWLX7?= =?us-ascii?Q?spsFb6cGhGG4GG5CqpTD2Mnle96mvPzfp4yoyhOb9cApCywXL+uiLQ/XtFeN?= =?us-ascii?Q?qPODuKlvivinjqsB2I9ly616ckrVk7iVZpto3qjjy6LuZVps5mCkE8pUAfY/?= =?us-ascii?Q?ecmJmTjp7s0Y225M/osiOmQLveF7Id+sArzPRUHWFxtP896g+ZVLrzUPgMMl?= =?us-ascii?Q?y1ZihTrPmUpAdDM+BbrJxZWEXdcwS4CGXQd47d6KhLkb0x5g/RnZqiZanr0b?= =?us-ascii?Q?746T/7gDoofjeAyO/b6Kta7d0xayQTVH8vKQW5O1A4w1a6DqFOOQynDoSYa9?= =?us-ascii?Q?32paR/WWaDo8Qx+dY1dFNEUDmmtvmsHfkmct6qL2npYhiXTd7I1mJyHLWguW?= =?us-ascii?Q?AYtjPijrGyxEH7uWXctlxr8p1M1rKPWV5MtVeyO5AldDxvqffcbOxbMrnzSR?= =?us-ascii?Q?hzbCwdTtjV6+HOiQNYal8CfrQHfPVw0NJeeu+yhiK55wLtH3Urd0WM4LKZ3M?= =?us-ascii?Q?xqhZMMfI2N2gd+BR/OdsU2QrbIH5V/ceZ+E/T916zyls7ZAfGmvIgDvFWkn1?= =?us-ascii?Q?xrfIgLJTndpxFUlOJx3eS518svvs5l9fDSG22yeU7hWWGOM636WflsLkw8cD?= =?us-ascii?Q?EtKFC6cQU56L6Wpmz8XAVOBtNbU0v6OX8wMH8p5P8wVBy3kt7rHak+GR5zu7?= =?us-ascii?Q?8/48M9tlIdiSGbaP4atASU7z7uiV5ZjznDeu/UoKZNF8/5XXcnZMbgNhFPfc?= =?us-ascii?Q?Z1JX5Sd+ptNDKgdkpyK+Kxkury28iIUGb48s7IffyIcnCbrKFsE8nrJRCe3o?= =?us-ascii?Q?n/1PrJk0tjtqF2vkprLFcDWMTwtIN2oo1QtkJfizFcJkd0B/366YqKn4mzeE?= =?us-ascii?Q?M8hU+ktpr0ErSK4kcFYHLyuNk1oYnOSg9S+5+OOhKKHPBdZ8cyWK5b6agzhM?= =?us-ascii?Q?dOoFTN7AwqWRflvyGUiTkCseVo9Sn9swdRx/mEZs71dC/8QuJBOw6OwbKrA5?= =?us-ascii?Q?G2MTVPzuJg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c606c30-4812-4b96-1f66-08da138bb8bd X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 03:00:05.0099 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sz8QHDhYUNjz0X+KVfTdPgoMM869RirOrewyFx+pQ6TdS3xB/FtsCvpJlnNuMCIciUBZiB8SaEOc4aETMtL9qA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3904 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace `if (!ret)` with `else` for simplification. Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/radeon/radeon_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c index c67b6ddb29a4..e765abcb3b01 100644 --- a/drivers/gpu/drm/radeon/radeon_pm.c +++ b/drivers/gpu/drm/radeon/radeon_pm.c @@ -1629,7 +1629,7 @@ int radeon_pm_late_init(struct radeon_device *rdev) ret = device_create_file(rdev->dev, &dev_attr_power_method); if (ret) DRM_ERROR("failed to create device file for power method\n"); - if (!ret) + else rdev->pm.sysfs_initialized = true; } } -- 2.20.1