Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Jakob Koschel <jakobkoschel@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>
CC:     Lars-Peter Clausen <lars@metafoo.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Subject: RE: [PATCH 1/3] iio: buffer: remove usage of list iterator variable
 for list_for_each_entry_continue_reverse()
Thread-Topic: [PATCH 1/3] iio: buffer: remove usage of list iterator variable
 for list_for_each_entry_continue_reverse()
Thread-Index: AQHYRVQV9kI4j3Bv9UurRvFtBWTQEaza/lWw
Date:   Fri, 1 Apr 2022 12:40:59 +0000
Message-ID: <PH0PR03MB6786326401D38B60141CAC9799E09@PH0PR03MB6786.namprd03.prod.outlook.com>
References: <20220331230632.957634-1-jakobkoschel@gmail.com>
In-Reply-To: <20220331230632.957634-1-jakobkoschel@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?EdPnRW06KdR+SF1fK3ke/z/5GLoYSIj6xQo0VoGtb21pbdwtTZkM0l1nVO?=
 =?iso-8859-1?Q?XrNMg1mivbRHfQtCZkXjiJvCM8DMfUyCOWA1r0Yvulc7meykNcQpEjmeac?=
 =?iso-8859-1?Q?5r1LtCpAd1b9Em5WgUU58te4Bfat4WUPSfbuIGKuDiIi4oA73Ddu2eQkpU?=
 =?iso-8859-1?Q?tpRe/NroVIpGjDFC0B4LIoSXN1Yt24B88KA5sY6m6dnno9WVM1NJlNZHym?=
 =?iso-8859-1?Q?Fiy9S5PsJrG9Q2lsL6ZWnc96vxQNxzPP+UQKGxNDOA2xuOHiv3/pJDxfjP?=
 =?iso-8859-1?Q?X3uFxb9cs83GF7nsljZ4WFCKaRLctrU5wOO8WuxkLj48LTxfyBTBwu0R/P?=
 =?iso-8859-1?Q?/BpFB0QgI/0N+dQAyZC2fPHw3I5t9hrtZOyo243vmaahoX89iDP37kPcHF?=
 =?iso-8859-1?Q?2VF7ZK/9W0L+T/D6p5WL6cv4XvzfRMqnDoSXdd/qGoRIBCdIGheoaLjOpb?=
 =?iso-8859-1?Q?lJUsWnOOo6mVxCio6vtp6Ap1Q27t7zbNZs+a2S6upp6W2ZqZzfpgihY2so?=
 =?iso-8859-1?Q?sdb8+oAGeCo7edGUCmsuf8wMpwzks7onDt/QGr/wwhPev5W+jL7BI7AeZU?=
 =?iso-8859-1?Q?2g1VDiWo8EKGpV/9Uu5mCnIYjlKxA1xX3gMNSFe0q20c1WKs72jnKzUqTw?=
 =?iso-8859-1?Q?dl+T7DYCEgovy38au+V+q83If7qJA0EQsz6M4lH+cf0wZWb0rU4TSu9xq/?=
 =?iso-8859-1?Q?YBLQIr55aKjqNdK8F9kPw2ldDMiaJjlTyVjTPc10+t7hcweA5ZeyWTmvH1?=
 =?iso-8859-1?Q?/Mhq91ylCu9JzpbSQ9OhyiGeuM2yU183pmXDJbltq4uzSa+b/YB+KwS7rh?=
 =?iso-8859-1?Q?wFtK3VllezQTLTmDvwRpQ6FRCQOTURw0pshTipglFo0OW1U9oyap553Yh7?=
 =?iso-8859-1?Q?dMyYM/U26h5PgTRBQGVDDczmQIa7IFm5IveGyBVzp0H11x47zVTNia9ph+?=
 =?iso-8859-1?Q?XPUWF1/+udvSvW8ix4ALPHzXmO3XwVO4N/Tg27Mjt2S/BIu+J7yk2XjrOb?=
 =?iso-8859-1?Q?m3dNvJWFkdXs8Q6ep0GHFNFvAqpi5b9N8YeSfrSpqP519XdaQ+fYYhPXij?=
 =?iso-8859-1?Q?CdNbr2WOAuA9MXCSgDkpfBU1dfu2BbOZL5I7b7b2amB5O6fp0/28PjX9CH?=
 =?iso-8859-1?Q?fWNuqJJzv65/TZl/nFuLNnG9R1h4Um2k6lkM8ryNKxbdYUg7vJMtrpBPUR?=
 =?iso-8859-1?Q?ekPo8ribkjImuFGMb4GTcuP9MEUGJtDLk69jo+H+HI0E3ZoAMXowwAMkT8?=
 =?iso-8859-1?Q?Bhj10DpDWzsK5jTmMbi3pbc9XLjiyrPyyJENdXJin2dRKnaWSnWD+X0xTd?=
 =?iso-8859-1?Q?iVDbl10msIGb/FwIDjv4OVUhHPB7CN6bfV7JUjCEmm+el67Y8iWu868+9u?=
 =?iso-8859-1?Q?c+ZK9noAU2JSnywOoN//pgf+UnxB9/tQVq6KtZNH0grNyQoohfjEtESXPa?=
 =?iso-8859-1?Q?rEnZnWCZ8/cKdpcjNrqkXP7BPCIIoMscarNMxlLUyp5VIISBwQAVpqhyQZ?=
 =?iso-8859-1?Q?nskwhxCloJqsyBs2mzi6I67esEZXWQvRxs6uUguVCyoZjCtvnpOjZPQFpW?=
 =?iso-8859-1?Q?6nb5+/xsKhqB/8w+m3b2THDeY1I3fa/ZC0E2k24yykIn4apcRERvPKl91T?=
 =?iso-8859-1?Q?dUx0jgoxXR0uIJSSn+CIrhuA6aeBt5QZ0udv4JPqiE0WdG60Zu+AkKhrX2?=
 =?iso-8859-1?Q?nCZZXU1zReoFYIVdzebsr7+NQccpGZcMyg+JRhr9fDUczWnHzKNNHWQhG2?=
 =?iso-8859-1?Q?rEtZFCSHKi4dGAWK2iuGXc5BVY9eyl4iIOX6gnzzCtC8NoiIDzKHgfvPrv?=
 =?iso-8859-1?Q?XSb7ovqrZpWQIb8paBh9YJS/+h1umXp3Q0uH+FedAmQpfgJqbeNcopZqN/?=
 =?iso-8859-1?Q?WJ?=
x-ms-exchange-antispam-messagedata-1: GAzh1qj2+ZQxrA==
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6786.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82714def-b8be-4159-7b98-08da13dcdffd
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 12:40:59.6591
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s+48gm54PrQRR/DH9Ac9+FCe0ruh7nDHG9SSZT+MS83+g9jfplCPgqaneOE17wrkFrPsZ1iIucDwKZZwYHxocg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6960
X-Proofpoint-GUID: GStpuhScQVxBwzzzzDkJsktWEakTUCcc
X-Proofpoint-ORIG-GUID: GStpuhScQVxBwzzzzDkJsktWEakTUCcc
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-04-01_04,2022-03-31_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1011
 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 priorityscore=1501 mlxlogscore=999
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204010058
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jakob,

> -----Original Message-----
> From: Jakob Koschel <jakobkoschel@gmail.com>
> Sent: Friday, April 1, 2022 1:07 AM
> To: Jonathan Cameron <jic23@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>; Dan Carpenter
> <dan.carpenter@oracle.com>; Jakob Koschel
> <jakobkoschel@gmail.com>; linux-iio@vger.kernel.org; linux-
> kernel@vger.kernel.org; Mike Rapoport <rppt@kernel.org>; Brian
> Johannesmeyer <bjohannesmeyer@gmail.com>; Cristiano Giuffrida
> <c.giuffrida@vu.nl>; Bos, H.J. <h.j.bos@vu.nl>
> Subject: [PATCH 1/3] iio: buffer: remove usage of list iterator variable
> for list_for_each_entry_continue_reverse()
>=20
> [External]
>=20
> In preparation to limit the scope of the list iterator variable to the
> list traversal loop, use a dedicated pointer to iterate through the
> list [1].
>=20
> Since that variable should not be used past the loop iteration, a
> separate variable is used to 'remember the current location within the
> loop'.
>=20
> To either continue iterating from that position or start a new
> iteration (if the previous iteration was complete) list_prepare_entry()
> is used.
>=20
> Link: https://urldefense.com/v3/__https://lore.kernel.org/all/CAHk-
> =3DwgRr_D8CB-D9Kg-
> c=3DEHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/__;!!A3Ni8CS0y
> 2Y!q8llw5UCaMIsAU7tPtPDhwVor0wy032I7FJHv0VxBZksNuRJF04HjWe
> 0XYG7OQ$  [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---
>  drivers/iio/industrialio-buffer.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio=
-
> buffer.c
> index 208b5193c621..151a77c2affd 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -1059,7 +1059,7 @@ static int iio_enable_buffers(struct iio_dev
> *indio_dev,
>  	struct iio_device_config *config)
>  {
>  	struct iio_dev_opaque *iio_dev_opaque =3D
> to_iio_dev_opaque(indio_dev);
> -	struct iio_buffer *buffer;
> +	struct iio_buffer *buffer, *tmp =3D NULL;
>  	int ret;
>=20
>  	indio_dev->active_scan_mask =3D config->scan_mask;
> @@ -1097,8 +1097,10 @@ static int iio_enable_buffers(struct iio_dev
> *indio_dev,
>=20
>  	list_for_each_entry(buffer, &iio_dev_opaque->buffer_list,
> buffer_list) {
>  		ret =3D iio_buffer_enable(buffer, indio_dev);
> -		if (ret)
> +		if (ret) {
> +			tmp =3D buffer;
>  			goto err_disable_buffers;
> +		}
>  	}
>=20
>  	if (indio_dev->currentmode =3D=3D INDIO_BUFFER_TRIGGERED) {
> @@ -1125,6 +1127,7 @@ static int iio_enable_buffers(struct iio_dev
> *indio_dev,
>  					     indio_dev->pollfunc);
>  	}
>  err_disable_buffers:
> +	buffer =3D list_prepare_entry(tmp, &iio_dev_opaque-
> >buffer_list, buffer_list);

Ok, it's Friday so I might be seeing ghosts... But looking at 'list_prepare=
_entry()'...
If tmp !=3D NULL, then all goes well but if tmp =3D=3D NULL, then we get

list_entry(&iio_dev_opaque->buffer_list, struct iio_buffer, buffer_list) wh=
ich
would require 'struct iio_dev_opaque'. It looks like like 'list_prepare_ent=
ry()'
assumes that pos and head are of the same type...=20

Am I missing something?

- Nuno S=E1