Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sungjong Seo" <sj1557.seo@samsung.com>
To:     "'Namjae Jeon'" <linkinjeon@kernel.org>
Cc:     <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <sj1557.seo@samsung.com>
In-Reply-To: <HK2PR04MB3891BE0766FAF0AEC39FE2DC811A9@HK2PR04MB3891.apcprd04.prod.outlook.com>
Subject: RE: [PATCH 1/2] exfat: fix referencing wrong parent directory
 information after renaming
Date:   Fri, 1 Apr 2022 19:32:31 +0900
Message-ID: <818a01d845b3$cb1a2360$614e6a20$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQJSbKznm5dqk7yvnouxemc+9Ari2QGAI9zYq9qMO0A=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20220325094229epcas1p194e9008627d718a444253c1c7e58b2b8@epcas1p1.samsung.com>
        <HK2PR04MB3891BE0766FAF0AEC39FE2DC811A9@HK2PR04MB3891.apcprd04.prod.outlook.com>
Precedence: bulk

> During renaming, the parent directory information maybe updated. But the
> file/directory still references to the old parent directory information.
> 
> This bug will cause 2 problems.
> 
> (1) The renamed file can not be written.
> 
>     [10768.175172] exFAT-fs (sda1): error, failed to bmap (inode : 7afd50e4
> iblock : 0, err : -5)
>     [10768.184285] exFAT-fs (sda1): Filesystem has been set read-only
>     ash: write error: Input/output error
> 
> (2) Some dentries of the renamed file/directory are not set
>     to deleted after removing the file/directory.
> 
> fixes: 5f2aa075070c ("exfat: add inode operations")
> 
> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
> Reviewed-by: Andy Wu <Andy.Wu@sony.com>
> Reviewed-by: Aoyama Wataru <wataru.aoyama@sony.com>
> Reviewed-by: Daniel Palmer <daniel.palmer@sony.com>

Looks good!
Thanks for your patch!
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>

> ---
>  fs/exfat/namei.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index
> a02a04a993bf..e7adb6bfd9d5 100644
> --- a/fs/exfat/namei.c
> +++ b/fs/exfat/namei.c
> @@ -1080,6 +1080,7 @@ static int exfat_rename_file(struct inode *inode,
> struct exfat_chain *p_dir,
> 
>  		exfat_remove_entries(inode, p_dir, oldentry, 0,
>  			num_old_entries);
> +		ei->dir = *p_dir;
>  		ei->entry = newentry;
>  	} else {
>  		if (exfat_get_entry_type(epold) == TYPE_FILE) {
> --
> 2.25.1