Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932805AbXCAAAS (ORCPT ); Wed, 28 Feb 2007 19:00:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932806AbXCAAAS (ORCPT ); Wed, 28 Feb 2007 19:00:18 -0500 Received: from ozlabs.org ([203.10.76.45]:46215 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932808AbXCAAAR (ORCPT ); Wed, 28 Feb 2007 19:00:17 -0500 Date: Thu, 1 Mar 2007 10:44:24 +1100 From: David Gibson To: Andrew Morton , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core Message-ID: <20070228234424.GD3048@localhost.localdomain> Mail-Followup-To: Andrew Morton , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org References: <20070220031717.GI17818@localhost.localdomain> <20070220031951.56492DDD09@ozlabs.org> <20070228222630.GA11999@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070228222630.GA11999@flint.arm.linux.org.uk> User-Agent: Mutt/1.5.12-2006-07-14 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1362 Lines: 29 On Wed, Feb 28, 2007 at 10:26:30PM +0000, Russell King wrote: > On Tue, Feb 20, 2007 at 02:19:51PM +1100, David Gibson wrote: > > Therefore, this patch defines a UPF_FIXED_PORT flag for the uart_port > > structure. If this flag is set when the serial port is configured, > > any attempts to alter the port's type, io address, irq or base clock > > with setserial are ignored. > > I've been wondering about this, and it is questionable whether we > should allow any serial port which isn't owned by the legacy platform > device (the one called "serial8250", iow by the 8250 driver itself) > to have the base addresses and interrupts changed. > > IOW, we apply this "fixed port" to any port registered by probe > modules external to the 8250 driver itself, such as PCI, PNP, etc. Sounds reasonable to me. But maybe in that case we should invert the sense of the flag. UPF_MOVABLE_PORT or UPF_USER_CONFIGURABLE or something. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/