Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        a.hajda@samsung.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm,
        robert.foss@linaro.org
Subject: [PATCH v6 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()
Date:   Sat,  2 Apr 2022 12:03:21 +0800
Message-Id: <20220402040325.2465222-2-victor.liu@nxp.com>
In-Reply-To: <20220402040325.2465222-1-victor.liu@nxp.com>
References: <20220402040325.2465222-1-victor.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnJ0b05FeXhFSHQ5SjRyZ0prU0JIbUV2aDQyRTEvbmM4OG9ITEc3VWhNZWFP?=
 =?utf-8?B?QzRFWThYZ3NMbk9LaUxMS09mUjRqTkx0TzI1VEYyNXMway8wcURaRmZBMFhY?=
 =?utf-8?B?WFdlN2lRRTJ0akkrMWkvOGc1VW9PWFBpQVFnL2cxWXp2ajZ6MlViNFlQNDNp?=
 =?utf-8?B?WWhEYXRoZkNlM0ZUblY2YTNGdGhsS09hL2tPQyt3MFFMTm9kc3IrUmhqVDRq?=
 =?utf-8?B?TUJaRGZZbXhndGpnTjNGVHJIL2JNNWFla1kzdUFGTWpsdGxYaDlaQXdjYUtC?=
 =?utf-8?B?WWpTRUNYckJvRllqNWRsbFpWdnFUbkI2WkRrRDdIZGNvRW1JdFFwSlJ4OEdt?=
 =?utf-8?B?UlZDSjlkVFdEbWpXMVhVZHpISDcySG93TmM3V3FIalJSRjhJeEZJQ0FiNmd2?=
 =?utf-8?B?eXorMlFzNHZtcUdheEwrMWpVRitSTkNicloyUDNPM2FTYnIvSEZ2VlNqemYy?=
 =?utf-8?B?TnJ1M21RTG40am1TSTBrRjlKbWx5dWFiYkpsMjA0ZnZHYUZDRlRvYWZRQ1dX?=
 =?utf-8?B?d3lrTTBzNHRZTlZsb0FqbHJzSDd6NWJ6QnhUUWIvRjUzdDRUK3ZiMVFid3BR?=
 =?utf-8?B?Y2JZZDlBOTlvYWdRWDVDUENrY2RWU2o3RkpydE9GbHFpNXlDSHlkUTdCbXBv?=
 =?utf-8?B?VjlUdSs5NkhLRHFOTDgvNFEwa3ZFQjdBRXIyZ0Z2KzVMWmtiT05EQVoyRVFp?=
 =?utf-8?B?Z1p6QUptdVBxVi9hN3BWYTBsZTRSblA5MXlpNEVpSTRVZVd2cjR0VXRxQ1JW?=
 =?utf-8?B?R2txNEFFdHZXekxNcmFWV1FRUlJsWTRab0xZVkdxOUxLVG85aEU3dGE3MUc5?=
 =?utf-8?B?YlNzRHU4RjlkRnNmZStodkwvalljaEltUFExbmRaZGZtTFdaYTF4amhkNG9k?=
 =?utf-8?B?VGhvV2taWEw3WUJGSGJ4Z09DVVcwVCtpaW4xSUV5eFlERUVIOVVRdDlmYWhy?=
 =?utf-8?B?bFFKL3RnSXdvTjB1clB0SDEvaEo3SDJqRURHRDNVT01nSzZCbW9JWWlwdUpz?=
 =?utf-8?B?dlYrMFRPRCtsMkFJVHQrejNFRHd5amZ1eXVBYnhhYnBrN1ovTFFXY3JaaXRH?=
 =?utf-8?B?NStlSDlqUnkyUTVQMjZFQTJHalQxbmJVSzZTZmNyRU1vSGVuVjlaRmFzNjZJ?=
 =?utf-8?B?NU9HVjRZWHR4Yzk2VTBjdzVySXFFREsxMUJBdENxekhXRUVmT003YXlSTTlu?=
 =?utf-8?B?a202QWJhRVoxaE5pU3RteGQ5dnhVcUw3ZWhNRGphZ2hueEM2L1ZSMWtBQ09j?=
 =?utf-8?B?VW10N1hXMUwrcC8xblJ3MEVuUVpzZTZqL2dHMExqTU9uL3JZQlZhbElaUEg5?=
 =?utf-8?B?RmNUc2ZwbVZRT29XaG85clpzdkZFZUxvbkZ6YnZTeU92UmEzOWpMdndJc1pm?=
 =?utf-8?B?UDc0TWZBa3lkd2YzTE5rdHRsZFhqaENqbEdsVjNLa0JuejdGeFhxVUtxcnZo?=
 =?utf-8?B?ZzRUWFl6c2RnWkVmeWxYak1ZeTV2RXl2RkZIMlRzQkF3aXh0YUNFdWxrMm8r?=
 =?utf-8?B?TzhPa29zdFdBWVI5ZGVSam1aSHZaZlBqaFo4cFJmSTFNYTlzdTdMVTNEc2JQ?=
 =?utf-8?B?UmpTdkIxYVFqTUUxTHQyemM4ZXdFcHdSSEc1MEg2VnA1bnZBK2VDVVpJM3Nw?=
 =?utf-8?B?dHJTcXJXQWl2VkE1NXR2UTAzTkpvNHY3UE40di95dm9iSG5xbmVZdFBNRlEw?=
 =?utf-8?B?UzdxZndTTE00d3hOVU0vUllQdGFJcXZ2WTlBd2JrNUFMaFNEK3daenpVdEtn?=
 =?utf-8?B?TmxvVHJOK3p0dTU3ZTFYZ3VPU1gySHZpa3VTRTBFbjc5RmtQWW9ZT24wVlhY?=
 =?utf-8?B?VHY2UkpwZW5iZytiVUgrSklTRVM4UitXU2FLWGVlTFlFMkxZSUIxUlpaZENl?=
 =?utf-8?B?RzhzL1RROXZEcmo2Nlk0di9wSlNoZk1tZzc2Vjk1RTArYkpxL3l3ekdFTnV6?=
 =?utf-8?B?dEMwZzk0ODR5NlBGVVJ6bUZQYjBiNllXVEltOWI4M21ETEtNaVpGM0E1SE9W?=
 =?utf-8?B?VWJqSmlzK2ZkbXFPSDRpWjFTdGZ5eEFRclRZRDkvMzhKSXFzaHc0TDNzQ01R?=
 =?utf-8?B?NmxEcHZoQlJtODRkeEMxTVFVRUZyS3U0V3ByRndqTzluVi9aV3I4OFlldzhh?=
 =?utf-8?B?WHRwNEh0RWlldjRYL2FsMUsxNkZtb3IrNEZxUjY0NGhRRnlLNXJEeHJPZFpa?=
 =?utf-8?B?Q0piVGkvWDRwcGcyVFloenNQZm12YVFkU2Z2bmpRZDhhZy9OcmNrTVdvYW8v?=
 =?utf-8?B?UEdQYjRlTy9FcGdkRjlWR3Zub1Y1aEkxVms2ZVp3K1pxY2dHc2lDenVmTVRj?=
 =?utf-8?B?N285d2EybXJjOXJRTTBBMmZURmpZKzZWTm5yZUIvZW9ZWmlJOGdUQT09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f9c4514-a55d-410b-b8c3-08da145d8a6a
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 04:02:01.5309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bvf7ozu6VZ8OZ5D++N9MYyk1nIlbHQtpcKxwa2K/rG1xLcu6L09XG2ehqVlfa0J0xt4bSPP8br0DEksL3xySoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3210
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
works with a Mixel MIPI DPHY + LVDS PHY combo to support either
a MIPI DSI display or a LVDS display.  So, this patch calls
phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY
explicitly.

Cc: Guido Günther <agx@sigxcpu.org>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v5->v6:
* Rebase the series upon v5.17-rc1.
* Set PHY mode in ->mode_set() instead of ->pre_enable() in the nwl-dsi
  bridge driver due to the rebase.
* Drop Guido's R-b tag due to the rebase.

v4->v5:
* No change.

v3->v4:
* No change.

v2->v3:
* No change.

v1->v2:
* Add Guido's R-b tag.

 drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index af07eeb47ca0..cbe3edb17ceb 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -671,6 +671,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi *dsi)
 		return ret;
 	}
 
+	ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
+	if (ret < 0) {
+		DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret);
+		goto uninit_phy;
+	}
+
 	ret = phy_configure(dsi->phy, phy_cfg);
 	if (ret < 0) {
 		DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
-- 
2.25.1