Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a430ab7-024f-51a9-d785-07e03f163261@redhat.com>
Date:   Sat, 2 Apr 2022 12:47:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v5] input/i8042: Rework quirk tables
Content-Language: en-US
To:     Werner Sembach <wse@tuxedocomputers.com>,
        dmitry.torokhov@gmail.com, tiwai@suse.de, mpdesouza@suse.com,
        arnd@arndb.de, samuel@cavoj.net, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220329143622.31394-1-wse@tuxedocomputers.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220329143622.31394-1-wse@tuxedocomputers.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 3/29/22 16:36, Werner Sembach wrote:
> Revision 5 with some fixes based on feedback by Hans de Goede.
> 
> The 1st patch is minor housekeeping.
> 
> The 2nd patch merges the tables together. Minor fixes in 5th revision and
> no more duplication of ASUS devices
> 
> The 3rd patch add optional debug output to see which quirks get applied. In
> 5th revision this no longer breaks compilation on non x86 platforms.
> 
> The 4th patch adds a list of Clevo devices that need multiple quirks.
> With the reworked table they don't need to be inserted multiple times now,
> which was required in v1 and v2 of this patch.
> 
> I also included the extra quirk for the Clevo NS7xMU, which was a separate
> patch before.
> 
> The added Clevo devices are now only identified by their board name as this
> is the only somewhat reliable string that might not be changed by resellers.

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans


p.s.

In the future if you get a Reviewed-by to a previous version of a patch
and the patch does not change (or does not change much, e.g. only
small code-style / comment typo tweaks) you can keep that Reviewed-by
for next versions of the patch, just copy it over to your commit
msg and put it directly above your own S-o-b line.