Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Apr 2022 12:42:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     xkernel.wang@foxmail.com
Cc:     gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        florian.c.schilhabel@googlemail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8712: fix potential memory leak in
 r8712_init_drv_sw()
Message-ID: <20220401094248.GT3293@kadam>
References: <tencent_0A1273526E1E87150578F8B752CF7F178806@qq.com>
 <tencent_F3B552EEBF1CC810B36CEE23070BC54BF806@qq.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_F3B552EEBF1CC810B36CEE23070BC54BF806@qq.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7Rj5xEZU1XJoyR1GlgqZo43zBEbEuuyGz6S05US+bZi25Vj+aMPdwWN+XxPb?=
 =?us-ascii?Q?0hxFl+8JzJpw/l1ACIzUU3oJYY45jLh8YEySh9twCLlflrEWFZZRbUigIe2m?=
 =?us-ascii?Q?c8sQHFJGaqko3+p17uq1fPCfhT9Cvqi4Nz1u88b/MGxUAOUECHYod3+iq15D?=
 =?us-ascii?Q?0ZGZPYOJQB8Pjg6V5xBQZewyt8Z7tocTvI3GgfWcvQFAgaFoqimz+ZH1PuNH?=
 =?us-ascii?Q?VQP0KV1/5+x3OGQqdMl8HIsQQAtHb1Se6egy23rgCuj4VQKqQl07ZXxwQv1j?=
 =?us-ascii?Q?o/LhBRKlBpcpHWu1XWLXylI6G1ei/pbfFlN6VF1NcN4ekfe+MezGhY2aUqXA?=
 =?us-ascii?Q?9tcLaob5kZBkk64wCEkeHP/J6mgVZdSjOYkcyMozsvJIecYJuOfK3CQy5gyW?=
 =?us-ascii?Q?mN8PwWtPy+tzTgLPC1T6mELeeNh8TNoCCjdFz0gnBOQ4Bl5bibLiydzkVPYu?=
 =?us-ascii?Q?m9r7+gTxLyQzFyQwU0144sFxCvKePFEAZp3sVDLBQFp74RYXYRzNBVH6ambF?=
 =?us-ascii?Q?I8HM8sp4QQjg0r+Q2kH8f1YpqK6Xcu/PaABk5ZFsAasTn7FAAlHAxPc5BOKx?=
 =?us-ascii?Q?l9sZw3cDhCxsvfiaoEhS3VvWeNYcBic4OI9gZDk7vBaC7a6Mf4UBm9zMRjHW?=
 =?us-ascii?Q?bHZjWhz6BUMn1Bv+6mAdrl6DzUuR37X7IsLt0kCALkUpYduHQuN8pEI/qlNx?=
 =?us-ascii?Q?iy5s6Z0qj4OwA/e5aHWMzoEK9Jx7VFOz1asEI7LB1ciElmCy78YvxXmergM3?=
 =?us-ascii?Q?uxoI1QOQ4G4vhefjQWycPlhVJkENfyma1FakZx9F+uR8wXfTxX0SLHdj/toU?=
 =?us-ascii?Q?ZHd90eE/AFRY29K68OQwInxAHvFefbepKIVaAdW2iP5oPzEPxJG2il0rVEUM?=
 =?us-ascii?Q?EefrX8KEOpWVUgY3Y4SS7J0LY/KNOF3vxFQ6RcuINJ5qouKDtgSTsUm668mS?=
 =?us-ascii?Q?uyh+LqTiZTlahx7FxbKZNUKpKgtSZP3mPxVYbzlG8LHaAEYaEkkCfoJ052MS?=
 =?us-ascii?Q?5cC2dvgXF4gEOFX9FRP4V/BSnk5vItcvFdriUSV2KsBwCfFGf1r3b3ZMrWlR?=
 =?us-ascii?Q?muRICTlsmBchF7SKRhFdIXNYcf28Q+uq5LF25kphL4/6gFLySiKjbEi9RLF8?=
 =?us-ascii?Q?2hGzKOj8SC3KcfWueiEr+1qeThBvH2BFwqamfeu7LUtv3CsZH91KjtPKPy8q?=
 =?us-ascii?Q?B1DnucBnZOYv5fybWm0e/Qj04LQtRxFO1YmTHCfn4nS/dUdaJYwIxT5qUugn?=
 =?us-ascii?Q?VlqCUZ6sjKdMBJ504MGWuVjFvbOZWr/nL4bWh7c+CK0Pbm8mhjjlflb1hgtv?=
 =?us-ascii?Q?JgNU7cQ2GH7KUyWKVI6+q1g71ibUZazJ3wDgsuNXKY73bMf5B4vRXhfPk2DY?=
 =?us-ascii?Q?X03TUVbX/VlILikr/OlvKGVyGkfuLf2hCjloICY4A76P6mP6yILhbyDQNYm0?=
 =?us-ascii?Q?gkC2FOTnVszk0+WyRzj60nZqnK9+MfL4EYHnLQcrCySBAL8VA/SL8m9gmaI3?=
 =?us-ascii?Q?i85WxZDEY8ITDEhCD4g2u+UayrK3mp7Adsvz2gtC7Kp3y8Te+xEqfYdofEA7?=
 =?us-ascii?Q?wIvxMfPA0cc5OGtXroTxNS4glWrapxhdyq13ORPhKu12f1WlBkVxefO+KD73?=
 =?us-ascii?Q?/qn9i/I5incxMyf0FOWjL9oztp5xuqnKyHaml6I5k7uaSHJc5Kep50PrW3wM?=
 =?us-ascii?Q?eoMdyWNzHUhdxRW9khh4xUqg9Fwt7CKvcFK7VzLGTpIzNi8MvleYlVU2hpgy?=
 =?us-ascii?Q?9mbB4zVznprOt3jue/q+hD2Jovj34lw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7970056b-14ba-4f37-2ca2-08da13c40716
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 09:43:08.3351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FhNt420xipNFF9BE42z7+k9+qzKk/mp8MOI97lGYrOctNXN1IvxBPyHtQzHlm8h787TIPXcZni05EZf5Go0uIXzoZ65efRi35VRJlnwmJsc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5721
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-01_03:2022-03-30,2022-04-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=851
 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204010043
X-Proofpoint-ORIG-GUID: DCacM2kK7wnJ9QuumBhcQ1BBW52NkURX
X-Proofpoint-GUID: DCacM2kK7wnJ9QuumBhcQ1BBW52NkURX
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 01, 2022 at 01:08:19AM +0800, xkernel.wang@foxmail.com wrote:
>  	ret = _r8712_init_sta_priv(&padapter->stapriv);
>  	if (ret)
> -		return ret;
> +		goto free_recv_priv;
>  	padapter->stapriv.padapter = padapter;
>  	r8712_init_bcmc_stainfo(padapter);
>  	r8712_init_pwrctrl_priv(padapter);
> @@ -328,6 +328,18 @@ int r8712_init_drv_sw(struct _adapter *padapter)
>  	init_default_value(padapter);
>  	r8712_InitSwLeds(padapter);
>  	return ret;

Not related to the patch.  (You didn't introduce this, so it's not
something you need to fix.)  But this "return ret;" would be better if
it were "return 0;"

regards,
dan carpenter


> +
> +free_recv_priv:
> +	_r8712_free_recv_priv(&padapter->recvpriv);
> +free_xmit_priv:
> +	_free_xmit_priv(&padapter->xmitpriv);
> +free_mlme_priv:
> +	r8712_free_mlme_priv(&padapter->mlmepriv);
> +free_evt_priv:
> +	r8712_free_evt_priv(&padapter->evtpriv);
> +free_cmd_priv:
> +	r8712_free_cmd_priv(&padapter->cmdpriv);
> +	return ret;
>  }