Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sandipan Patra <spatra@nvidia.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Thierry Reding <treding@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "digetx@gmail.com" <digetx@gmail.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
        Bibek Basu <bbasu@nvidia.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources
Thread-Topic: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources
Thread-Index: AQHYRbY4CHAhw9BDf0Sqw3zUKbkBBqzbEcSAgAAMX6A=
Date:   Fri, 1 Apr 2022 14:33:12 +0000
Message-ID: <DM5PR12MB16289B09CD1A9CF4E9FAF098ADE09@DM5PR12MB1628.namprd12.prod.outlook.com>
References: <20220401104935.9149-1-spatra@nvidia.com>
 <YkcBt74odxdoBlQ3@smile.fi.intel.com>
In-Reply-To: <YkcBt74odxdoBlQ3@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mHFe2/00Of9YT0Zq7CB0xreEUceIIhgoE9luAX+DuL/QHA9HW+FpPpTU13M1?=
 =?us-ascii?Q?HC4eTAwWwu30FbcCPvan0jmwPFc0xxSEZRMXLZFtGtiklLnIiPOznSZGDeV8?=
 =?us-ascii?Q?DXf3vxgN2i/tK7Xs8imIsUUH4dNWptQKO+wXwvvfdHgzGmg58rPoQksY38ng?=
 =?us-ascii?Q?d+hff/mrKEnvnB8QxYTwm/u1TtmetvShpCv8yrWaUrTL9Dd+PuDkNtgaPl84?=
 =?us-ascii?Q?jVKuDlQqV7xbjsL+VZgzTCOUcuGXdnqIu0cBqowt/zyOA9dMn2PSbt7zWrMT?=
 =?us-ascii?Q?CWohmJqL87/+WNehK93zL6Efuss+HXp6trXq71D/Euo49VsAbjgW8GvCpZEO?=
 =?us-ascii?Q?LaibcTiVo6iZjXy9J2w5dYobLhsQ0vxqgr+K8o9SN9vYQLIcKjObcaqKz+re?=
 =?us-ascii?Q?tScD4Aj64W4f23CFbgGbOhcMPdpIcMSGDoBQPPIVEpL2WAyUGAEcoOfU9Ggl?=
 =?us-ascii?Q?ICWdatbRzc0u+rfDIoM3x6tl8A5YVad9NG5V42LhNXv8vl1aC8rr3B6J1Ufo?=
 =?us-ascii?Q?xVdaSLlEfeTrTq7BywpXGQC1+9ujEH0eYrGV0e3VPRyxPRm62o/kdHf/40Rg?=
 =?us-ascii?Q?1cxAfMag0BFUrei9fEmyI1mT/EhJ6S6du1gvbdNz0G6xIUGCkvd2LBASH26b?=
 =?us-ascii?Q?vx53vr6w/kCjujtbCzL5byp4tgE4eDm7lDkBbiw9jagwlDr3H9+UGEoycrcE?=
 =?us-ascii?Q?DdtqhGwc6hjb+Oi+OT18s0Y6evspWrYuSkF4yQLrLIoVhqg7laa0/iaPGITR?=
 =?us-ascii?Q?npi0yS7ZouDsFuQZQ3NscdFQfPgguZEE93JXuJNQxUGxYNC2W8UQhTxp0oPl?=
 =?us-ascii?Q?jgVKnFbTPR3TjLvUrL5j89pcHoXlbWu35+D6hepwbCmnYTIN2rSwDlauj0jI?=
 =?us-ascii?Q?3HnRDc/jhwH+asVTJM7++GmWfwAHR+1bfGorr7EuUKVcmBkZO8RxP1IuDhkY?=
 =?us-ascii?Q?zntfEenVhI2iaqHR6rjDJ9Q4kMpSgvos3V5DQMXZ0Ss3hA9L6wXAyXOHfQ3T?=
 =?us-ascii?Q?s5KLu+/p4mDLADKQHGYrEsZ899FHydE/Sz3LAbwk6ZYa7XkFNZxNoXdjfdRd?=
 =?us-ascii?Q?WrcrA9eRWQqzWmTknZ0oW5OrO+UxIS8wXiOAUMIQimhqcV++A4c9+uNLOiUC?=
 =?us-ascii?Q?vrcsN9AkhtgnPAAPn8H77ExWCTrTOBD+XSR6BOTUXq06NNnrV3+s5DBFR3h2?=
 =?us-ascii?Q?FbPRlH933EgUGOzZYMjQKlNzdAEDR/q5Oyq1jOc2nTYPxAcnT3507FRYJMuw?=
 =?us-ascii?Q?fQ3JNPealKHcim2+JrOkB0WvOzTvgGmeTagOAgJh5wXuJ8i2z+JWCEhO6xxW?=
 =?us-ascii?Q?0B+UxShQGqCnIu/FrT3OX4sfwbRaRwbzui1UhT5AcaIQEgHpU5c0cCZZghow?=
 =?us-ascii?Q?K8Fg7hM16cJsdwKlyoVGA7S2jXM0TzeKXqpGMcoUG0m7G+ffkmrONgSDUxDu?=
 =?us-ascii?Q?HWPCFa0LhgkoBcnC3SULjl8ufkkMDIBtOKR1mZzpLBspYUh3c9uYpY0WUtqf?=
 =?us-ascii?Q?snp1Z3ARjiqj/xgLWxp1IUg2c2PJH2YLkYm4EKzXfytlItEyQwgAO/mlsLKo?=
 =?us-ascii?Q?IEZ4OxwQI19UXVT4BCNSixc4639z7juz0TdmB/zNsZAupOfgzuNho7kfA3lU?=
 =?us-ascii?Q?XidifSsSnLGk/GeYcEte9vWdroTaPRXLq7r9Ed6QVxjB/64T4uaxvTvKacpA?=
 =?us-ascii?Q?pRwPKar4XngzRFUcaY6bTcPYDR4YHsgS+I8IgyDuXK+IU4+3?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1628.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5523f3a2-8db7-4270-e95b-08da13ec8cf1
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 14:33:12.3595
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZemVha34S/7UcyZa8teevOwcZJMrgkjP5AdNc2rREVfWK+uXGXhPjbUUOqKMn1nWsEsQM7I1RDbiHbKJI3zyGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2947
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thank you Andy.
Pushed V3 patch addressing recent comments.
Please help to review.


Thanks & Regards,
Sandipan

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Friday, April 1, 2022 7:14 PM
> To: Sandipan Patra <spatra@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>; Jonathan Hunter
> <jonathanh@nvidia.com>; digetx@gmail.com; ulf.hansson@linaro.org;
> cai.huoqing@linux.dev; Bibek Basu <bbasu@nvidia.com>; linux-
> tegra@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> On Fri, Apr 01, 2022 at 04:19:35PM +0530, Sandipan Patra wrote:
> > Reset_sources list is updated to add all reset sources and removing
> > ones that do not actually exist.
>=20
> ...
>=20
> > +     NULL,           /* 0x10 */
>=20
> I would suggest to add the comments more often, like every 8 entries.
>=20
> ...
>=20
> > +     "FSI_VMON"      /* 0x25 */
>=20
> It would be good to have comma here as if this ever getting expanded the
> additional churn may be avoided.
>=20
> >  };
>=20
> --
> With Best Regards,
> Andy Shevchenko
>=20