Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
To:     Jani Nikula <jani.nikula@linux.intel.com>,
        Christoph Hellwig <hch@lst.de>,
        Zhi Wang <zhi.wang.linux@gmail.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        Zhi Wang <zhi.a.wang@gmail.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from
 GVT-g
Thread-Topic: [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from
 GVT-g
Thread-Index: AQHYQHGFbzTs9dpVNkulZ3C9zD1FsKzUXz0AgAS82gCAABTDgIAB4qaA
Date:   Fri, 1 Apr 2022 13:12:54 +0000
Message-ID: <2817b81e-df97-fe03-4ee6-59861f4258ea@intel.com>
References: <20220325175251.167164-1-zhi.a.wang@intel.com>
 <20220328065008.GA29798@lst.de>
 <4af59d97-b583-4022-3ec3-360e7df43689@intel.com> <871qyibkay.fsf@intel.com>
In-Reply-To: <871qyibkay.fsf@intel.com>
Accept-Language: en-FI, en-US
Content-Language: aa
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?/b8VO5AHYa8hOaq5hbnfILImKw+nV6Rd1v8BBK9rUTA4pE+/txy1SLRb?=
 =?Windows-1252?Q?gv4qV1lM/tqd9fWpqXtFmKJ7Zbx6UHLTifgAncoyLqDPdHQvIdx6NnFy?=
 =?Windows-1252?Q?/JllWkcaS4WindnCZNSCw9MvVAIyqfTW8dVy3UmjABrSniiUelwbHz26?=
 =?Windows-1252?Q?yy9ylTU9lmYZZC+k61eyPLE0XlMn44RgXE1v8k0+ZOSHZAJjJqVu9npZ?=
 =?Windows-1252?Q?4hfpYjDgR95IPo9iTbpI9+Jt9lRxjT+LFamor3DqQZDLmmSNoz+JukXI?=
 =?Windows-1252?Q?H6mTYSBGR+SSDdvwAEUWPqaNkbEJyiTBjQW5T6tf9N/pjDNcRwXoS892?=
 =?Windows-1252?Q?brn26BabRwSk598bl+VKc2z7gzsgwYmSUul8C1l7j9nsB2r9/hLHjcbR?=
 =?Windows-1252?Q?SZ9yzF0jK7hUf2km7Vd331n0K9BgYVtgxdfDUHVdcfTmrAusjfp8grrx?=
 =?Windows-1252?Q?fNvxzhNcuDDRkydabkoygOgUDrATHHhb25mOVYSD7rGlVMvKZaDVAkm+?=
 =?Windows-1252?Q?Mjc5WVwcoXI+xn3DvuO2LIL74V2Lq+xlDN4VTV3cBugzC5ETDUO84H6x?=
 =?Windows-1252?Q?jsn4TrMUv4qC/buDXLQQUmscMWbjnGgxVDHtYkApLFEJONVkvX5456Ta?=
 =?Windows-1252?Q?HPztM4+FbXYONkhaWdbXvMkOJJySxpkd/pc1Sc2e+NtJ4sHlfOap4pcP?=
 =?Windows-1252?Q?FEuFWLQQ0P1Lhti8ObQp6wFJMywFXN9YYJW46JowZbmyr1Yi8SrnyADV?=
 =?Windows-1252?Q?xkQWqLIrC2HjTrTHDmhkyxOeWUUTzcE95UwP5HHCHJbnr94UoJPB/hZQ?=
 =?Windows-1252?Q?XaYEswpnu7jmOI2fWNdxlCMGA33o7Bli5w4uU6xDLB1LyJ/Z9LUdtPLN?=
 =?Windows-1252?Q?ytc2iNDiEBHzjqpERs1kOpjPjqSEwcxHkw2+UGfc/JnCrDrUuicHBHnG?=
 =?Windows-1252?Q?VrvsNjv257m+HM5d6djeDAMklkmok+mCk66X3O/miIu84JDy5CKlOg5w?=
 =?Windows-1252?Q?B01OlF+oM+FT7Hq9ih5LBbBRoianvEqrEGSOXS1NxKNujLzIi3xYBJ+N?=
 =?Windows-1252?Q?IzDHMArSSEIVlmLNmWibYWBZZa61Oqe1Ivk0xYVYfbZbVotvSqd0gSsx?=
 =?Windows-1252?Q?nQt7IH5DwHZ2SaeC5aLIS3r8Hou9ZTAquv6kvuNMQ2wCmaJi6NOI+vGK?=
 =?Windows-1252?Q?XphTEwNMd47xYzoaGgIXHuftR8AyjMIhUOyOuo4MfPd6wQ+qxv+Eg7eh?=
 =?Windows-1252?Q?60+CTWMn4Uy2siE6WRwOKneSlCB6DB1Zzz1o8GiPjL3cDQRnYVeiqr+f?=
 =?Windows-1252?Q?lmvLVLhNouymCexaN81+PiaUWpF9BRmCZPiL55FmzB7JiS+x1ph4jBF4?=
 =?Windows-1252?Q?+AW8/05u4HrbjtsKUJLY9WcuB0IwsnMDQQJrt/cPaa/fngL7oBib/BaI?=
 =?Windows-1252?Q?07fb6oAbPfq86UbQDOtOuZbfISEohnjqxqh834VWydNOEeHjf6T9Hsbw?=
 =?Windows-1252?Q?0bvtDbks1CEptIbUqrf9DQ165bPjk8zZMTLHh0EdXBZHRQVfroNnrE/n?=
 =?Windows-1252?Q?Dyv7UWwiCcTTCcB58Ftx6XyBGJp4IegKJm9RN85ELN6R0aU0d5bk9p8D?=
 =?Windows-1252?Q?BWTkHRtVWsUdsqB3KCWdfCxOAagtBEEWcNhEI9D012DHQ/j8YMrFyXU5?=
 =?Windows-1252?Q?pH16ul8S772bi+qa3QMbLCjlby4yHYGc118UP6xdkLjAwV61wIOnxBIc?=
 =?Windows-1252?Q?mPyAjUNufXYUk6DGPl5vNznXT5XCFwJy2bDyareHC9D1eAclrPUPGrer?=
 =?Windows-1252?Q?GmCVDO0ruIaGzV8+vMzpieXcIFCxmc61gRD2LaLFlyxEbEvYNASOoftm?=
 =?Windows-1252?Q?FPqvBFmaIfM8kg=3D=3D?=
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <668DCEA50334564B8EC4049587D44C7A@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3c695b6-e5cb-4c2f-0bc1-08da13e1550e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2022 13:12:54.0649
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: m6IexrAZPdzN0gPJ+o+D8fmxL2txz9/QzDfYHhQ5aMXZprtDPGH1MvhRYdzxh7ng1ayVioUnof2wVcrXwgbM3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4670
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jani:

Thanks so much for the guidance. :) I included it in the v8 patch. :)

Thanks,
Zhi.

On 3/31/22 8:25 AM, Jani Nikula wrote:
> On Thu, 31 Mar 2022, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
>> Hi Jani and Joonas:
>>
>> Are you OK with these patches? I noticed I need to change the license
>> of the new file. Will do that when check-in if you are OK with these.
>=20
> Use SPDX license header instead of the full text?
>=20
> I don't know much about the actual contents, I'll leave that part to
> others.
>=20
> Seems that you are dropping const in a number of places where I thought
> you could perhaps retain it.
>=20
> Also in drivers/gpu/drm/i915/intel_gvt_mmio_table.c:
>=20
> #include "gvt.h"=20
>=20
> looks bad. It should be "gvt/gvt.h". I realize you can do that because
> gvt/Makefile has:
>=20
> ccflags-y +=3D -I $(srctree)/$(src) -I $(srctree)/$(src)/$(GVT_DIR)/
>=20
> which I think should be removed.
>=20
> I sent patches fixing this to give you an idea. No need to queue them
> first, I can rebase them later. But please make sure this builds without
> the ccflags.
>=20
>=20
> BR,
> Jani.
>=20
>=20
>>
>> Thanks,
>> Zhi.
>>
>> On 3/28/22 6:50 AM, Christoph Hellwig wrote:
>>> On Fri, Mar 25, 2022 at 01:52:49PM -0400, Zhi Wang wrote:
>>>>
>>>> v7:
>>>>
>>>> - Keep the marcos of device generation in GVT-g. (Christoph, Jani)
>>>
>>> The changelog go under the "---" line (also for the other patches).
>>>
>>> Otherwise looks good:
>>>
>>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>>
>>
>=20