Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Apr 2022 13:18:06 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Xiaoyao Li <xiaoyao.li@intel.com>
Cc:     Isaku Yamahata <isaku.yamahata@gmail.com>,
        Kai Huang <kai.huang@intel.com>, isaku.yamahata@intel.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jim Mattson <jmattson@google.com>, erdemaktas@google.com,
        Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
Subject: Re: [RFC PATCH v5 008/104] KVM: TDX: Add a function to initialize
 TDX module
Message-ID: <20220401201806.GA2862421@ls.amr.corp.intel.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <b92217283fa96b85e9a683ca3fcf1b368cf8d1c4.1646422845.git.isaku.yamahata@intel.com>
 <36aac3cb7c7447db6454ee396e25eea3bad378e6.camel@intel.com>
 <20220331194144.GA2084469@ls.amr.corp.intel.com>
 <d63042a2-91d8-5555-1bac-4d908e03da2b@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d63042a2-91d8-5555-1bac-4d908e03da2b@intel.com>
Precedence: bulk

On Fri, Apr 01, 2022 at 02:56:40PM +0800,
Xiaoyao Li <xiaoyao.li@intel.com> wrote:

> On 4/1/2022 3:41 AM, Isaku Yamahata wrote:
> > On Thu, Mar 31, 2022 at 04:31:10PM +1300,
> > Kai Huang <kai.huang@intel.com> wrote:
> > 
> > > On Fri, 2022-03-04 at 11:48 -0800, isaku.yamahata@intel.com wrote:
> > > > From: Isaku Yamahata <isaku.yamahata@intel.com>
> > 
> > > > Add a wrapper function to initialize the TDX module and get system-wide
> > > > parameters via those APIs.  Because TDX requires VMX enabled, It will be
> > > > called on-demand when the first guest TD is created via x86 KVM init_vm
> > > > callback.
> > > 
> > > Why not just merge this patch with the change where you implement the init_vm
> > > callback?  Then you can just declare this patch as "detect and initialize TDX
> > > module when first VM is created", or something like that..
> > 
> > Ok. Anyway in the next respoin, tdx module initialization will be done when
> > loading kvm_intel.ko.  So the whole part will be changed and will be a part
> > of module loading.
> 
> Will we change the GET_TDX_CAPABILITIES ioctl back to KVM scope?

No because it system scoped KVM_TDX_CAPABILITIES requires one more callback for
it.  We can reduce the change.

Or do you have any use case for system scoped KVM_TDX_CAPABILITIES?
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>