Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CA+QYu4q7K-pkAbMt3br_7O-Lu2OWyieLfyiju0PNEiy5YdKYzg@mail.gmail.com>
 <CAASaF6yhTpXcWhTyg5VSU6czPPws5+sQ3vR7AWC8xxM7Xm_BGg@mail.gmail.com>
 <YkXv0NoBjLBYBzX8@google.com> <YkX20LtaENdOOYxi@google.com>
In-Reply-To: <YkX20LtaENdOOYxi@google.com>
From:   Jan Stancek <jstancek@redhat.com>
Date:   Thu, 31 Mar 2022 21:27:42 +0200
Message-ID: <CAASaF6xxscL+Zd1dqsykGOEvKwTJ5nDFvv6tOmWN5Mt-GH1QuA@mail.gmail.com>
Subject: Re: RIP: 0010:param_get_bool.cold+0x0/0x2 - LTP read_all_sys - 5.17.0
To:     Sean Christopherson <seanjc@google.com>
Cc:     Bruno Goncalves <bgoncalv@redhat.com>, kvm <kvm@vger.kernel.org>,
        "Bonzini, Paolo" <pbonzini@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>,
        CKI Project <cki-project@redhat.com>,
        Li Wang <liwang@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 31, 2022 at 8:46 PM Sean Christopherson <seanjc@google.com> wrote:
>
> On Thu, Mar 31, 2022, Sean Christopherson wrote:
> > On Wed, Mar 30, 2022, Jan Stancek wrote:
> > > +CC kvm
> > >
> > > Issue seems to be that nx_huge_pages is not initialized (-1) and
> > > attempted to be used as boolean when reading
> > > /sys/module/kvm/parameters/nx_huge_pages
> >
> > Ugh, CONFIG_UBSAN_BOOL=y complains about a bool not being 0 or 1.  What a pain.
>
> Side topic, any idea why your traces don't have the UBSAN output?  I verified

I guess that's because CONFIG_UBSAN_TRAP=y is also set.

# grep UBSAN -r .config
CONFIG_ARCH_HAS_UBSAN_SANITIZE_ALL=y
CONFIG_UBSAN=y
CONFIG_UBSAN_TRAP=y
CONFIG_CC_HAS_UBSAN_BOUNDS=y
CONFIG_UBSAN_BOUNDS=y
CONFIG_UBSAN_ONLY_BOUNDS=y
CONFIG_UBSAN_SHIFT=y
# CONFIG_UBSAN_DIV_ZERO is not set
CONFIG_UBSAN_BOOL=y
CONFIG_UBSAN_ENUM=y
CONFIG_UBSAN_SANITIZE_ALL=y
# CONFIG_TEST_UBSAN is not set

> that it's not a panic_on_warn thing.  Having the UBSAN output in future bug reports
> would be very helpful.
>
> [   13.150244] ================================================================================
> [   13.150780] UBSAN: invalid-load in kernel/params.c:320:33
> [   13.151192] load of value 255 is not a valid value for type '_Bool'
> [   13.152079] ================================================================================
>