Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        andrzej.hajda@intel.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm,
        robert.foss@linaro.org
Subject: [PATCH v6 resend 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()
Date:   Sat,  2 Apr 2022 13:24:47 +0800
Message-Id: <20220402052451.2517469-2-victor.liu@nxp.com>
In-Reply-To: <20220402052451.2517469-1-victor.liu@nxp.com>
References: <20220402052451.2517469-1-victor.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVByOGV1REErVjgwTm1tREo5SlFPK1E2U0VENmMxQUxYL2daM2FJTnVlem4x?=
 =?utf-8?B?ZEsyWXdvSHZTejFvRTlRZHoySS96NHBRUVgvZUpKVkNqMkY5NUdUUTk2L3Rm?=
 =?utf-8?B?dlpNbmRiRE51T0l2TEpUTWVqekZ0WEJxNTBvcEFVT3VqZkloSkJuV0hncjJL?=
 =?utf-8?B?bnRsSmtRTlRWV2JqSG1SVGxYYUdLRzVNeHdpSDJScTFBaDk5dFU3NlhseEly?=
 =?utf-8?B?c1BZSDJralVVVGpDa0FCQnB6WGE3bVlMUzdWVk5XaHpRWEpiWnFHZk1JWGpW?=
 =?utf-8?B?dmQ5bzJnbDZyR2hGU1paY1lQR1duUWNjNEpFNmx4Q2pQb1N0YnpCa0lKRVBi?=
 =?utf-8?B?ZThtbkc4aFRSbjZjMUVuY2ViRHVjc0V3VzRnWVI4K1dpbDdBZms1T3hkeTJz?=
 =?utf-8?B?aEJDTkNudWJkNkQzY0EvUThTL200V1RnRUpVWlR5M1d3UXFqTkhNNll5ZytH?=
 =?utf-8?B?elU3OUdYZituNXI1RWhOajdYcHNFdmg0TFZHN1FnRnJxRlBDODNDRlowOU9W?=
 =?utf-8?B?a2JPZVpGa1crbWlQUmZsczQ1TFJ3SFY4UDQ5bGZQaHcvb3hGcGRuK0h4dFRv?=
 =?utf-8?B?L2VLbjdWMHVXMUMvR1pxdmJaOGs2cU81eW1JbVo4L1lNSjkxVWpsQ3FhSytx?=
 =?utf-8?B?V1pzRDVxUXkrRlR0TkN1UkNlckpSVE9SbS9IaSsva1JNQnNsQXcrVE00Vzhp?=
 =?utf-8?B?QXJINnNCWlQxVVpDeEp4d1B5NFNnMnBLWExTNDB5K1lUWllZS1hBK2l0MEVh?=
 =?utf-8?B?clRiMDgyaWFnVGdscEFvNzNiSi9Xd0RYVStNSXJGemJEY1RMWGxNVklqSEl1?=
 =?utf-8?B?YUkvbU5LT0t0eWRiUWNxNGhPT3lXMCt3VU5odnBscEpiMVQ3c3V5OUw1S0M1?=
 =?utf-8?B?MkNUUFp6K3VsWFVuUVloNWE2YmQ3dytPRkFwUWlyUGhYaU1yc05jSVFodmlh?=
 =?utf-8?B?RUhzQzhNcnFwSUtmNWJRcFdpbjVSMGczS3dRR1RNUDgwcVdtcE82QzNmZSsy?=
 =?utf-8?B?b3dzOHI4UzdldWlxL0phb28wOGZTVG9GVGgrYnpFRE5kTnJvTlZmaG5XZ3NX?=
 =?utf-8?B?bUNmeEpRMHJ1UWpIR1lSa0tKaU9IUHBpb21YSWI0VExWUVkvMVAxU0E5Qk93?=
 =?utf-8?B?RXRSV0FDMnJCazBCWXZvdjlOK0NlZDFONnBkMjAzY2VtbjVQcWNTY0UrYW90?=
 =?utf-8?B?L2dsMEQ1bzJ3RitKNnBQcmFRS1JVaTRlMHBzb3B0SFpLeUFtaHRXR2piaHZt?=
 =?utf-8?B?WWh2eldEUDBLbEd6ZlBDeFBQT0RjdGlsZWI5Mjd1a2xieGtxQWQwWkNSNXVq?=
 =?utf-8?B?TzlpZ25oOHV2RlFzYVlEQS95c2RRbDRTK01Tc3gzbUdIL3lSYVIrVXBBaEdm?=
 =?utf-8?B?bEN2WVkvMHE4cVoxcHNqZU5VRDhiaVhiWmJHVkgzdmV1UlJ5aGxzQ0h0WWdi?=
 =?utf-8?B?ZkZiVG9Ba2VUb2NoSWJsQWZlYjdmQmxkQk43VkM0eTJVUzdmc0VXZTZZU05a?=
 =?utf-8?B?aDJjR29OcHl5aisyd29BaEdjTm0rYjN3aFNPR3JLOHcwUitBZk1JaWRxNXdh?=
 =?utf-8?B?SDNPeVh5OUdRdk9RME5aY3Z5ME00R2llWERsR05za2tjVDV1VmVvejBGOXNr?=
 =?utf-8?B?ZmxOZDRXdlJadjkxSmVrYVhyNVVQOHluQm9CeU5GRUl1VjFqcVhPZmhUbWVW?=
 =?utf-8?B?TXhCTFVPSDRUSnNWSU1xNHBrODkyYThkSExjaWliZnl2Y2ZHcEVuNXY5N2ly?=
 =?utf-8?B?YlVCdS9NUE1kbmFLcm02aEhPMlNYMEdteUIrZlE4bUQxdnFOT0Z3ZTNIWGF2?=
 =?utf-8?B?RVlPNllWb00wM0dRdlk1TUh3OFk4WG44QjhKQTZMMnM1S1ZQK0NyZVlBSkhU?=
 =?utf-8?B?Myt6dEJoKzZVNVdCRnhrWU5ISHRReDM2QXpUbmgvVWU3OVlqYTQ3YXlGU0R0?=
 =?utf-8?B?QThWZkpjL3ZieVFzV25FckZnZmw2dDdpUVErSTRpbkJMU0t1b2t4SWFaOGda?=
 =?utf-8?B?TWRmclVTdjNTbHVZT1YxelRtRHA4RTZMTG0ralhOZVhCZElFVDVmM3ZaaGV5?=
 =?utf-8?B?QlJQNmxub0NobkZSd0tFUFVaNnNHZkFqZFltQXROWFFTTHdDYXVmK0NhZy91?=
 =?utf-8?B?ZC92MlhscGlRd0dNTXV0aTd3WXhONUNVOElKbUtrMGY2SWNiZFBKRitpb3hO?=
 =?utf-8?B?TUFwOHNDNThaN3RhenA0bXpaTitoeUxNS2UxWjhsTjkyTWtJNjllSHNnY0ow?=
 =?utf-8?B?bFpkWFpQZkF5RTIwWUpiUWFpczdZdm1kbFh0V0VMSVkvYVVaVmxoVzBCVFBS?=
 =?utf-8?B?WHF4ckVBYXlncUo5TENabGJDTjh3ZTZMWW1kKzI5SVJSR29oWWxudz09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8e59d9e-c2aa-4a94-cbbe-08da1468e839
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 05:23:23.4258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qVdg6uXkeef2iRHM7HVNZiVicbW1A3f3cXzBwQBca2y3nAnb6BLZRe4IOn6RhHSMHfDcUuhoLNzKK2xEhRECMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8750
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
works with a Mixel MIPI DPHY + LVDS PHY combo to support either
a MIPI DSI display or a LVDS display.  So, this patch calls
phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY
explicitly.

Cc: Guido Günther <agx@sigxcpu.org>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v5->v6:
* Rebase the series upon v5.17-rc1.
* Set PHY mode in ->mode_set() instead of ->pre_enable() in the nwl-dsi
  bridge driver due to the rebase.
* Drop Guido's R-b tag due to the rebase.
* Resend with Andrzej's and Jernej's mail addressed updated.

v4->v5:
* No change.

v3->v4:
* No change.

v2->v3:
* No change.

v1->v2:
* Add Guido's R-b tag.

 drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index a7389a0facfb..5fbfc68a46a5 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -673,6 +673,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi *dsi)
 		return ret;
 	}
 
+	ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
+	if (ret < 0) {
+		DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret);
+		goto uninit_phy;
+	}
+
 	ret = phy_configure(dsi->phy, phy_cfg);
 	if (ret < 0) {
 		DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
-- 
2.25.1