Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        andrzej.hajda@intel.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm,
        robert.foss@linaro.org
Subject: [PATCH v6 resend 2/5] phy: Add LVDS configuration options
Date:   Sat,  2 Apr 2022 13:24:48 +0800
Message-Id: <20220402052451.2517469-3-victor.liu@nxp.com>
In-Reply-To: <20220402052451.2517469-1-victor.liu@nxp.com>
References: <20220402052451.2517469-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QjXNZgBNGr0QboPSXbqZNGfqbELKnaAt+DmlYqWPfbGJvEN1enYwIxzFl0uN?=
 =?us-ascii?Q?YHKhhH/VJPd8AzPlX/NTY9ByL/XHcny4QiDQHNzojk7nlc4sYjZCRojp8ARE?=
 =?us-ascii?Q?uUscR9JllxKz72SFTuV0s4zq+GMiVcBEMbfogZtG6+NN8qVI2CmBrO5tt7lD?=
 =?us-ascii?Q?n1RIOrq4U6Zn+jrC4vnlmibqBQddbuYsyOBcf3aDeE6sgdFk3EOtA3XYHfS0?=
 =?us-ascii?Q?QLOThZPezGisiNKlE4Xh4X5wQQfgMM60o+eA92LeOfXFjEAaWBH+PZhcHL7x?=
 =?us-ascii?Q?iPV1VUs7gH8y5TyCrZgNf5Nylu/PUcXABwKqtgqxxWgdi15CU/n2SAGNHCNU?=
 =?us-ascii?Q?XFqfz5s13NzlSwy8G+AqjEqJBM+iOB5+maQOvCQaF0qi+377su7DzOxar8E5?=
 =?us-ascii?Q?FNRId+vguAgvDvcAKjBIouoiJPm41mws4X0PItaq8GwTUfCFqXZ4ej7Morh2?=
 =?us-ascii?Q?g/HhoBP1zuotGLpp+29nH6y/+zk7HjualvRIonuaazbhZtSxB16k3Vifidcv?=
 =?us-ascii?Q?CYXzPAhZjTQUHHCE3JmuW93FgZq5DKc3IzGS8c+XPJTpHB+jcKsIYOavZOg0?=
 =?us-ascii?Q?+lKI+zLkQ6kZUYNFSdxg1YGsrA9hrMRSi0ZqIcq9e+KJMbKWuoNvRFTNx3qI?=
 =?us-ascii?Q?HqHnXwpDUqQRfN3EOv6ria+0wrrKp755xhUrkegkMKMWEtoz2iCnXLZTZiMm?=
 =?us-ascii?Q?KRNsEsOAXD5Sf8UsopG93T2jClVwmsXx1D03p3jaWwHpDcI1kftylNLbFz46?=
 =?us-ascii?Q?wSArfhyXNXLaPalt2mfwVjaPg03qCmT2zVC9j3MXWwCKvAjM0UxtVBrsfo2e?=
 =?us-ascii?Q?Uix7qXAdnZOGMUJztCJser3oiW/6+RkQQ8TsD+aAUjH18YRXgv0s3kMjnw1S?=
 =?us-ascii?Q?fce82sVEXjokJRZuZRO+aGEs+zFk7pgmeC/HEpGP7k0wC4+N44Iuq1GiuwV/?=
 =?us-ascii?Q?r7NjWg8AqcmahPdTdU6hm/+3ovr1MuyuG4Y7gBc1EoJAnBpXw0ePDC0XfLy2?=
 =?us-ascii?Q?dc0DyoPvKMRnbCP4xSSpJ6lLvMXfKpRDdlSUOb9+nyT4Rcs+N7pRyBIBHS6x?=
 =?us-ascii?Q?9OK11tyo93fX6oqLWfbEUeiUls5fv2ROLpV54QLWgmTYAUMZofJwCE2+VmrO?=
 =?us-ascii?Q?KNJutwsOf9MwMLcho0XI643zFL4vf4HbYqF/Up3zyB10NnGD+S6hL+vapY2V?=
 =?us-ascii?Q?rdPnpAS31EiyJPj5q3a/zCRDE8Z2ld+Bt0YNM6LdH19tHwp3WKGW827n71WF?=
 =?us-ascii?Q?FtBCtBu6QJAm/EtcM2uxIEmvBD1Z+iRWG1C2A/fHpRPYRwQrdUzTV/Kv1Wsq?=
 =?us-ascii?Q?F+ClAL3jKpc4tMYhdU8/iArBs2rG9KyihRbQ6pIyruhyGGM/pmzQIOnndV50?=
 =?us-ascii?Q?xMiP/l4uVuWzNvSEFhsqVhzxseLobJunmKxgetbxb+rS1t/3jyrWd+sL3uma?=
 =?us-ascii?Q?H2RiLEAGzN8OsvMFuLInpjBb48dXT4H9fIey60JVRSSy9Kj+G3QHPwdj9xqY?=
 =?us-ascii?Q?5tg9OnMCBvHq0CID6brDNBA/Swf05zOX5zA+VhEkBLTl9v3ThqkgZUkIX21N?=
 =?us-ascii?Q?rM4xuX8Z0JP2/GquqBAtglvgx5wSfPlCoANT6VzEtMMKUkVUpeVpEQBF0OJe?=
 =?us-ascii?Q?EGIN9PKz2g8PnzmlhjZuQSDcegq5P3fIuiagIOobR1eAmB7qTiC7sf17QxOK?=
 =?us-ascii?Q?eiI2ecaePvA8BEgY0GyQrooTEK4Wd8TwireNhoUXxID9m9GpvNK5ZBLCVwum?=
 =?us-ascii?Q?cF1uDbYa3Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb170a2a-e24d-41e4-47ab-08da1468ec2f
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2022 05:23:30.1147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o+FwNGim5uGBc6cZIv98Y2XxKrB3D2yGWx1F8VzE9J+ZIDym0iLraktk3TPSXTviSJ6B5dQ62c0mMoVJ8Fz7eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8750
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch allows LVDS PHYs to be configured through
the generic functions and through a custom structure
added to the generic union.

The parameters added here are based on common LVDS PHY
implementation practices.  The set of parameters
should cover all potential users.

Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v5->v6:
* Rebase upon v5.17-rc1.

v4->v5:
* Align kernel-doc style to include/linux/phy/phy.h. (Vinod)
* Trivial tweaks.
* Drop Robert's R-b tag.

v3->v4:
* Add Robert's R-b tag.

v2->v3:
* No change.

v1->v2:
* No change.

 include/linux/phy/phy-lvds.h | 32 ++++++++++++++++++++++++++++++++
 include/linux/phy/phy.h      |  4 ++++
 2 files changed, 36 insertions(+)
 create mode 100644 include/linux/phy/phy-lvds.h

diff --git a/include/linux/phy/phy-lvds.h b/include/linux/phy/phy-lvds.h
new file mode 100644
index 000000000000..7a2f4747f624
--- /dev/null
+++ b/include/linux/phy/phy-lvds.h
@@ -0,0 +1,32 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright 2020 NXP
+ */
+
+#ifndef __PHY_LVDS_H_
+#define __PHY_LVDS_H_
+
+/**
+ * struct phy_configure_opts_lvds - LVDS configuration set
+ * @bits_per_lane_and_dclk_cycle:	Number of bits per data lane and
+ *					differential clock cycle.
+ * @differential_clk_rate:		Clock rate, in Hertz, of the LVDS
+ *					differential clock.
+ * @lanes:				Number of active, consecutive,
+ *					data lanes, starting from lane 0,
+ *					used for the transmissions.
+ * @is_slave:				Boolean, true if the phy is a slave
+ *					which works together with a master
+ *					phy to support dual link transmission,
+ *					otherwise a regular phy or a master phy.
+ *
+ * This structure is used to represent the configuration state of a LVDS phy.
+ */
+struct phy_configure_opts_lvds {
+	unsigned int	bits_per_lane_and_dclk_cycle;
+	unsigned long	differential_clk_rate;
+	unsigned int	lanes;
+	bool		is_slave;
+};
+
+#endif /* __PHY_LVDS_H_ */
diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index f3286f4cd306..b1413757fcc3 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -17,6 +17,7 @@
 #include <linux/regulator/consumer.h>
 
 #include <linux/phy/phy-dp.h>
+#include <linux/phy/phy-lvds.h>
 #include <linux/phy/phy-mipi-dphy.h>
 
 struct phy;
@@ -57,10 +58,13 @@ enum phy_media {
  *		the MIPI_DPHY phy mode.
  * @dp:		Configuration set applicable for phys supporting
  *		the DisplayPort protocol.
+ * @lvds:	Configuration set applicable for phys supporting
+ *		the LVDS phy mode.
  */
 union phy_configure_opts {
 	struct phy_configure_opts_mipi_dphy	mipi_dphy;
 	struct phy_configure_opts_dp		dp;
+	struct phy_configure_opts_lvds		lvds;
 };
 
 /**
-- 
2.25.1