Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 2 Apr 2022 13:45:33 +0200
From:   Martin Kaiser <martin@kaiser.cx>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Ira Weiny <ira.weiny@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label
Message-ID: <Ykg3Xfb4vjjGSyKc@martin-debian-2.paytec.ch>
References: <20220401183513.26222-1-fmdefrancesco@gmail.com>
 <YkdjhGtMwnbJcz+P@iweiny-desk3>
 <1724388.VLH7GnMWUR@leap>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1724388.VLH7GnMWUR@leap>
Sender: "Martin Kaiser,,," <martin@martin-debian-2.paytec.ch>
Precedence: bulk

Thus wrote Fabio M. De Francesco (fmdefrancesco@gmail.com):

> > >  	pnpi = netdev_priv(netdev);

> > >  	if (!pnpi->priv)
> > > -		goto RETURN;
> > > +		return;

> I cannot see how pnpi->priv might ever be NULL.

Even if pnpi->priv was NULL, we wouldn't need the check. It's ok to call
vfree(NULL).

> After the two removals I've talked about above, the code will always call 
> vfree(pnpi->priv) and then free_netdev(netdev).

That makes sense.

Best regards,
Martin